Overriding package inclusions/exclusions in kickstart files

[James Heather]

Just spent a while debugging something that turns out to be at best
dubious behaviour in the way kickstart files are handled, and at worst a
bug.

My kickstart file starts by
including /usr/share/spin-kickstarts/fedora-livecd-desktop.ks, which is
the default Live CD build, and then makes some changes. Primarily this
involves adding more packages in.

The theory is that later %package instructions override earlier ones, so
anything that's included by default can still be excluded if I
explicitly exclude it, and anything excluded by default can be
explicitly included. This does work, but turns out to be rather fussier
than one might expect.

I was trying to include the OpenOffice stuff, and also the Java OpenJDK
stuff, including the browser plugin. So I had


        %packages
        java-1.6.0-openjdk*
        openoffice.org-calc
        openoffice.org-writer
        openoffice.org-impress
        openoffice.org-pdfimport
        openoffice.org-draw
        openoffice.org-graphicfilter
        %end


appearing after the include.

But I wasn't getting any OpenOffice stuff, or the browser plugin. It
seems, after some messing about, that this is because of the way wild
cards are handled. The default Live CD kickstart file contains


        %packages
        -java-1.6.0-openjdk-plugin
        -openoffice.org-*
        %end


I would have expected that my overrides would work, and include the
relevant stuff. But it seems that my wildcard inclusion of the openjdk
stuff wasn't enough to override the non-wildcard exclusion of the
plugin, and my non-wildcard inclusion of the OpenOffice programs weren't
enough to override the wildcard exclusion!

Is this expected behaviour? It seems weird to me.

In any case, I've now got it building as expected, by including
openoffice.org-* and java-1.6.0-openjdk-plugin. This still isn't ideal,
because I get a whole load of OpenOffice extras that I don't want (e.g.,
language packs for a thousand languages I don't speak), and I can't see
how to get rid of them short of explicitly excluding them all, which
rather defeats the point of handling wildcards!

James

[Alan Pevec]

On Wed, Apr 13, 2011 at 4:34 AM, James Heather <j.heather(a)surrey.ac.uk&gt; wrote:
>  Is this expected behaviour? It seems weird to me. 
Yes,  that's the current implementation:
package patterns are resolved only when building Yum transaction,
selected are added first, then deselected are removed, see
imgcreate.ImageCreator.install()
while overrides work verbatim when pykickstart is parsing %packages
sections, from pykickstart.parser.Packages.add():
        existingPackageSet = (existingPackageSet - newExcludedSet) |
newPackageSet
        existingExcludedSet = (existingExcludedSet -
existingPackageSet) | newExcludedSet

After that, order information is lost and to fix this pykickstart
needs to be extended to provide original package list to livecd.
As a test you can try ksflatten on your kickstart, to see how is it
parsed and what livecd-creator is getting.

Alan

[James Heather]

On Wed, 2011-04-13 at 09:24 +0100, Alan Pevec wrote:

>  On Wed, Apr 13, 2011 at 4:34 AM, James Heather
> <j.heather(a)surrey.ac.uk&gt; wrote:
>  > Is this expected behaviour? It seems weird to me.
>  
>  Yes,  that's the current implementation:
>  package patterns are resolved only when building Yum transaction,
>  selected are added first, then deselected are removed 

Does this mean there's no way of getting a sensible set of OpenOffice
packages on my live cd, other than either

    (1) not including fedora-livecd-desktop.ks

or

    (2) including openoffice.org-*, and then explicitly excluding each
individual langpack?

I can exclude openoffice.org-langpack*, of course, but then if I include
openoffice.org-langpack-en, it won't take effect because the wildcard
will trump the individual one.

James