Re: [Fedora-livecd-list] [revisor-users] AttributeError

[Jeroen van Meeuwen]

Lars Bjørndal wrote:
> Hello list!
>
> What does this error mean:

Hey Lars,

it means an API incompatible release for livecd-creator has been pushed to 
what is supposed to be a stable Fedora release...

-- Jeroen
> e2image 1.41.10 (10-Feb-2009)
> resize2fs 1.41.10 (10-Feb-2009)
> Resizing the filesystem on /var/tmp/revisor-rundir/tmp-/ext3fs.img to
> 786432 (4\
> k) blocks.
> The filesystem on /var/tmp/revisor-rundir/tmp-/ext3fs.img is now 786432
> blocks \
> long.
>
> Checking filesystem /var/tmp/revisor-rundir/tmp-/ext3fs.img
> e2fsck 1.41.10 (10-Feb-2009)
> Pass 1: Checking inodes, blocks, and sizes
> Pass 2: Checking directory structure
> Pass 3: Checking directory connectivity
> Pass 4: Checking reference counts
> Pass 5: Checking group summary information
> _fedora-20101021: 74540/196608 files (0.1% non-contiguous),
> 479548/786432 block\
> s
> Traceback (most recent call last):
>   File "/usr/lib/python2.6/site-packages/revisor/__init__.py", line 528,
>   in run
>     self.base.run()
>   File "/usr/lib/python2.6/site-packages/revisor/base.py", line 107, in
>   run
>     self.cli.run()
>   File "/usr/lib/python2.6/site-packages/revisor/cli.py", line 44, in
>   run
>     self.base.lift_off()
>   File "/usr/lib/python2.6/site-packages/revisor/base.py", line 910, in
>   lift_of\
> f
>     self.buildLiveMedia()
>   File "/usr/lib/python2.6/site-packages/revisor/base.py", line 1796, in
>   buildL\
> iveMedia
>
> liveImage.package(destdir=os.path.join(self.cfg.destination_directory,"liv
> e\ "))
>   File "/usr/lib/python2.6/site-packages/imgcreate/creator.py", line
>   769, in pa\
> ckage
>     self._stage_final_image()
>   File "/usr/lib/python2.6/site-packages/imgcreate/live.py", line 300,
>   in _stag\
> e_final_image
>     create_image_minimizer(self.__isodir + "/LiveOS/osmin.img",
>     self._image, se\
> lf.compress_type)
> AttributeError: 'x86LiveImageCreator' object has no attribute
> 'compress_type'
> Traceback occurred, please report a bug at
> http://fedorahosted.org/revisor
>
> Lars
> _______________________________________________
> revisor-users mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/revisor-users

[revisor-users] AttributeError

[Bruno Wolff III]

On Thu, Oct 28, 2010 at 00:50:52 +0100,
  Jeroen van Meeuwen  wrote:
> Lars Bjørndal wrote:
> > Hello list!
> >
> > What does this error mean:
>
> Hey Lars,
>
> it means an API incompatible release for livecd-creator has been pushed to 
> what is supposed to be a stable Fedora release...

The same problem is in F14 and rawhide. It wasn't obvious that livecd-tools
was supplying a library to outside packages and the problem wasn't
noticed in F14 after it had apparently been broken for months. And there
doesn't seem to be any use of versions dependencies to get the issue noticed
that way.

[revisor-users] AttributeError

[Alan Pevec]

On Thu, Oct 28, 2010 at 4:24 AM, Bruno Wolff III  wrote:
> On Thu, Oct 28, 2010 at 00:50:52 +0100,
>  Jeroen van Meeuwen  wrote:
> > Lars Bjørndal wrote:
> > > Hello list!
> > >
> > > What does this error mean:
> >
> > Hey Lars,
> >
> > it means an API incompatible release for livecd-creator has been pushed
>
> to
> > what is supposed to be a stable Fedora release...
>
> The same problem is in F14 and rawhide. It wasn't obvious that livecd-tools
> was supplying a library to outside packages and the problem wasn't
> noticed in F14 after it had apparently been broken for months. And there
> doesn't seem to be any use of versions dependencies to get the issue
> noticed
> that way.

There some docs about livecd-tools API, which should probably be revisited
now: http://git.fedorahosted.org/git/?p=livecd;a=blob;f=API
But in this case, Revisor is extending imgcreate classes in a way which
relies on internals and cannot be considered part of the stable API:
http://git.fedorahosted.org/git/?p=revisor;a=blob;f=revisor/image.py

Alan

[revisor-users] AttributeError

[Brian C. Lane]

On Thu, Oct 28, 2010 at 06:41:43PM +0200, Alan Pevec wrote:
> On Thu, Oct 28, 2010 at 4:24 AM, Bruno Wolff III  wrote:
> > On Thu, Oct 28, 2010 at 00:50:52 +0100,
> >  Jeroen van Meeuwen  wrote:
> > > Lars Bjørndal wrote:
> > > > Hello list!
> > > >
> > > > What does this error mean:
> > >
> > > Hey Lars,
> > >
> > > it means an API incompatible release for livecd-creator has been pushed
> >
> > to
> > > what is supposed to be a stable Fedora release...
> >
> > The same problem is in F14 and rawhide. It wasn't obvious that livecd-tools
> > was supplying a library to outside packages and the problem wasn't
> > noticed in F14 after it had apparently been broken for months. And there
> > doesn't seem to be any use of versions dependencies to get the issue
> > noticed
> > that way.
>
> There some docs about livecd-tools API, which should probably be revisited
> now: http://git.fedorahosted.org/git/?p=livecd;a=blob;f=API
> But in this case, Revisor is extending imgcreate classes in a way which
> relies on internals and cannot be considered part of the stable API:
> http://git.fedorahosted.org/git/?p=revisor;a=blob;f=revisor/image.py

Thanks for the info. We should make sure the API doc is uptodate, and if
other projects feel the need to use internals figure out what they need
and expose it in a clean way.

[revisor-users] AttributeError

[Jeroen van Meeuwen]

Brian C. Lane wrote:
> Thanks for the info. We should make sure the API doc is uptodate, and if
> other projects feel the need to use internals figure out what they need
> and expose it in a clean way.

It's funny you should mention that, because that's what I've been fighting for 
the last 3 years or so. FYI, same goes for pungi.

Kind regards,

Jeroen van Meeuwen
-kanarip