Branch 'f17-branch' - 4 commits - imgcreate/live.py imgcreate/yuminst.py Makefile tools/livecd-iso-to-disk.sh

[Brian C. Lane]

 Makefile                    |    2 +-
 imgcreate/live.py           |    8 +-------
 imgcreate/yuminst.py        |   10 +++++-----
 tools/livecd-iso-to-disk.sh |    2 +-
 4 files changed, 8 insertions(+), 14 deletions(-)

New commits:
commit 85853646ffc96782281e8478b44182eebfa4d9e1
Author: Brian C. Lane <bcl(a)redhat.com&gt;
Date:   Wed Apr 3 10:44:48 2013 -0700

    Version 17.15

diff --git a/Makefile b/Makefile
index 7329fd6..935249e 100644
--- a/Makefile
+++ b/Makefile
@@ -1,5 +1,5 @@
 
-VERSION = 17.15
+VERSION = 17.16
 
 INSTALL = /usr/bin/install -c
 INSTALL_PROGRAM = ${INSTALL}


commit ae1a477c319edd805862c676b23612ae617b1857
Author: Brian C. Lane <bcl(a)redhat.com&gt;
Date:   Wed Apr 3 10:17:24 2013 -0700

    Use parted to check for GPT disklabel (#947653)

diff --git a/tools/livecd-iso-to-disk.sh b/tools/livecd-iso-to-disk.sh
index fd10232..0b4d2c8 100755
--- a/tools/livecd-iso-to-disk.sh
+++ b/tools/livecd-iso-to-disk.sh
@@ -519,7 +519,7 @@ checkGPT() {
     dev=$1
     getdisk $dev
 
-    if [ "$(/sbin/fdisk -l $device 2>/dev/null |grep -c GPT)" -eq
"0" ]; then
+    if [ "$(/sbin/parted -m $device p 2>/dev/null |grep -ic :gpt:)" -eq
"0" ]; then
         echo "EFI boot requires a GPT partition table."
         echo "This can be done manually or you can run with --format"
         exitclean


commit 0ee66349e5d2c03261500718f1b9b62261b11d5b
Author: Brian C. Lane <bcl(a)redhat.com&gt;
Date:   Wed Apr 3 09:21:55 2013 -0700

    Output details of dep check failure

diff --git a/imgcreate/yuminst.py b/imgcreate/yuminst.py
index 97e5ecf..8581978 100644
--- a/imgcreate/yuminst.py
+++ b/imgcreate/yuminst.py
@@ -193,7 +193,7 @@ class LiveCDYum(yum.YumBase):
                     return True
         return False
 
-            
+
     def runInstall(self):
         os.environ["HOME"] = "/"
         try:
@@ -206,19 +206,19 @@ class LiveCDYum(yum.YumBase):
             return res
         if res != 2:
             raise CreatorError("Failed to build transaction : %s" %
str.join("\n", resmsg))
-        
+
         dlpkgs = map(lambda x: x.po, filter(lambda txmbr: txmbr.ts_state in
("i", "u"), self.tsInfo.getMembers()))
         self.downloadPkgs(dlpkgs)
         # FIXME: sigcheck?
-        
+
         self.initActionTs()
         self.populateTs(keepold=0)
         deps = self.ts.check()
         if len(deps) != 0:
-            raise CreatorError("Dependency check failed!")
+            raise CreatorError("Dependency check failed : %s" %
"\n".join(deps))
         rc = self.ts.order()
         if rc != 0:
-            raise CreatorError("ordering packages for installation failed!")
+            raise CreatorError("ordering packages for installation failedr. rc =
%s" % rc)
 
         # FIXME: callback should be refactored a little in yum 
         sys.path.append('/usr/share/yum-cli')


commit 817fedcb0482d6f1671b1b229ee4e563b170f716
Author: Brian C. Lane <bcl(a)redhat.com&gt;
Date:   Thu Mar 28 16:26:37 2013 -0700

    Properly generate kernel stanzas (#928093)

diff --git a/imgcreate/live.py b/imgcreate/live.py
index 4aa220e..87d5129 100755
--- a/imgcreate/live.py
+++ b/imgcreate/live.py
@@ -541,14 +541,8 @@ menu separator
         return template % args
 
     def __get_image_stanzas(self, isodir):
-        versions = []
         kernels = self._get_kernel_versions()
-        for kernel in kernels:
-            for version in kernels[kernel]:
-                versions.append(version)
-
         kernel_options = self._get_kernel_options()
-
         checkisomd5 = self._has_checkisomd5()
 
         # Stanzas for insertion into the config template
@@ -557,7 +551,7 @@ menu separator
         check = []
 
         index = "0"
-        for version in versions:
+        for kernel, version in ((k,v) for k in kernels for v in kernels[k]):
             (is_xen, isDracut) = self.__copy_kernel_and_initramfs(isodir, version,
index)
             if index == "0":
                 self._isDracut = isDracut