Trying to build from GIT

[Jeroen van Meeuwen]

Hi,

I'm building livecd-tools from the latest code in GIT, but rpmlint 
complaints like there's no tomorrow:

[jmeeuwen@elwood devel]$ rpmlint 
/var/lib/mock/fedora-8-x86_64/result/livecd-tools-013-1.fc8.x86_64.rpm
livecd-tools.x86_64: E: non-executable-script 
/usr/lib/python2.5/site-packages/imgcreate/kickstart.py 0644
livecd-tools.x86_64: E: non-executable-script 
/usr/lib/python2.5/site-packages/imgcreate/errors.py 0644
livecd-tools.x86_64: E: non-executable-script 
/usr/lib/python2.5/site-packages/imgcreate/creator.py 0644
livecd-tools.x86_64: E: non-executable-script 
/usr/lib/python2.5/site-packages/imgcreate/fs.py 0644
livecd-tools.x86_64: E: non-executable-script 
/usr/lib/python2.5/site-packages/imgcreate/yuminst.py 0644
livecd-tools.x86_64: E: non-executable-script 
/usr/lib/python2.5/site-packages/imgcreate/live.py 0644
livecd-tools.x86_64: E: non-executable-script 
/usr/lib/python2.5/site-packages/imgcreate/__init__.py 0644
livecd-tools.x86_64: W: invalid-license GPL
livecd-tools.x86_64: E: no-binary
livecd-tools.x86_64: E: only-non-binary-in-usr-lib

Could these be fixed at some point in time please? Thanks, in advance.

Kind regards,

Jeroen van Meeuwen
-kanarip

[Mark McLoughlin]

Hi,

On Sat, 2007-12-29 at 23:02 +0100, Jeroen van Meeuwen wrote:
> Hi,
>
> I'm building livecd-tools from the latest code in GIT, but rpmlint 
> complaints like there's no tomorrow:

Thanks for pointing these out.
> [jmeeuwen@elwood devel]$ rpmlint 
> /var/lib/mock/fedora-8-x86_64/result/livecd-tools-013-1.fc8.x86_64.rpm
> livecd-tools.x86_64: E: non-executable-script 
> /usr/lib/python2.5/site-packages/imgcreate/kickstart.py 0644
> livecd-tools.x86_64: E: non-executable-script 
> /usr/lib/python2.5/site-packages/imgcreate/errors.py 0644
> livecd-tools.x86_64: E: non-executable-script 
> /usr/lib/python2.5/site-packages/imgcreate/creator.py 0644
> livecd-tools.x86_64: E: non-executable-script 
> /usr/lib/python2.5/site-packages/imgcreate/fs.py 0644
> livecd-tools.x86_64: E: non-executable-script 
> /usr/lib/python2.5/site-packages/imgcreate/yuminst.py 0644
> livecd-tools.x86_64: E: non-executable-script 
> /usr/lib/python2.5/site-packages/imgcreate/live.py 0644
> livecd-tools.x86_64: E: non-executable-script 
> /usr/lib/python2.5/site-packages/imgcreate/__init__.py 0644

Fixed these by removing the #!
> livecd-tools.x86_64: W: invalid-license GPL

Changed the license tag to GPLv2.
> livecd-tools.x86_64: E: no-binary

We don't have any arch specific binaries, so it should be a noarch
package?

I presume it's not noarch since it has different RPM requires on
different arches?
> livecd-tools.x86_64: E: only-non-binary-in-usr-lib

This is that /usr/lib/livecd-creator/mayflower should be in /usr/share?
Any reason not to?

Cheers,
Mark.

[Jeremy Katz]

On Wed, 2008-01-02 at 10:04 +0000, Mark McLoughlin wrote:
> On Sat, 2007-12-29 at 23:02 +0100, Jeroen van Meeuwen wrote:
> > livecd-tools.x86_64: E: no-binary
>
> We don't have any arch specific binaries, so it should be a noarch
> package?
>
> I presume it's not noarch since it has different RPM requires on
> different arches?

Correct.  This is just one of those cases where rpmlint isn't always
correct
> > livecd-tools.x86_64: E: only-non-binary-in-usr-lib
>
> This is that /usr/lib/livecd-creator/mayflower should be in /usr/share?
> Any reason not to?

Leaving it in /usr/lib keeps things working for people running various
versions.  Longer term, it needs to go away anyway and be replaced with
mkinitrd handling live images correctly.

Jeremy