livecd-creator fails with $TMPDIR not in build root

[Jim Meyering]

I've been experimenting with livecd-creator and my first
run failed because I had TMPDIR=/t/jt7300.Wu7340.
[btw, this is on rawhide x86_64, with latest cloned from git]

I did this:

./livecd-creator \
    --config=/usr/share/livecd-tools/livecd-fedora-minimal.ks \
    --cache=/tmp/livecd-cache

When I reran it with a more conventional TMPDIR, it completed
successfully:

TMPDIR=/tmp ./livecd-creator \
    --config=/usr/share/livecd-tools/livecd-fedora-minimal.ks \
    --cache=/tmp/livecd-cache

FYI, here's how it failed:

Building an initramfs at /boot/livecd-initramfs-2.6.23.1-42.fc8.img for kernel 2.
6.23.1-42.fc8
mktemp: cannot make temp dir /t/jt7300.Wu7340/tmp.RfvfM24995: No such file or dir
ectory
Traceback (most recent call last):
  File "/home/meyering/w/co/livecd/creator/livecd-creator", line 1603, in <module
>

sys.exit(main())
  File "/home/meyering/w/co/livecd/creator/livecd-creator", line 1575, in main
    target.install()
  File "/home/meyering/w/co/livecd/creator/livecd-creator", line 959, in install
    self.configureBootloader()
  File "/home/meyering/w/co/livecd/creator/livecd-creator", line 1230, in configu
reBootloader
    %(self.build_dir, count))
  File "/usr/lib64/python2.5/shutil.py", line 46, in copyfile
    fsrc = open(src, 'rb')
IOError: [Errno 2] No such file or directory: '/var/tmp/livecd-creator-zHqhMn/ins
tall_root/boot/livecd-initramfs-2.6.23.1-42.fc8.img'
[Exit 1]

[PATCH] Don't let a nonstandard TMPDIR setting cause malfunction.

[Jim Meyering]

In http://thread.gmane.org/gmane.linux.redhat.fedora.livecd/1222,
[Re: [Fedora-livecd-list] livecd-creator fails with $TMPDIR not in build root]
I reported this failure:

Jim Meyering  wrote:
> I've been experimenting with livecd-creator and my first
> run failed because I had TMPDIR=/t/jt7300.Wu7340.
> [btw, this is on rawhide x86_64, with latest cloned from git]

...

Here's a patch:

[PATCH] Don't let a nonstandard TMPDIR setting cause malfunction.

[Jim Meyering]

[resending, in such a way that Mailman doesn't strip the patch]

In http://thread.gmane.org/gmane.linux.redhat.fedora.livecd/1222,
[Re: [Fedora-livecd-list] livecd-creator fails with $TMPDIR not in build root]
I reported this failure:

Jim Meyering  wrote:
> I've been experimenting with livecd-creator and my first
> run failed because I had TMPDIR=/t/jt7300.Wu7340.
> [btw, this is on rawhide x86_64, with latest cloned from git]

...

Here's a patch:

[I've added the '>', to protect against a bug this old version of Mailman]
> From 342e0ff30f18668741e2129d3a2793c0f2954b65 Mon Sep 17 00:00:00 2001
> From: Jim Meyering 
> Date: Fri, 16 Nov 2007 22:32:34 +0100
> Subject: [PATCH] Don't let a nonstandard TMPDIR setting cause malfunction.

Signed-off-by: Jim Meyering 
---
 creator/mayflower |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/creator/mayflower b/creator/mayflower
index 9a5c863..232281c 100755
--- a/creator/mayflower
+++ b/creator/mayflower
@@ -8,6 +8,10 @@
 # Inspired by similar programs from a bunch of other distributions.
 #

+# Override any TMPDIR setting from the environment, since this script is
+# run in a chroot: a nonstandard $TMPDIR setting would make mktemp fail.
+export TMPDIR=/tmp
+
 usage() {
     echo "$0 [--help] <out-initrd-image> <kernel-version>"
     echo