[PATCH] 'ImageCreator' object has no attribute '_fstype'

[Leo Baltus]

Hi,

When calling ImageCreator directly it seems it is missing _fstype.

Attached patch adds this to the ImageCreator class.

steps to reproduce:

    creator = imgcreate.ImageCreator(ks, name, None, tmp)
    creator.create()

...

  File "/usr/lib/python2.7/site-packages/imgcreate/creator.py", line 235, in
_get_fstab
    s =  "/dev/root  /         %s    defaults,noatime 0 0\n" %(self._fstype)
AttributeError: 'ImageCreator' object has no attribute '_fstype'

This is on Centos Linux 7, using python-imgcreate-20.1-2.el7.x86_64

I hope this patch is suitable for inclusion in future releases.

-- 
Leo Baltus, internetbeheerder
NPO ICT Internet Services
Bart de Graaffweg 2, 1217 ZL Hilversum

[Brian C. Lane]

On Fri, Oct 10, 2014 at 01:10:19PM +0200, Leo Baltus wrote:
>  Hi,
>  
>  When calling ImageCreator directly it seems it is missing _fstype.
>  
>  Attached patch adds this to the ImageCreator class.
>  
>  steps to reproduce:
>  
>      creator = imgcreate.ImageCreator(ks, name, None, tmp)
>      creator.create()
>  
>  ...
>  
>    File "/usr/lib/python2.7/site-packages/imgcreate/creator.py", line 235, in
> _get_fstab
>      s =  "/dev/root  /         %s    defaults,noatime 0 0\n" %(self._fstype)
>  AttributeError: 'ImageCreator' object has no attribute '_fstype'
>  
>  This is on Centos Linux 7, using python-imgcreate-20.1-2.el7.x86_64
>  
>  I hope this patch is suitable for inclusion in future releases.
>  
>  -- 
>  Leo Baltus, internetbeheerder
>  NPO ICT Internet Services
>  Bart de Graaffweg 2, 1217 ZL Hilversum 
>  --- imgcreate/creator.py.org	2014-08-24 13:03:06.623608872 +0200
>  +++ imgcreate/creator.py	2014-08-24 12:52:23.270674918 +0200
>  @@ -89,6 +89,7 @@
>           self.__bindmounts = []
>   
>           self.__sanity_check()
>  +        self._fstype = kickstart.get_image_fstype(self.ks, "ext3")
>   
>           # get selinuxfs mountpoint
>           self.__selinux_mountpoint = "/sys/fs/selinux" 
>  --
>  livecd mailing list
>  livecd(a)lists.fedoraproject.org
>  https://admin.fedoraproject.org/mailman/listinfo/livecd 
Thanks, I'm going to go a bit further and just move all the fstype
handling up into ImageCreator, it doesn't make sense to have it depend
on things from a subclass.


-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

livecd-tools.spec

[Leo Baltus]

Op 10/10/2014 om 09:28:21 -0700, schreef Brian C. Lane:
>  On Fri, Oct 10, 2014 at 01:10:19PM +0200, Leo Baltus wrote:
>  > Hi,
>  > 
>  > When calling ImageCreator directly it seems it is missing _fstype.
>  > 
>  > Attached patch adds this to the ImageCreator class. 
...
>  
>  Thanks, I'm going to go a bit further and just move all the fstype
>  handling up into ImageCreator, it doesn't make sense to have it depend
>  on things from a subclass.
>  
>   
I would like to build a new rpm from git.

It seems livecd-tools.spec is not there, where can I find it?

-- 
Leo Baltus, internetbeheerder
NPO ICT Internet Services
Bart de Graaffweg 2, 1217 ZL Hilversum
servicedesk(a)omroep.nl, 035-6773555

livecd-tools.spec

[Cristian Ciupitu]

On Wednesday, October 22, 2014 12:08 PM, Leo Baltus <Leo.Baltus(a)omroep.nl&gt; wrote:
> I would like to build a new rpm from git.
>
> It seems livecd-tools.spec is not there, where can I find it? 
Go to https://apps.fedoraproject.org/packages/ and search for
livecd-tools. On the left side menu of its page, you'll find a link
named SCM. It points to the git repository of the src RPM,
http://pkgs.fedoraproject.org/cgit/livecd-tools.git

Cheers,
Cristian Ciupitu

livecd-tools.spec

[Leo Baltus]

Op 22/10/2014 om 11:19:25 +0000, schreef Cristian Ciupitu:
>  On Wednesday, October 22, 2014 12:08 PM, Leo Baltus
> <Leo.Baltus(a)omroep.nl&gt; wrote:
>  >I would like to build a new rpm from git.
>  >
>  >It seems livecd-tools.spec is not there, where can I find it?
>  
>  Go to https://apps.fedoraproject.org/packages/ and search for
>  livecd-tools. On the left side menu of its page, you'll find a link
>  named SCM. It points to the git repository of the src RPM,
>  http://pkgs.fedoraproject.org/cgit/livecd-tools.git
>   
Thanks.

-- 
Leo Baltus, internetbeheerder
NPO ICT Internet Services
Bart de Graaffweg 2, 1217 ZL Hilversum
servicedesk(a)omroep.nl, 035-6773555