[PATCH] allow for use of yum plugins during livecd creation

[Bill Nottingham]

https://bugzilla.redhat.com/show_bug.cgi?id=813429

This adds an option ("-p", or "--plugins") to livecd-creator to allow
for
the use of yum plugins during image creation. The initial usage case is
for localized live images that want to use yum-langpacks when creating their
live image so that they include the proper language packs for their locale.

Aside from the noise of propagating the commandline options down to the yum
instance, there is a bugfix where we re-call repository setup after we've
actually added the repositories; this is required so that plugins operate
properly.

Bill

[Brian C. Lane]

On Mon, Apr 23, 2012 at 06:31:22PM -0400, Bill Nottingham wrote:
>  https://bugzilla.redhat.com/show_bug.cgi?id=813429
>  
>  This adds an option ("-p", or "--plugins") to livecd-creator to allow
> for
>  the use of yum plugins during image creation. The initial usage case is
>  for localized live images that want to use yum-langpacks when creating their
>  live image so that they include the proper language packs for their locale.
>  
>  Aside from the noise of propagating the commandline options down to the yum
>  instance, there is a bugfix where we re-call repository setup after we've
>  actually added the repositories; this is required so that plugins operate
>  properly.
>  
>  Bill 
That looks pretty good. My concern with turning on plugins is that you
are enabling whatever plugins are installed on the host with this, and
that may not be what you really want.

You can also setup the plugin and plugin config paths in the yum.conf,
but I can't think of a clean way to integrate those so that it is easy
to use. eg. you'd have to install the desired plugin to a pair of
directories and then add them to the cmdline.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

[Bill Nottingham]

Brian C. Lane (bcl(a)redhat.com) said: 
>  On Mon, Apr 23, 2012 at 06:31:22PM -0400, Bill Nottingham wrote:
>  > https://bugzilla.redhat.com/show_bug.cgi?id=813429
>  > 
>  > This adds an option ("-p", or "--plugins") to livecd-creator to
> allow for
>  > the use of yum plugins during image creation. The initial usage case is
>  > for localized live images that want to use yum-langpacks when creating their
>  > live image so that they include the proper language packs for their locale.
>  > 
>  > Aside from the noise of propagating the commandline options down to the yum
>  > instance, there is a bugfix where we re-call repository setup after we've
>  > actually added the repositories; this is required so that plugins operate
>  > properly.
>  > 
>  > Bill
>  
>  That looks pretty good. My concern with turning on plugins is that you
>  are enabling whatever plugins are installed on the host with this, and
>  that may not be what you really want. 
True, but given you have to explicitly specify -p to get plugins, I think
that's reasonable - you asked for them, you get them.

Someone has noted elsewhere that this may be useful for
subscription-manager's product id functionality with live images, as those
are retrieved via a yum plugin as well.

Bill