spec file : corrections needed

[Chitlesh GOORAH]

Hello there,

The actual cvs spec file of kadischi allows rpm builds successfully.

But rpmlint -i complains.

chitlesh(i386)[0]$rpmlint -i kadischi-2.1-2.20060616cvs.i386.rpm
W: kadischi no-version-in-last-changelog
The last changelog entry doesn't contain a version. Please insert the
version that is coherent with the version of the package and rebuild it.

E: kadischi arch-dependent-file-in-usr-share
/usr/share/kadischi/install/scanswap
This package installs an ELF binary in the /usr/share
 hierarchy, which is reserved for architecture-independent files.

E: kadischi arch-dependent-file-in-usr-share
/usr/share/kadischi/initrd/find-live-cd
This package installs an ELF binary in the /usr/share
 hierarchy, which is reserved for architecture-independent files.

E: kadischi script-without-shellbang /usr/share/doc/kadischi-2.1/COPYING
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.

E: kadischi script-without-shellbang /usr/share/kadischi/lib/shvar.py
This executable text file does not contain a shebang, thus it cannot be
properly executed.  Often this is a sign of spurious executable bits for a
non-script file, but can also be a case of a missing shebang.  To fix this
error, find out which case of the above it is, and either remove the
executable bits or add the shebang.

E: kadischi zero-length /usr/share/doc/kadischi-2.1/NEWS


I've worked on some of these, ill send a patch in a few minutes.

-- 
http://clunixchit.blogspot.com

[Chitlesh GOORAH]

On 6/17/06, Chitlesh GOORAH <chitlesh(a)fedoraproject.org&gt; wrote:
>  chitlesh(i386)[0]$rpmlint -i kadischi-2.1-2.20060616cvs.i386.rpm
>  W: kadischi no-version-in-last-changelog
>  The last changelog entry doesn't contain a version. Please insert the
>  version that is coherent with the version of the package and rebuild it. 
We should use the FE format
* Fri Jun 16 2006 Chitlesh Goorah <chitleshATfedoraprojectDOTorg> -
2.1-2.20060617cvs

>  E: kadischi script-without-shellbang
> /usr/share/doc/kadischi-2.1/COPYING
>  This executable text file does not contain a shebang, thus it cannot be
>  properly executed.  Often this is a sign of spurious executable bits for a
>  non-script file, but can also be a case of a missing shebang.  To fix this
>  error, find out which case of the above it is, and either remove the
>  executable bits or add the shebang. 
Ive chmod 644 COPYING and already committed it to cvs

>  E: kadischi script-without-shellbang
> /usr/share/kadischi/lib/shvar.py
>  This executable text file does not contain a shebang, thus it cannot be
>  properly executed.  Often this is a sign of spurious executable bits for a
>  non-script file, but can also be a case of a missing shebang.  To fix this
>  error, find out which case of the above it is, and either remove the
>  executable bits or add the shebang.
>  
I've chmod 644 %{buildroot}%{_datadir}/%{name}/lib/shvar.py


>  E: kadischi zero-length /usr/share/doc/kadischi-2.1/NEWS
>  
I chose to drop NEWS because its empty and its useless.


I haven't worked on these yet:

>  E: kadischi arch-dependent-file-in-usr-share
>  /usr/share/kadischi/install/scanswap
>  This package installs an ELF binary in the /usr/share
>   hierarchy, which is reserved for architecture-independent files.
>
>  E: kadischi arch-dependent-file-in-usr-share
>  /usr/share/kadischi/initrd/find-live-cd
>  This package installs an ELF binary in the /usr/share
>   hierarchy, which is reserved for architecture-independent files.
>  
The patch is attached to this mail.


-- 
http://clunixchit.blogspot.com

[J. Hartline]

Chitlesh GOORAH wrote:

>  On 6/17/06, Chitlesh GOORAH <chitlesh(a)fedoraproject.org&gt;
> wrote:
>
>  The patch is attached to this mail. 
Committed.

Thanks Chitlesh.
J. Hartline

[J. Hartline]

Chitlesh GOORAH wrote:

>  E: kadischi arch-dependent-file-in-usr-share
>  /usr/share/kadischi/install/scanswap
>  This package installs an ELF binary in the /usr/share
>  hierarchy, which is reserved for architecture-independent files.
>
>  E: kadischi arch-dependent-file-in-usr-share
>  /usr/share/kadischi/initrd/find-live-cd
>  This package installs an ELF binary in the /usr/share
>  hierarchy, which is reserved for architecture-independent files. 
We can put these in /usr/lib/kadischi perhaps, they aren't libraries but 
/usr/bin/kadischi.d doesn't seem right to me.
What do you think?

[Chitlesh GOORAH]

On 6/17/06, Jasper O'neal Hartline <jasperhartline(a)adelphia.net&gt; wrote:
>  We can put these in /usr/lib/kadischi perhaps, they aren't
> libraries but
>  /usr/bin/kadischi.d doesn't seem right to me.
>  What do you think?
>  
system binaries (those intended for root only) not needed for boot or
recovery live in /usr/sbin.
Also, binaries intended to be run by programs and not by people can
live under /usr/libexec.

so which to follow ?
find-live-cd and scanswap are to be run by kadischi, I suggest to use
/usr/libexec



-- 
http://clunixchit.blogspot.com

[Chitlesh GOORAH]

And we have to correct these too in the spec file :

+ glib-gettextize --copy --force
Copying file mkinstalldirs
Copying file po/Makefile.in.in

Please add the files
  codeset.m4 gettext.m4 glibc21.m4 iconv.m4 isc-posix.m4 lcmessage.m4
  progtest.m4
from the /usr/share/aclocal directory to your autoconf macro directory
or directly to your aclocal.m4 file.
You will also need config.guess and config.sub, which you can get from
ftp://ftp.gnu.org/pub/gnu/config/.


-- 
http://clunixchit.blogspot.com

[Toshio Kuratomi]

On Sat, 2006-06-17 at 21:43 +0200, Chitlesh GOORAH wrote:
>  On 6/17/06, Jasper O'neal Hartline
> <jasperhartline(a)adelphia.net&gt; wrote:
>  > We can put these in /usr/lib/kadischi perhaps, they aren't libraries but
>  > /usr/bin/kadischi.d doesn't seem right to me.
>  > What do you think?
>  >
>  
>  system binaries (those intended for root only) not needed for boot or
>  recovery live in /usr/sbin.
>  Also, binaries intended to be run by programs and not by people can
>  live under /usr/libexec.
>  
>  so which to follow ?
>  find-live-cd and scanswap are to be run by kadischi, I suggest to use
>  /usr/libexec
>   
+1 %{_libexecdir}.

If this is done at the Makefile.am level then people who don't want
kadischi installed in /usr/libexec can define LIBEXECDIR to /usr/sbin or
%{_libdir}/kadischi at buildtime to place the files in a different
location.

-Toshio

[Chitlesh GOORAH]

On 6/18/06, Toshio Kuratomi <a.badger(a)gmail.com&gt; wrote:
>  +1 %{_libexecdir}.
>
>  If this is done at the Makefile.am level then people who don't want
>  kadischi installed in /usr/libexec can define LIBEXECDIR to /usr/sbin or
>  %{_libdir}/kadischi at buildtime to place the files in a different
>  location.
>  
Like this, we are falling on

W: kadischi non-standard-dir-in-usr libexec
Your package is creating a non-standard subdirectory in /usr. The standard
directories are:
        -X11R6          -X386
        -bin            -games
        -include        -lib
        -local          -sbin
        -share          -src
        -spool          -tmp
        -lib64

If we use

%{_libdir} instead of %{_libexecdir}

rpmlint is not complaining

Also, I have chmod 644 shvar.py in cvs so that we can stripped the
related file in the spec file.

A patch to the spec file is attached, but appropriate Makefile should
be changed too.

-- 
http://clunixchit.blogspot.com

[Chitlesh GOORAH]

On 6/19/06, Chitlesh GOORAH <chitlesh(a)fedoraproject.org&gt; wrote:

>  A patch to the spec file is attached, but appropriate Makefile
> should
>  be changed too.
>  
Here it is.

-- 
http://clunixchit.blogspot.com

[J. Hartline]

Chitlesh GOORAH wrote:

>  Like this, we are falling on
>
>  W: kadischi non-standard-dir-in-usr libexec
>  Your package is creating a non-standard subdirectory in /usr. The 
>  standard
>  directories are:
>         -X11R6          -X386
>         -bin            -games
>         -include        -lib
>         -local          -sbin
>         -share          -src
>         -spool          -tmp
>         -lib64
>
>  If we use
>
>  %{_libdir} instead of %{_libexecdir}
>
>  rpmlint is not complaining 
It should.

/usr/lib is for shared objects and other libraries related to a 
particular application, not architecture dependant
binaries like we have now. We can also use %{_libexecdir} or 
%{_libexecdir}/bin NOT %{_libdir}

J. Hartline

[J. Hartline]

Chitlesh GOORAH wrote:

>  Like this, we are falling on
>
>  W: kadischi non-standard-dir-in-usr libexec
>  Your package is creating a non-standard subdirectory in /usr. The 
>  standard
>  directories are:
>         -X11R6          -X386
>         -bin            -games
>         -include        -lib
>         -local          -sbin
>         -share          -src
>         -spool          -tmp
>         -lib64
>
>  If we use
>
>  %{_libdir} instead of %{_libexecdir}
>
>  rpmlint is not complaining 
This is also a bug and should be filed, else libexec is strictly a 
Fedora Core feature.
The rpmlint complaint is saying libexec is a non standard directory in 
/usr. This needs to be
viewed in more detail. In any case %{_libexecdir}/kadischi or 
%{_libexecdir} seem fine.

J. Hartline

[Chitlesh GOORAH]

On 6/19/06, Jasper O'neal Hartline <jasperhartline(a)adelphia.net&gt; wrote:
>  This is also a bug and should be filed, else libexec is strictly a
>  Fedora Core feature.
>  The rpmlint complaint is saying libexec is a non standard directory in
>  /usr. This needs to be
>  viewed in more detail. In any case %{_libexecdir}/kadischi or
>  %{_libexecdir} seem fine. 

Has it already been filled or can I fill it now ?


-- 
http://clunixchit.blogspot.com

[J. Hartline]

Chitlesh GOORAH wrote:

>  Has it already been filled or can I fill it now ? 
I would file it as a bug or a feature request now, so that a 
distribution check can be made
e.g. If we're on Fedora Core, do not complain about /usr/libexec as 
Toshio cleared this up earlier.

J. Hartline

[Toshio Kuratomi]

On Mon, 2006-06-19 at 10:50 +0200, Chitlesh GOORAH wrote:
>  On 6/18/06, Toshio Kuratomi <a.badger(a)gmail.com&gt; wrote:
>  > +1 %{_libexecdir}.
>  >
>  > If this is done at the Makefile.am level then people who don't want
>  > kadischi installed in /usr/libexec can define LIBEXECDIR to /usr/sbin or
>  > %{_libdir}/kadischi at buildtime to place the files in a different
>  > location.
>  >
>  
>  Like this, we are falling on
>  
>  W: kadischi non-standard-dir-in-usr libexec
>  Your package is creating a non-standard subdirectory in /usr. The standard
>  directories are:
>          -X11R6          -X386
>          -bin            -games
>          -include        -lib
>          -local          -sbin
>          -share          -src
>          -spool          -tmp
>          -lib64
>  
>  If we use
>  
>  %{_libdir} instead of %{_libexecdir}
>  
>  rpmlint is not complaining 
Fedora and the BSDs makes use of libexecdir.  FHS and most other linux
distributions do not.  If you look at how gnome panel applets are
placed, you'll see that upstream installs them to libexecdir.  Fedora
follows this.  Debian sets libexecdir to /usr/lib and installs the
applets there.

It's safe to install to libexecdir on Fedora.

-Toshio

[Chitlesh GOORAH]

On 6/19/06, Toshio Kuratomi <toshio(a)tiki-lounge.com&gt; wrote:
>  Fedora and the BSDs makes use of libexecdir.  FHS and most other
> linux
>  distributions do not.  If you look at how gnome panel applets are
>  placed, you'll see that upstream installs them to libexecdir.  Fedora
>  follows this.  Debian sets libexecdir to /usr/lib and installs the
>  applets there.
>
>  It's safe to install to libexecdir on Fedora. 
Wow, it didnt know that
Thanks for the info Toshio :)

-- 
http://clunixchit.blogspot.com

[J. Hartline]

Toshio Kuratomi wrote:

> +1 %{_libexecdir}.
>
> If this is done at the Makefile.am level then people who don't want
> kadischi installed in /usr/libexec can define LIBEXECDIR to /usr/sbin or
> %{_libdir}/kadischi at buildtime to place the files in a different
> location.
>
>   
>  
Thanks Toshio.
The changes here were committed to CVS just yesterday.

J .Hartline