LNST-developers August 2014

lnst-developers@lists.fedorahosted.org

57 participants
83 discussions

[PATCH] active-backup bonding primary option fix
by Artem Savkov 08 Aug '14

08 Aug '14

Netdevice's id is alphanumeric, not just digits, so when calling get_mapped_device() this id shouldn't be converted to int. Otherwise a ValueError exception is raised: CommandException: CommandException: Slave bondmaster: invalid literal for int() with base 10: 'eth1' Signed-off-by: Artem Savkov <asavkov(a)redhat.com> --- lnst/Slave/NetConfigDevice.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lnst/Slave/NetConfigDevice.py b/lnst/Slave/NetConfigDevice.py index 4fa1b50..054d15a 100644 --- a/lnst/Slave/NetConfigDevice.py +++ b/lnst/Slave/NetConfigDevice.py @@ -103,7 +103,7 @@ class NetConfigDeviceBond(NetConfigDeviceGeneric): "primary" option is not direct value but it's index of netdevice. So take the appropriate name from config ''' - slave_dev = self._if_manager.get_mapped_device(int(value)) + slave_dev = self._if_manager.get_mapped_device(value) value = slave_dev.get_name() exec_cmd('echo "%s" > %s/%s' % (value, self._get_bond_dir(), -- 1.9.3

2 1

[lnst] active-backup bonding primary option fix
by Jiří Pírko 08 Aug '14

08 Aug '14

commit e6a5dd01ae7684ce5eb2e7e5265fc0f6cbb0ffdd Author: Artem Savkov <asavkov(a)redhat.com> Date: Fri Aug 8 13:01:01 2014 +0200 active-backup bonding primary option fix Netdevice's id is alphanumeric, not just digits, so when calling get_mapped_device() this id shouldn't be converted to int. Otherwise a ValueError exception is raised: CommandException: CommandException: Slave bondmaster: invalid literal for int() with base 10: 'eth1' Signed-off-by: Artem Savkov <asavkov(a)redhat.com> Signed-off-by: Jiri Pirko <jiri(a)resnulli.us> lnst/Slave/NetConfigDevice.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --- diff --git a/lnst/Slave/NetConfigDevice.py b/lnst/Slave/NetConfigDevice.py index 4fa1b50..054d15a 100644 --- a/lnst/Slave/NetConfigDevice.py +++ b/lnst/Slave/NetConfigDevice.py @@ -103,7 +103,7 @@ class NetConfigDeviceBond(NetConfigDeviceGeneric): "primary" option is not direct value but it's index of netdevice. So take the appropriate name from config ''' - slave_dev = self._if_manager.get_mapped_device(int(value)) + slave_dev = self._if_manager.get_mapped_device(value) value = slave_dev.get_name() exec_cmd('echo "%s" > %s/%s' % (value, self._get_bond_dir(),

1 0

test
by Ondrej Lichtner 08 Aug '14

08 Aug '14

test message, ignore

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

LNST-developers August 2014