12:51 p.m.
Hello everyone,
This set is a major NetTestController refactoring. Over the course of the
last year, we did a lot of conceptual changes to LNST and we took the path
of least resistance while adding them to the code. This however wasn't
working anymore, because the code was getting a bit bloated and hard to
follow. This is the first step of putting some order in it and other
will surely follow.
During this refactoring, I also changed the format of the XML recipe
based on the discussions we had. The changes are described with the
individual patch in the series.
What was left out from in this phase is the parser, which I consider
good enough for now. Ondra is working on the XML scheme for recipes so
it will be better to wait to see if we will be able to integrate the
scheme directly into parser in a reasonable way.
Other than that, I didn't focus all that much on error handling. I will
do some more tests of the corner cases and follow up with patches on
problems with that should any come up.
Please let me know, if I forgot something :).
Cheers,
-Radek
Radek Pazdera (14):
XmlProcessing: Renaming RecipeParser to LnstParser
SlaveMachineParse: Moving from NetTestParse
NetTestParse: Renaming to RecipeParse
lnst-ctl: More XML format changes
lnst-ctl: Refactoring logging initialisation
NetTestCommand: Adding get_type() method
NetTestCommandSystemConfig: Modifying result
Logs: Adding get_recipe_log_path()
Logs: Adding missing 'self'
NetTestSlave: Adding system config handling
lnst-slave: Fixing bug with packet capture
VirtDomainCtl: Adding TODO Comment
NetTestController: Major Refactoring
smoke-tests: Changing the XML format
lnst/Common/Logs.py | 26 +-
lnst/Common/NetTestCommand.py | 12 +-
lnst/Common/VirtUtils.py | 3 +-
lnst/Common/XmlProcessing.py | 28 +-
lnst/Common/XmlTemplates.py | 34 +-
lnst/Controller/Machine.py | 520 +++++++++++++++++++++++++++
lnst/Controller/NetTestController.py | 466 +++++--------------------
lnst/Controller/NetTestParse.py | 642 ----------------------------------
lnst/Controller/RecipeParse.py | 497 ++++++++++++++++++++++++++
lnst/Controller/SlaveMachineParse.py | 108 ++++++
lnst/Controller/SlavePool.py | 68 +++--
lnst/Slave/NetTestSlave.py | 32 ++-
recipes/smoke/lib/conf-bond.xml | 8 +-
recipes/smoke/lib/conf-eth.xml | 6 +-
recipes/smoke/lib/conf-team.xml | 8 +-
recipes/smoke/lib/conf-vlan.xml | 6 +-
recipes/smoke/lib/recipe-temp.xml | 6 +-
recipes/smoke/lib/req.xml | 14 -
18 files changed, 1360 insertions(+), 1124 deletions(-)
create mode 100644 lnst/Controller/Machine.py
delete mode 100644 lnst/Controller/NetTestParse.py
create mode 100644 lnst/Controller/RecipeParse.py
create mode 100644 lnst/Controller/SlaveMachineParse.py
delete mode 100644 recipes/smoke/lib/req.xml
--
1.7.7.6