On Thu, Apr 30, 2020 at 2:38 AM Jan Tluka <jtluka@redhat.com> wrote:
Wed, Apr 29, 2020 at 07:41:42PM CEST, aloughla@redhat.com wrote:
>From: Aniss Loughalm <aloughla@redhat.com>
>
>Signed-off-by: Aniss Loughalm <aloughla@redhat.com>

You have a typo in your surname. You need to fix this in your git configuration.
Fixed

>---
> lnst/Recipes/ENRT/BondRecipe.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/lnst/Recipes/ENRT/BondRecipe.py b/lnst/Recipes/ENRT/BondRecipe.py
>index 6ef40db..07d7cfc 100644
>--- a/lnst/Recipes/ENRT/BondRecipe.py
>+++ b/lnst/Recipes/ENRT/BondRecipe.py
>@@ -111,3 +111,7 @@ class BondRecipe(CommonHWSubConfigMixin, OffloadSubConfigMixin,
>     def parallel_stream_qdisc_hw_config_dev_list(self):
>         return [self.matched.host1.eth0, self.matched.host1.eth1,
>             self.matched.host2.eth0]
>+
>+     @property
>+     def no_pause_frames_dev_list(self):
>+         return [self.matched.host1.eth0, self.matched.host1.eth1, self.matched.host2.eth0]

Please keep lines shorter than 80 characters if possible.
Got it,

In this case you can simply copy the device list format from the property
above.

Thinking about this further. I think we should add this property to
other tests, too.

-Jan
Thank you,
Aniss

>--
>2.24.1
>_______________________________________________
>LNST-developers mailing list -- lnst-developers@lists.fedorahosted.org
>To unsubscribe send an email to lnst-developers-leave@lists.fedorahosted.org
>Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>List Archives: https://lists.fedorahosted.org/archives/list/lnst-developers@lists.fedorahosted.org