----- Original Message -----
From: "Ondrej Lichtner" <olichtne(a)redhat.com>
To: csfakian(a)redhat.com
Cc: lnst-developers(a)lists.fedorahosted.org
Sent: Monday, July 22, 2019 4:03:08 PM
Subject: Re: [PATCH-next 8/8] lnst.Recipes.ENRT: rework recipes to adopt to
334e2c..7bde5c
On Fri, Jul 19, 2019 at 01:36:51PM +0200, csfakian(a)redhat.com wrote:
> From: Christos Sfakianakis <csfakian(a)redhat.com>
>
> Rewrite recipes to be compatible with the above patches.
>
> Signed-off-by: Christos Sfakianakis <csfakian(a)redhat.com>
> ---
> lnst/Recipes/ENRT/BondRecipe.py | 137 +++++---
> lnst/Recipes/ENRT/DoubleBondRecipe.py | 140 +++++---
> lnst/Recipes/ENRT/DoubleTeamRecipe.py | 159 ++++++----
> lnst/Recipes/ENRT/IpsecEspAeadRecipe.py | 280 ++++++++--------
> lnst/Recipes/ENRT/IpsecEspAhCompRecipe.py | 297 ++++++++---------
> lnst/Recipes/ENRT/NoVirtOvsVxlanRecipe.py | 130 +++++---
> lnst/Recipes/ENRT/PingFloodRecipe.py | 21 +-
> .../ENRT/ShortLivedConnectionsRecipe.py | 87 ++---
> lnst/Recipes/ENRT/SimpleMacsecRecipe.py | 252 +++++++--------
> lnst/Recipes/ENRT/SimplePerfRecipe.py | 42 +--
> lnst/Recipes/ENRT/TeamRecipe.py | 134 +++++---
> lnst/Recipes/ENRT/TeamVsBondRecipe.py | 162 ++++++----
> lnst/Recipes/ENRT/VirtOvsVxlanRecipe.py | 230 +++++++++++---
> .../VirtualBridgeVlanInGuestMirroredRecipe.py | 191 ++++++-----
> .../ENRT/VirtualBridgeVlanInGuestRecipe.py | 167 ++++++----
> .../VirtualBridgeVlanInHostMirroredRecipe.py | 178 +++++++----
> .../ENRT/VirtualBridgeVlanInHostRecipe.py | 155 ++++++---
> .../ENRT/VirtualBridgeVlansOverBondRecipe.py | 298 +++++++++++++-----
> ...rtualOvsBridgeVlanInGuestMirroredRecipe.py | 193 +++++++-----
> .../ENRT/VirtualOvsBridgeVlanInGuestRecipe.py | 164 ++++++----
> ...irtualOvsBridgeVlanInHostMirroredRecipe.py | 155 +++++----
> .../ENRT/VirtualOvsBridgeVlanInHostRecipe.py | 144 ++++++---
> .../VirtualOvsBridgeVlansOverBondRecipe.py | 277 ++++++++++------
> lnst/Recipes/ENRT/VlansOverBondRecipe.py | 267 +++++++++++-----
> lnst/Recipes/ENRT/VlansOverTeamRecipe.py | 269 +++++++++++-----
> lnst/Recipes/ENRT/VlansRecipe.py | 230 ++++++++++----
> lnst/Recipes/ENRT/VxlanMulticastRecipe.py | 155 ++++++---
> lnst/Recipes/ENRT/VxlanRemoteRecipe.py | 115 +++++--
> 28 files changed, 3193 insertions(+), 1836 deletions(-)
>
I only checked SimplePerfRecipe as that's the one I'm currently
interested in getting production ready and I disagree with removing the
ping endpoints.
I don't think we need to keep compatibility with the old simple_netperf
recipe anymore and we can implement the test in a way that makes sense
"now".
Sounds good, I will keep the ping tests as part of this recipe.
Maybe we should consider renaming the recipe class to just
"SimpleNetworkRecipe" or something that just reflects the fact that
there's only 2 eth nics that are being tested without any special
configuration?
Sounds reasonable to me, will do so unless Jan has a different preference
for the name.
> -Ondrej
>