Re: [PATCH 11/15] Task: add HostAPI methods

[Jiri Pirko]

Tue, Jul 12, 2016 at 11:00:32AM CEST, jprochaz(a)redhat.com wrote:
> Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com&gt;
> ---
>  lnst/Controller/Task.py | 35 ++++++++++++++++++++++++++++++++++-
>  1 file changed, 34 insertions(+), 1 deletion(-)
>
> diff --git a/lnst/Controller/Task.py b/lnst/Controller/Task.py
> index 6645acc..e36b79f 100644
> --- a/lnst/Controller/Task.py
> +++ b/lnst/Controller/Task.py
> @@ -279,9 +279,39 @@ class HostAPI(object):
>              if interface.get_id() is None:
>                  continue
>              self._ifaces[interface.get_id()] = InterfaceAPI(interface, self)
> -
> +        self._if_id_seq = 0
>          self._bg_id_seq = 0
>  
> +    def _gen_if_id(self):
> +        self._if_id_seq += 1
> +        return "if_id_%s" % self._if_id_seq
> +
> +    def init_host(self, host):
> +        self._m = host
> +        self.init_ifaces()
> +
> +    def init_ifaces(self):
> +        for interface in self._m.get_interfaces():
> +            if interface.get_id() is None:
> +                continue
> +            self._ifaces[interface.get_id()].init_iface(interface)
> +
> +    def add_interface(self, label, netns=None, params=None): 

"if", "iface", "interface"... Consistency please.


Also, does not look bisectable :)


>+        m_id = self.get_id()
>+        if_id = self._gen_if_id()
>+
>+        self._ctl.mreq[m_id]['interfaces'][if_id] = {}
>+        self._ctl.mreq[m_id]['interfaces'][if_id]['network'] = label
>+        self._ctl.mreq[m_id]['interfaces'][if_id]['netns'] = netns
>+
>+        if params:
>+            self._ctl.mreq[m_id]['interfaces'][if_id]['params'] =
params
>+        else:
>+            self._ctl.mreq[m_id]['interfaces'][if_id]['params'] = {}
>+
>+        self._ifaces[if_id] = InterfaceAPI(None, self)
>+        return self._ifaces[if_id]
>+
>     def get_id(self):
>         return self._m.get_id()
> 
>@@ -621,6 +651,9 @@ class InterfaceAPI(object):
>         self._if = interface
>         self._host = host
> 
>+    def init_iface(self, interface):
>+        self._if = interface
>+
>     def get_id(self):
>         return self._if.get_id()
> 
>-- 
>2.4.11
>_______________________________________________
>LNST-developers mailing list
&gt;lnst-developers(a)lists.fedorahosted.org
>https://lists.fedorahosted.org/admin/lists/[e-mail]