Tue, Jun 11, 2019 at 11:33:08AM CEST, olichtne(a)redhat.com wrote:
From: Ondrej Lichtner <olichtne(a)redhat.com>
This patchset deals with the refactoring of the ENRT recipes, for now
this specifically means the BaseEnrtRecipe and the SimplePerfRecipe.
The refactor utilizes Pythons' collaborative inheritance to enable
highly flexible way of extending the basic functionality of the recipe
with additional configuration parameters and implementation.
Yesterday I spent about an hour explaining this to my colleagues at RH
through a bluejeans call, I'm sharing the recording here in case anyone
else is also interested: https://bluejeans.com/s/gAZXd
The patchset probably breaks some minor functionality of all the other
recipes that we currently have in the ENRT package, but I expect that in
general they could actually still work reasonably well, or need just
small changes to get working again.
As this is a proposal I didn't want to waste time with reworking the
other recipes as well, if we accept this, updating them should be the
next patchset after this one.
I went through the patchset and there are no big issues with it. If
you'd like it to push it as it is I have no problem with that. We can
fix the minor issues later on.
I really like the design!
Nice job, Ondrej!
Acked-by: Jan Tluka <jtluka(a)redhat.com>