On Wed, Oct 14, 2020 at 11:26:29AM +0200, Jan Tluka wrote:
Tue, Oct 13, 2020 at 10:27:08AM CEST, olichtne(a)redhat.com wrote:
>On Mon, Oct 12, 2020 at 07:15:13PM +0200, Jan Tluka wrote:
>> + def apply_perf_test_tweak(self, perf_config):
>> + super().apply_perf_test_tweak(perf_config)
>> + if self.params.disable_turboboost:
>> + tweak_config = perf_config.perf_test_tweak_config
>> + tweak_config['turboboost'] = {}
>> +
>> + flow_measurement =
self._get_flow_measurement_from_config(perf_config)
>> + flow = flow_measurement.conf[0]
>> + for host in [flow.generator, flow.receiver]:
>
>Same comment as for previous patch - how should this be handled for
>Virtual recipes?
>
>maybe a "disable_turboboost_host_list" property could work for these
>cases?
>
Generally it is a good idea, I'm just wondering what the user should
pass as the argument value.
I guess they should be strings matching hosts in self.matched.*.
So for example in case of VirtualBridgeVlansOverBondRecipe, which
defines:
host1 = HostReq()
...
host2 = HostReq()
this could be:
disable_turboboost_host_list=['host1, host2']
Or is there a better way how to deal with this? I believe there's no
other test machine representation than that.
Why not the objects from the self.matched.* directly? e.g.:
@property
def disable_turboboost_host_list(self):
return [self.matched.m1, self.matched.m2, ...]
These are the same object references as flow.generator, but self.matched
contains all of them, and the property can select the relevant ones.
-Ondrej