Thu, Nov 12, 2015 at 02:47:16PM CET, jtluka(a)redhat.com wrote:
Thu, Nov 12, 2015 at 12:19:53PM CET, olichtne(a)redhat.com wrote:
>On Wed, Nov 11, 2015 at 02:55:11PM +0100, Jiri Prochazka wrote:
>> This patch adds support for measuring both local and remote CPU utilization:
>> New option for netperf client have been added:
>> cpu_util - when set to "local", netperf is run with -c argument,
enabling measure of local CPU utilization during run,
>> when set to "remote", netperf is run with -C argument,
enabling measure of remote CPU utilization during run,
>> when set to "both", netperf is run with both -c and -C
arguments
>>
>> Parsing of throughput and confidence interval has been made cleaner:
>> Using omni netperf output, all relevant data are now stored in key=val
format,
>> which can be parsed more easily and is the same for all netperf test types.
>>
>> Changes in v2:
>> Changed format of cpu_util argument (described above)
>>
>> Renamed keys in res_val dict to from loc_cpu_util and rem_cpu util
>> to LOCAL_CPU_UTIL and REMOTE_CPU_UTIL
>>
>> Fixed incorrect real confidence value, now the touple correctly
>> returns (CONFIDENCE_LEVEL, THROUGHPUT_CONFIDENCE_INTERVAL/2)
>>
>> Changes in v3:
>> Removed redundant error value parsing from _parse_confidence method
>>
>> Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com>
>
>Looks good, after jtlukas tests finish and there's no new problems i'll
>ack and push it.
Tests are ok. I've checked whether confidence is same with old and new
approach and it's the same.
Acked-by: Jan Tluka <jtluka(a)redhat.com>
I've noticed that the UDP_STREAM performance dropped after this change.
First I thought it is because of cpu utilization data collection but
disabling this did not help.
Very likely this is because of OMNI output. I've looked in the netperf
code and there are few other "THROUGHPUT" values:
src/nettest_omni.c:
LOCAL_SEND_THROUGHPUT,
LOCAL_RECV_THROUGHPUT,
REMOTE_SEND_THROUGHPUT,
REMOTE_RECV_THROUGHPUT,
I'm wondering if the previous value that we reported is some of these.