Re: [PATCH 5/5] Recipe.py: Removed Recipe name property.

[Jan Tluka]

Wed, Oct 14, 2020 at 04:17:20PM CEST, pgagne(a)redhat.com wrote:
> From: Perry Gagne <pgagne(a)redhat.com&gt;
>
> After feedback from the team, we decided not to have this.
>  
So why not to merge this into one of the previous commits in the patch
set that added this?

-Jan

> Signed-off-by: Perry Gagne <pgagne(a)redhat.com&gt;
> ---
>  lnst/Controller/Recipe.py | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/lnst/Controller/Recipe.py b/lnst/Controller/Recipe.py
> index eb9b344..9617495 100644
> --- a/lnst/Controller/Recipe.py
> +++ b/lnst/Controller/Recipe.py
> @@ -130,9 +130,6 @@ class BaseRecipe(object):
>      def _set_ctl(self, ctl):
>          self._ctl = ctl
>  
> -    @property
> -    def name(self):
> -        return self.__class__.__name__
>  
>      @property
>      def matched(self):
> @@ -254,14 +251,14 @@ def export_recipe_run(run: RecipeRun, export_dir: str = None, name:
> str = None)
>  
>      """
>      if not name:
> -        name = f"{run.recipe.name}-run-{run.datetime:%Y-%m-%d_%H:%M:%S}.lrc"
> +        name =
> f"{run.recipe.__class__.__name__}-run-{run.datetime:%Y-%m-%d_%H:%M:%S}.lrc"
>      if not export_dir:
>          export_dir = run.log_dir
>  
>      path = os.path.join(export_dir, name)
>      with lzma.open(path, 'wb') as f:
>          pickle.dump(run, f)
> -    logging.info(f"Exported {run.recipe.name} run to {path}")
> +    logging.info(f"Exported {run.recipe.__class__.__name__} run to {path}")
>      return path
>  
>  
> -- 
> 2.26.2
> _______________________________________________
> LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
> To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...