Re: [PATCH 1/4] InterfaceManager: fix iteration over tmp_mapping

[Jiri Pirko]

all applied, thanks!


Mon, Nov 03, 2014 at 02:29:33PM CET, olichtne(a)redhat.com wrote:
> From: Ondrej Lichtner <olichtne(a)redhat.com&gt;
>
> This patch fixes "Too many values to unpack" exceptions that sometimes
> occur and leave lnst-slave in an unresponsive state.
>
> Signed-off-by: Ondrej Lichtner <olichtne(a)redhat.com&gt;
> ---
>  lnst/Slave/InterfaceManager.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lnst/Slave/InterfaceManager.py b/lnst/Slave/InterfaceManager.py
> index 68866b8..489c697 100644
> --- a/lnst/Slave/InterfaceManager.py
> +++ b/lnst/Slave/InterfaceManager.py
> @@ -133,7 +133,7 @@ class InterfaceManager(object):
>          ret = {}
>          for if_id, if_index in self._id_mapping.iteritems():
>              ret[if_id] = self._devices[if_index]
> -        for if_id, dev in self._tmp_mapping:
> +        for if_id in self._tmp_mapping:
>              ret[if_id] = self._tmp_mapping[if_id]
>          return ret
>  
> -- 
> 1.9.3
>
> _______________________________________________
> LNST-developers mailing list
> LNST-developers(a)lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/lnst-developers