On Mon, May 18, 2020 at 04:16:21PM -0400, pgagne@redhat.com wrote:
From: Perry Gagne pgagne@redhat.com
redefined the perf_reverse parameter.
Added mixin for recipes that which to be able to run their flows in reverse.
Signed-off-by: Perry Gagne pgagne@redhat.com
Looks fine, just a generic comment to the commit message - we usually like to add some information about the location of the changes into the header of the commit message, e.g. "ENRT.Recipes:" so we can see the context at a glance.
Similarly a more detailed explanation of the changes would also be useful, in this case the changes are documented with docstrings so it's not a big deal, but again... being able to understand the changes, and the motivation behind those changes, from just the commit description can be often very helpful.
Anyway, pushed to github master.
-Ondrej