Fri, May 26, 2017 at 03:33:41PM CEST, olichtne(a)redhat.com wrote:
On Tue, May 23, 2017 at 04:52:55PM +0200, Jiri Pirko wrote:
> Fri, May 19, 2017 at 12:12:45PM CEST, olichtne(a)redhat.com wrote:
> >From: Ondrej Lichtner <olichtne(a)redhat.com>
> >
> >v2 changes:
> > add lnst.Common.IpAddress
> > * modify exception string.
> > add lnst.Common.Parameters
> > * add docstring explaining the __getattribute__ magic
> > * make val a property
> > * rename x to attr in Parameters dir() iterations
> > * fix IpParam value setter for string values
> > * modify IpParam Exception string
> > add lnst.Devices
> > * make Device a Meta class and register RemoteDevice as implementing
> > the Device interface
> > * removed unnecessary imports
> > * added MasterDevice class for slave* methods
> > * made master_set to be a 'master' property setter
> > * renamed {add, del}_route to route_{add, del}
> > * renamed set_speed to speed_set
> > * renamed set_autoneg to autoneg_set
> > * removed modprobes where unnecessary
> > * link_stats are now retrieved from netlink message
> > * added link_stats64
> > * OvsBridge calls parent _type_init for modprobe
> > * remove SoftDevice import - not required
> > add lnst.Controller.Host
> > * removed debug pprint import
> > * added docstrings to requested methods
> > * Host::run throws an exception when netns set (not supported yet)
> > * added TODO comments to some parts that need to be implemented
> > add lnst.Controller.MachineMapper
> > * docstring now explains that implementing your own MachineMapper is
> > not supported at this moment
> > * removed debug pprint import
> > add lnst.Controller.Recipe
> > * renamed variable 'x' to 'attr'
> > Machine, NetTestSlave: heavy reimplementation
> > * improved class and module synchronization implementation
> > * join split lines in deviceref_to_device method
> > lnst.Common.Parameters: IpParam accepts Device objects
> > * import Device on demand (Device class arrives on Slave later) and
> > check isinstance Device instead of RemoteDevice (not available on
> > Slave)
> > * fix IpParam Exception string
> >
> >v2 new commits:
> > Controller, Devices: removing unused imports
> > NetTestSlave: create dynamic lnst.Tests package
> > lnst.Tests: add package docstring
> > lnst.Common.Parameters: add DeviceParam
> > lnst.Tests.IcmpPing: use DeviceParam for iface parameter
> >
>
> Looks good on a quick look. Lets apply this and continue in-tree.
Sorry this took a while, I was busy with certification training this
week, Pushed to the origin/next branch. I also removed the
origin/next_devel branch.
Next on the agenda is to schedule a meeting where we'll discuss the
Device API so that we can settle on something that will not change
anymore. I also have an idea for Host API that I'd like to discuss.
Next week mostly works for me, I'd prefer later than sooner (I have to
do some catchup in school)... What works for you and/or other members of
the mailing list?
Works for me any time this week, please schedule.