On Mon, Jun 03, 2019 at 02:00:32PM +0200, Jan Tluka wrote:
Fri, May 31, 2019 at 11:27:51AM CEST, olichtne(a)redhat.com wrote:
>From: Ondrej Lichtner <olichtne(a)redhat.com>
>
>Hi all,
>
>this patch series starts my effort to improve the logs as provided to
>the tester. This patchset is centered at removing the need of the tester
>to use debug=1 logging and still know what's happening wrt. the recipe
>he's trying to run.
>
>This means a significant reduction of logs on the Controller side which
>in my personal opinion improves usability quite a bit.
>
>Next I want to focus on improving the BaseEnrtRecipe hierarchy and
>include capabilities that provide some additional context as to what
>stage the test execution is at.
>
>-Ondrej
>
>Ondrej Lichtner (15):
> lnst.Common.ExecCmd: fix cmd not being part of the exception
> description
> add __repr__ and __str__ implementations of several objects
> lnst.Controller.RecipeResults: remove useless property redefines
> lnst.Controller.RecipeResults: add success setter
> lnst.Controller.Machine: ensure Job{Start, Finish}Result ordering
> lnst.Devices.RemoteDevice: add _id property
> lnst.Controller.RecipeResults: add DeviceConfigResult.* classes
> lnst.Controller.Machine: add stop_recipe
> lnst.Controller.RunSummaryFormatter: change default source string
> lnst.Controller.Job: add a 'type' property
> lnst.Controller.Job: __str__ method format of _what description
> lnst.Controller.Machine: add device manipulation methods
> lnst.RecipeCommon.Perf: add flow information to string reports
> adjust logging levels
> lnst.Controller.Recipe: log results as they're added
>
> lnst/Common/ExecCmd.py | 3 +-
> lnst/Common/IpAddress.py | 3 +
> lnst/Controller/Controller.py | 1 +
> lnst/Controller/Host.py | 1 +
> lnst/Controller/Job.py | 35 ++---
> lnst/Controller/Machine.py | 74 ++++++++--
> lnst/Controller/Namespace.py | 10 +-
> lnst/Controller/Recipe.py | 15 ++
> lnst/Controller/RecipeResults.py | 134 ++++++++++++++++--
> lnst/Controller/RunSummaryFormatter.py | 6 +-
> lnst/Devices/RemoteDevice.py | 41 ++++--
> .../BaselineFlowAverageEvaluator.py | 3 +-
> .../Perf/Evaluators/NonzeroFlowEvaluator.py | 5 +-
> .../Perf/Measurements/BaseFlowMeasurement.py | 28 ++++
> .../Perf/Measurements/BaseMeasurement.py | 6 +
> .../Perf/Measurements/StatCPUMeasurement.py | 9 +-
> lnst/Recipes/ENRT/BaseEnrtRecipe.py | 22 ++-
> lnst/Slave/Job.py | 2 +-
> lnst/Tests/BaseTestModule.py | 12 ++
> 19 files changed, 348 insertions(+), 62 deletions(-)
>
>--
>2.21.0
>_______________________________________________
>LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
>To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
>Fedora Code of Conduct:
https://getfedora.org/code-of-conduct.html
>List Guidelines:
https://fedoraproject.org/wiki/Mailing_list_guidelines
>List Archives:
https://lists.fedorahosted.org/archives/list/lnst-developers@lists.fedora...
Besides my comments to 12/15 and 13/15, looks good.
Acked-by: Jan Tluka <jtluka(a)redhat.com>
-Jan
I fixed the 13/15 issue on my side, don't think there's a reason to send
a v2 just for a colon change.
Pushing to the next branch.
-Ondrej