Fri, May 31, 2013 at 01:42:11PM CEST, olichtne(a)redhat.com wrote:
On Fri, May 31, 2013 at 01:28:43PM +0200, Jiri Pirko wrote:
> Wed, May 29, 2013 at 03:45:06PM CEST, olichtne(a)redhat.com wrote:
> >Hi everyone,
> >
> >I've started working on changing the format of our recipe results. The
> >current format is not sufficient as it only reports the cumulative
> >result of the entire recipe. When the recipe contains several command
> >sequences the cumulative result is not very helpful, also when a single
> >command fails it would be nice to know which one it was without blindly
> >searching all the logs produced.
> >
> >With this in mind I have the first draft of how I would like the result
> >output look like. I'm attaching an example file to this email.
> >
> >The new format gives you information about every command launched, and
> >show where command sequences start. I decided it wouldn't be very clean
> >if too much information was given so I'm limiting the output to only
> >show the type and value of the comand. Additionally it displays the
> >background id of a command if it has one (so that we can match the
> >corresponding wait/intr/kill command).
> >
> >In case the command failed an error message is printed on the next line.
> >This relies on the fact that the command will return a result dictionary
> >that contains a field named 'err_msg'.
> >
> >I haven't decided how to print 'system_config' commands yet but I
have a
> >basic idea. If anyone has any ideas on what they would like to see for
> >system_configs I will be pleased to hear them.
> >
> >Let me know what you think about this format, and if you have any ideas
> >for improvement, please share. The most important part is if I'm not
> >missing any important parts of commands. It is a summary so I don't want
> >to print everything (that can be seen in the xml output of option -x).
> >
> >Thank you for your answers.
>
>
> I like this very much. Step in the right direction. Btw how about
> alternate xml output?
xml output should still be supported by running lnst-ctl with argument
-x file_name. It should contain the same data as the summary, plus
whatever is recieved as result_data, in xml format. There is a bug in
there that it will create an invalid xml for system_config options (tags
name beginning with '/'), which I plan to fix.
Great.
Or do you mean something different by xml output?
Nope :)
>
> >-Ondrej
>
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: ================================
SUMMARY ================================
> >2013-05-29 14:34:30| (127.0.0.1)| INFO:
recipes/smoke/tests/recipe-bond-bond.xml PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 1
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: test IcmpPing
bg_id: 1 PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: ctl_wait 5
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: intr 1
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 2
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: exec [ `ip -o
link | grep t_bond0 | wc -l` -gt 0 ] PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 3
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: test IcmpPing
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 4
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: system_config None
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO:
recipes/smoke/tests/recipe-bond-eth.xml PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 1
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: test IcmpPing
bg_id: 1 PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: ctl_wait 5
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: intr 1
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 2
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: exec [ `ip -o
link | grep t_bond0 | wc -l` -gt 0 ] PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 3
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: test IcmpPing
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 4
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: system_config None
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO:
recipes/smoke/tests/recipe-bond-team.xml PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 1
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: test IcmpPing
bg_id: 1 PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: ctl_wait 5
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: intr 1
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 2
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: exec [ `ip -o
link | grep t_bond0 | wc -l` -gt 0 ] PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 3
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: test IcmpPing
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 4
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: system_config None
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO:
recipes/smoke/tests/recipe-bond-vlan.xml FAIL
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 1
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: test IcmpPing
bg_id: 1 PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: ctl_wait 5
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: intr 1
FAIL
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: error message: rate
is lower that limit
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 2
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: exec [ `ip -o
link | grep t_bond0 | wc -l` -gt 0 ] PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 3
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: test IcmpPing
FAIL
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: error message: rate
is lower that limit
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: cmd_seq: 4
> >2013-05-29 14:34:30| (127.0.0.1)| INFO: system_config None
PASS
> >2013-05-29 14:34:30| (127.0.0.1)| INFO:
=========================================================================
>
> >_______________________________________________
> >LNST-developers mailing list
> >LNST-developers(a)lists.fedorahosted.org
> >https://lists.fedorahosted.org/mailman/listinfo/lnst-developers
>