Re: [PATCH 0/6] add OvSDPDKBondRecipe

[Ondrej Lichtner]

On Mon, Dec 14, 2020 at 11:59:25AM +0100, jurbanov(a)redhat.com wrote:
>  From: Jozef Urbanovsky <jurbanov(a)redhat.com&gt;
>  
>  Hi,
>  
>  This patchset adds OvSDPDKBondRecipe and fixes some 
>  issues with test tools required for the recipe. 
>  Patchset has been reviewed in internal downstream, 
>  before it was decided to split it to upstream and downstream.
>  
>  It has been tested to be fully functional.
>  
>  Jozef Urbanovsky (6):
>    lnst.Recipes.ENRT.OvSDPDKBondRecipe: add new recipe
>    lnst.Tests.TestPMD: add mode branching
>    lnst.Tests.TRex: add __repr__ methods, expose module parameter
>    lnst.RecipeCommon.Perf.Measurements.TRexFlowMeasurement: fixes
>    requirements: add dataclasses package
>    lnst.Recipes.ENRT.OvSDPDKBondRecipe: override *test_tweak methods
>  
>   .../Perf/Measurements/TRexFlowMeasurement.py  |   5 +-
>   lnst/Recipes/ENRT/OvSDPDKBondRecipe.py        | 257 ++++++++++++++++++
>   lnst/Recipes/ENRT/__init__.py                 |   1 +
>   lnst/Tests/TRex.py                            |  27 ++
>   lnst/Tests/TestPMD.py                         |  36 ++-
>   requirements.txt                              |   1 +
>   6 files changed, 315 insertions(+), 12 deletions(-)
>   create mode 100644 lnst/Recipes/ENRT/OvSDPDKBondRecipe.py
>  
>  -- 
>  2.28.0
>  _______________________________________________
>  LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
>  To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...
Other than my one comment about the extra character, I think the
patchset looks sane, please fix the minor cosmetic issues as pointed out
by Jan and the one extra character and I'll push this to master.

-Ondrej