Re: [PATCH 1/3] Config: add info about version in config
On Mon, May 30, 2016 at 04:30:36PM +0200, Jan Tluka wrote:
Sun, May 29, 2016 at 11:03:09AM CEST, jprochaz(a)redhat.com wrote:
>This patch is first from series which implements version control in LNST.
>
>The are two types of versions - LNST Major Version and git HEAD commit
>hash. LNST Major Version is used when LNST is installed and run from
>RPM and git commit hash is used when LNST is run from devel git repo.
>
>LNSTMajorVersion variable in Config.py will have to be manully
>incremented each time new release is made.
I somehow missed this and I don't like this. It's addition of garbage commit
everytime we need to do a release.
Since we release rpm only can't we rely on function of rpm? For example,
# rpm -qa --queryformat '%{VERSION}' lnst-ctl
11
-Jan
Well... we already do this "garbage" commit since the version needs to
be updated in the setup.py script... I don't see a problem with both
variables being updated in this commit... or maybe we could only have
just one variable that is used for both the setup.py and the version
comparison with slave?
-Ondrej
> _______________________________________________
> LNST-developers mailing list
> lnst-developers(a)lists.fedorahosted.org
> https://lists.fedorahosted.org/admin/lists/lnst-developers@lists.fedoraho...