Re: [PATCH-next v3 0/5] Remaining phase 3 port

[Ondrej Lichtner]

On Tue, May 28, 2019 at 06:34:43PM +0200, csfakian(a)redhat.com wrote:
>  From: Christos Sfakianakis <csfakian(a)redhat.com&gt;
>  
>  Hi,
>  
>  this is v3 of the patch set. The changes with respect to v2 are:
>      - lnst.Controller.Namespace: Indentation change of the 'else' clause in
>        '__delattr__' in order to avoid no-actions when the attribute to be
>        deleted does not satisfy the first 'if' condition.
>      - Rewording of commit 2 (of 5)
>  
>  Christos
>  
>  Previous messages:
>  
>  Hi,
>  
>  this is v2 of the patch set. Changes include:
>      - lnst.Controller.Namespace: add a method to catch attribute
>        deletion
>      - lnst.Recipes.ENRT.BaseENRTRecipe: change 'perf_msg_size' type to
>        list and update previously ported recipes that relied on it
>      - lnst.Devices.MacsecDevice: remove unused '*args' from intiator
>      - drop the commits relating to lnst.Controller.Host and
>        lnst.RecipeCommon.Perf.Measurements.BaseFlowMeasurement
>      - lnst.Recipes.ENRT.ShortLivedConnectionsRecipe: remove
>        'generate_flow_combinations' method after 'perf_msg_sizes'
>        enablement. Removed 'vlan' from comment. Move
>        'genarate_ping_configurations' method to the bottom
>      - lnst.Recipes.ENRT.SimpleMacsecRecipe: reorder methods for
>        readability, remove 'cond', destroy and delete the macsec devices
>        manually, check encryption against None value explicitly in
> 'generate_sub_config'
>  
>  Christos
>  
>  Previous message:
>  
>  Hi,
>  
>  this patch includes ports for simple_macsec and short_lived_connections
>  of phase 3. Note that, due to current issue with iperf, ShortLivedConnectionsRecipe
>  cannot be tested yet. In terms of SimpleMacsecRecipe, ip commands were
>  chosen for the creation of the devices, as pyroute2 seems to have issue
>  handling IFLA_MACSEC_ENCRYPT.
>  
>  Christos
>  
>  Christos Sfakianakis (5):
>    lnst.Controller.Namespace: add __delattr__
>    lnst.Recipes.ENRT.BaseEnrtRecipe: change 'perf_msg_size' name and type
>    lnst.Devices: add MacsecDevice
>    lnst.Recipes.ENRT: add ShortLivedConnectionsRecipe
>    lnst.Recipes.ENRT: add SimpleMacsecRecipe
>  
>   lnst/Controller/Namespace.py                  |   7 +
>   lnst/Devices/MacsecDevice.py                  |  64 +++++
>   lnst/Devices/__init__.py                      |   4 +-
>   lnst/Recipes/ENRT/BaseEnrtRecipe.py           |  37 +--
>   lnst/Recipes/ENRT/IpsecEspAeadRecipe.py       |  33 +--
>   lnst/Recipes/ENRT/IpsecEspAhCompRecipe.py     |  33 +--
>   .../ENRT/ShortLivedConnectionsRecipe.py       |  67 +++++
>   lnst/Recipes/ENRT/SimpleMacsecRecipe.py       | 271 ++++++++++++++++++
>   8 files changed, 465 insertions(+), 51 deletions(-)
>   create mode 100644 lnst/Devices/MacsecDevice.py
>   create mode 100644 lnst/Recipes/ENRT/ShortLivedConnectionsRecipe.py
>   create mode 100644 lnst/Recipes/ENRT/SimpleMacsecRecipe.py
>  
>  -- 
>  2.17.1
>  _______________________________________________
>  LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
>  To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
>  Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...
Looks good to me.

Pushed, thanks.

-Ondrej