Re: [PATCH 1/3] Utils: Add LNST version variable and set it to 8.0

[Jiri Prochazka]

​Best regards,​

Jiri Prochazka
LNST Developer
​| www.lnst-project.org​

[phone] | jprochaz(a)redhat.com
Red Hat Czech | Purkyňova 71/99, 612 00 Brno

2015-09-09 10:39 GMT+02:00 Jiri Pirko <jiri(a)resnulli.us&gt;:

>  Tue, Sep 08, 2015 at 04:20:35PM CEST, jprochaz(a)redhat.com wrote:
>  >This patch introduces new style of versioning of LNST.
>  >
>  >We will now use Major+minor style of versions, where major versions
>  >are based on major releases of our RPM packages and minor versions
>  >are only distinguished in devel GIT versions.
>  >
>  >The version starts on 8.0
>  >
>  >Each time a change is introduced, which may cause invalid behaviour
>  >when used with older version, developer should also increment minor
>  >version in this variable.
>  >
>  >Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com&gt;
>
>
>  NACK! I would like to at least discuss this first.
>  Now, this does not make any sense to me.
>
>  ​We discussed it on thread "issue #136 RFC"​ 
>  >---
>  > lnst/Common/Utils.py | 2 ++
>  > 1 file changed, 2 insertions(+)
>  >
>  >diff --git a/lnst/Common/Utils.py b/lnst/Common/Utils.py
>  >index cb2272d..ea80a02 100644
>  >--- a/lnst/Common/Utils.py
>  >+++ b/lnst/Common/Utils.py
>  >@@ -24,6 +24,8 @@ import math
>  > from _ast import Call, Attribute
>  > from lnst.Common.ExecCmd import exec_cmd
>  >
>  >+LNST_VERSION = 8.0
>  >+
>  > def die_when_parent_die():
>  >     try:
>  >         import ctypes
>  >--
>  >2.4.3
>  >
>  >_______________________________________________
>  >LNST-developers mailing list
>  &gt;LNST-developers(a)lists.fedorahosted.org
>  >https://lists.fedorahosted.org/mailman/listinfo/lnst-developers
>