2017-04-20 18:56 GMT+02:00 Jan Tluka <jtluka(a)redhat.com>:
Thu, Apr 20, 2017 at 06:43:02PM CEST, jtluka(a)redhat.com wrote:
>Thu, Apr 20, 2017 at 05:21:46PM CEST, jprochaz(a)redhat.com wrote:
>>This method had two uses. When no param unit was specified it converted
>>the rate to highest pretty unit. When param unit was specified, it
>>converted deviation rate to the same unit as the rate.
>>
>>This patch splits these methods in two
>
>Why do you need to split it? My guess is that it's related to previous
>patch and expectation that you'll have bit/s units by default.
>
>-Jan
If it was not obvious I'd like to keep just one method for this.
-Jan
IMHO having only one method, the way it is now, it's not very clear
what does it do as it does two separate things under same name.