Wed, Jul 20, 2016 at 10:45:31AM CEST, olichtne(a)redhat.com wrote:
On Tue, Jul 19, 2016 at 11:11:12AM +0200, Jiri Prochazka wrote:
> Method check_output used for getting hash of HEAD in git repo was
> introduced in Python2.7 and it does not work for Python2.6 which is
> default Python version for RHEL6.x.
>
> This patch replaces method check_output with Popen which is available in
> both 2.6 and 2.7.
>
> Fixes #174
>
> ---
> changes in v2:
> prettier code
> changes in v3:
> process handling inserted in try-except block -> if user does not have
> git installed, it will throw OSError exception
> ---
> Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com>
>
> Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com>
> ---
The Signed-of-by line should be part of the commit message - before the
first '---' line, otherwise it won't be part of the commit after
applying.
But I can fix that manually when pushing so no need for a v4 because of
that.
Other than that I think everything looks fine.
Unless anyone else has any comments then I can Ack this and push it to
master.
Acked-by: Ondrej Lichtner <olichtne(a)redhat.com>
_______________________________________________
LNST-developers mailing list
lnst-developers(a)lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/lnst-developers@lists.fedoraho...
I'm fine with this.
Acked-by: Jan Tluka <jtluka(a)redhat.com>
-Jan