Re: [PATCH] NetConfigDevice: don't set loopback device down

[Jiri Prochazka]

Acked-by: Jiri Prochazka <jprochaz(a)redhat.com&gt;

​Best regards,​

Jiri Prochazka
LNST Developer
​| www.lnst-project.org​

[phone] | jprochaz(a)redhat.com
Red Hat Czech | Purkyňova 71/99, 612 00 Brno

2015-08-27 11:20 GMT+02:00 Jan Tluka <jtluka(a)redhat.com&gt;:

>  We do not want to bring loopback device down in root namespace as
>  this might have an unpredictable impact on further testing.
>  In case of non-root namespace leaving loopback device up is not
>  a problem since the namespace will get destroyed after recipe is
>  finished anyway.
>
>  Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
>  ---
>   lnst/Slave/NetConfigDevice.py | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
>  diff --git a/lnst/Slave/NetConfigDevice.py b/lnst/Slave/NetConfigDevice.py
>  index 0fbc3f0..1422850 100644
>  --- a/lnst/Slave/NetConfigDevice.py
>  +++ b/lnst/Slave/NetConfigDevice.py
>  @@ -97,6 +97,14 @@ class NetConfigDeviceLoopback(NetConfigDeviceGeneric):
>       def configure(self):
>           config = self._dev_config
>
>  +    def down(self):
>  +        # We do not want to bring loopback device down in root namespace
>  as
>  +        # this might have an unpredictable impact on further testing.
>  +        # In case of non-root namespace leaving loopback device up is not
>  +        # a problem since the namespace will get destroyed after recipe is
>  +        # finished
>  +        pass
>  +
>   class NetConfigDeviceBond(NetConfigDeviceGeneric):
>       _modulename = "bonding"
>       _moduleparams = "max_bonds=0"
>  --
>  2.1.0
>
>  _______________________________________________
>  LNST-developers mailing list
>  LNST-developers(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/mailman/listinfo/lnst-developers
>