This patch adds checks in CoalescingHWConfigMixin and MTUHWConfigMixin of
the individual mixin parameters and skips their configuration if they are None.
Signed-off-by: Jan Tluka <jtluka(a)redhat.com>
---
.../ConfigMixins/CoalescingHWConfigMixin.py | 21 ++++++++-----------
.../ENRT/ConfigMixins/MTUHWConfigMixin.py | 8 ++++---
2 files changed, 14 insertions(+), 15 deletions(-)
diff --git a/lnst/Recipes/ENRT/ConfigMixins/CoalescingHWConfigMixin.py
b/lnst/Recipes/ENRT/ConfigMixins/CoalescingHWConfigMixin.py
index 0e8807af..affad398 100644
--- a/lnst/Recipes/ENRT/ConfigMixins/CoalescingHWConfigMixin.py
+++ b/lnst/Recipes/ENRT/ConfigMixins/CoalescingHWConfigMixin.py
@@ -32,18 +32,15 @@ class CoalescingHWConfigMixin(BaseHWConfigMixin):
def hw_config(self, config):
super().hw_config(config)
- self._configure_dev_attribute(
- config,
- self.coalescing_hw_config_dev_list,
- "adaptive_rx_coalescing",
- getattr(self.params, "adaptive_rx_coalescing", None),
- )
- self._configure_dev_attribute(
- config,
- self.coalescing_hw_config_dev_list,
- "adaptive_tx_coalescing",
- getattr(self.params, "adaptive_tx_coalescing", None),
- )
+ for param in ["adaptive_rx_coalescing",
"adaptive_tx_coalescing"]:
+ param_value = getattr(self.params, param, None)
+ if param_value is not None:
+ self._configure_dev_attribute(
+ config,
+ self.coalescing_hw_config_dev_list,
+ param,
+ param_value
+ )
def describe_hw_config(self, config):
desc = super().describe_hw_config(config)
diff --git a/lnst/Recipes/ENRT/ConfigMixins/MTUHWConfigMixin.py
b/lnst/Recipes/ENRT/ConfigMixins/MTUHWConfigMixin.py
index cbd7d62e..e24ec320 100644
--- a/lnst/Recipes/ENRT/ConfigMixins/MTUHWConfigMixin.py
+++ b/lnst/Recipes/ENRT/ConfigMixins/MTUHWConfigMixin.py
@@ -26,9 +26,11 @@ class MTUHWConfigMixin(BaseHWConfigMixin):
def hw_config(self, config):
super().hw_config(config)
- self._configure_dev_attribute(
- config, self.mtu_hw_config_dev_list, "mtu", getattr(self.params,
"mtu", None)
- )
+ mtu_value = getattr(self.params, "mtu", None)
+ if mtu_value is not None:
+ self._configure_dev_attribute(
+ config, self.mtu_hw_config_dev_list, "mtu", mtu_value
+ )
def describe_hw_config(self, config):
desc = super().describe_hw_config(config)
--
2.21.1