Re: [PATCH 1/3] Ping.Evaluators: fix evaluate_results method parameters

[Ondrej Lichtner]

On Tue, Jan 26, 2021 at 06:09:47PM +0100, Jan Tluka wrote:
>  Tue, Jan 26, 2021 at 03:09:15PM CET, olichtne(a)redhat.com wrote:
>  >From: Ondrej Lichtner <olichtne(a)redhat.com&gt;
>  >
>  >The evaluate_results method signature changed in
>  >cd5328db8b0196a6102ebea54bdea1ce632cfe46 and the ping evaluators weren't
>  >updated...
>  >
>  >Signed-off-by: Ondrej Lichtner <olichtne(a)redhat.com&gt;
>  >---
>  > lnst/RecipeCommon/Ping/Evaluators/RatePingEvaluator.py | 10 +++++++++-
>  > .../Ping/Evaluators/ZeroPassPingEvaluator.py           | 10 +++++++++-
>  > 2 files changed, 18 insertions(+), 2 deletions(-)
>  
>  
>  There's one more change required here and that is in:
>  lnst/RecipeCommon/Ping/Recipe.py and PingTestAndEvaluate.single_ping_evaluate()
>  
>  This uses:
>      evaluator.evaluate_results(self, result[1])
>  
>  which needs to be updated.
>  
>  Also wondering if specific recipes (Ipsec) that override the ping
>  functionality requires updates, too.
>  
>  -Jan 

On irc we agreed on skipping this patch for this series, it was intended
to fix an assumed crashing issue for ping evaluators caused by
cd5328db8b0196a6102ebea54bdea1ce632cfe46 changing the BaseEvaluator
method signatures.

This is however not happening as the call hierarchy and method
implementation hierarchy for PingRecipe and PingEvaluators overrides the
relevant methods completely and removes the addtitional parameter. There
are therefore no crashes to fix at the moment.

We should at some point update the PingRecipe code to include the
additional parameter to improve code consistency, however that is a
bigger code change and this patchset was only intended to fix currently
crashing recipes caused by recent changes.

-Ondrej