Re: [PATCH 00/15] PyRecipes draft v2

[Ondrej Lichtner]

On Tue, Jul 12, 2016 at 11:00:21AM +0200, Jiri Prochazka wrote:
>  I did resolve the issues everyone pointed out on first version of the
> draft.
>  Patchset is changed to work with git bisect as team requested.
>  
>  Please, review the patchset again and let me know if you run into any issues.
>  
>  After the patches will be stable enough, next steps will be pushing it to a new
>  branch and start with transforming the tests to PyRecipes. When all the tests
>  and LNST will be stable enough, we can merge it to upstream.
>  
>  Jiri Prochazka (15):
>    NetTestController: add multi_match argument to __init__
>    lnst-ctl: add multi_match option to NetTestController init
>    NetTestController: store defined aliases in attribute
>    NetTestController: add run_mode attribute
>    NetTestController: add set_machine_requirements method
>    NetTestController: add prepare_test_env and init_taskapi methods
>    Task: add global level TaskAPI methods used in PyRecipes
>    Task: add new ControllerAPI methods
>    pyrecipes: add example recipes
>    __init__: export module level API methods
>    Task: add HostAPI methods
>    PyRecipes: add PyRecipes support
>    lnst-ctl: remove overriden aliases
>    NetTestController: remove obsolete code
>    Task: remove deprecated methods
>  
>   lnst-ctl                             |  21 +-
>   lnst/Controller/NetTestController.py | 372 +++++++----------------------------
>   lnst/Controller/Task.py              | 244 ++++++++++++-----------
>   lnst/__init__.py                     |   1 +
>   pyrecipes/3_vlans.py                 |  34 ++++
>   pyrecipes/example.py                 |  33 ++++
>   pyrecipes/ping_flood.py              |  48 +++++
>   7 files changed, 329 insertions(+), 424 deletions(-)
>   create mode 100644 pyrecipes/3_vlans.py
>   create mode 100644 pyrecipes/example.py
>   create mode 100644 pyrecipes/ping_flood.py
>  
>  -- 
>  2.4.11
>  _______________________________________________
>  LNST-developers mailing list
>  lnst-developers(a)lists.fedorahosted.org
>  https://lists.fedorahosted.org/admin/lists/[e-mail]... 
Overall, I think the patchset looks a lot better than the first version.
I still think it could be nicer if the commits that add functionality at
the beginning were ordered in such a way that none of them use functions
added in a later patch. Even though they don't break bisection right now
since the code is unreachable until later commits it's just nicer when
the commits are logically ordered.

So I'd say fix this and the other issues brought up by jpirko and I
think that v3 of the patchset will be pretty likely to be accepted.

-Ondrej