[PATCH] Add no_pause_frames_dev_list

From: Aniss Loughalm <aloughla(a)redhat.com&gt;

Signed-off-by: Aniss Loughalm <aloughla(a)redhat.com&gt;
---
 lnst/Recipes/ENRT/BondRecipe.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lnst/Recipes/ENRT/BondRecipe.py b/lnst/Recipes/ENRT/BondRecipe.py
index 6ef40db..07d7cfc 100644
--- a/lnst/Recipes/ENRT/BondRecipe.py
+++ b/lnst/Recipes/ENRT/BondRecipe.py
@@ -111,3 +111,7 @@ class BondRecipe(CommonHWSubConfigMixin, OffloadSubConfigMixin,
     def parallel_stream_qdisc_hw_config_dev_list(self):
         return [self.matched.host1.eth0, self.matched.host1.eth1,
             self.matched.host2.eth0]
+
+     @property
+     def no_pause_frames_dev_list(self):
+         return [self.matched.host1.eth0, self.matched.host1.eth1,
self.matched.host2.eth0]
-- 
2.24.1

[Jan Tluka]

Wed, Apr 29, 2020 at 07:41:42PM CEST, aloughla(a)redhat.com wrote:
> From: Aniss Loughalm <aloughla(a)redhat.com&gt;
>
> Signed-off-by: Aniss Loughalm <aloughla(a)redhat.com&gt; 
You have a typo in your surname. You need to fix this in your git configuration.

> ---
>  lnst/Recipes/ENRT/BondRecipe.py | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lnst/Recipes/ENRT/BondRecipe.py b/lnst/Recipes/ENRT/BondRecipe.py
> index 6ef40db..07d7cfc 100644
> --- a/lnst/Recipes/ENRT/BondRecipe.py
> +++ b/lnst/Recipes/ENRT/BondRecipe.py
> @@ -111,3 +111,7 @@ class BondRecipe(CommonHWSubConfigMixin, OffloadSubConfigMixin,
>      def parallel_stream_qdisc_hw_config_dev_list(self):
>          return [self.matched.host1.eth0, self.matched.host1.eth1,
>              self.matched.host2.eth0]
> +
> +     @property
> +     def no_pause_frames_dev_list(self):
> +         return [self.matched.host1.eth0, self.matched.host1.eth1,
> self.matched.host2.eth0] 
Please keep lines shorter than 80 characters if possible.

In this case you can simply copy the device list format from the property
above.

Thinking about this further. I think we should add this property to
other tests, too.

-Jan

> -- 
> 2.24.1
> _______________________________________________
> LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
> To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...

[Aniss Loughlam]

On Thu, Apr 30, 2020 at 2:38 AM Jan Tluka <jtluka(a)redhat.com&gt; wrote:

>  Wed, Apr 29, 2020 at 07:41:42PM CEST, aloughla(a)redhat.com wrote:
>  >From: Aniss Loughalm <aloughla(a)redhat.com&gt;
>  >
>  >Signed-off-by: Aniss Loughalm <aloughla(a)redhat.com&gt;
>
>  You have a typo in your surname. You need to fix this in your git
>  configuration.
>  
Fixed

>  >---
>  > lnst/Recipes/ENRT/BondRecipe.py | 4 ++++
>  > 1 file changed, 4 insertions(+)
>  >
>  >diff --git a/lnst/Recipes/ENRT/BondRecipe.py
>  b/lnst/Recipes/ENRT/BondRecipe.py
>  >index 6ef40db..07d7cfc 100644
>  >--- a/lnst/Recipes/ENRT/BondRecipe.py
>  >+++ b/lnst/Recipes/ENRT/BondRecipe.py
>  >@@ -111,3 +111,7 @@ class BondRecipe(CommonHWSubConfigMixin,
>  OffloadSubConfigMixin,
>  >     def parallel_stream_qdisc_hw_config_dev_list(self):
>  >         return [self.matched.host1.eth0, self.matched.host1.eth1,
>  >             self.matched.host2.eth0]
>  >+
>  >+     @property
>  >+     def no_pause_frames_dev_list(self):
>  >+         return [self.matched.host1.eth0, self.matched.host1.eth1,
>  self.matched.host2.eth0]
>
>  Please keep lines shorter than 80 characters if possible.
>  
Got it,

>  In this case you can simply copy the device list format from the property
>  above.
>
>  Thinking about this further. I think we should add this property to
>  other tests, too.
>
>  -Jan
>  
Thank you,
Aniss

>  >--
>  >2.24.1
>  >_______________________________________________
>  >LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
>  >To unsubscribe send an email to
>  lnst-developers-leave(a)lists.fedorahosted.org
>  >Fedora Code of Conduct:
>  https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  >List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  >List Archives:
>  https://lists.fedorahosted.org/archives/list/[e-mail]...
>
>

[Ondrej Lichtner]

On Wed, Apr 29, 2020 at 01:41:42PM -0400, aloughla(a)redhat.com wrote:
>  From: Aniss Loughalm <aloughla(a)redhat.com&gt;
>  
>  Signed-off-by: Aniss Loughalm <aloughla(a)redhat.com&gt;
>  ---
>   lnst/Recipes/ENRT/BondRecipe.py | 4 ++++
>   1 file changed, 4 insertions(+)
>  
>  diff --git a/lnst/Recipes/ENRT/BondRecipe.py b/lnst/Recipes/ENRT/BondRecipe.py
>  index 6ef40db..07d7cfc 100644
>  --- a/lnst/Recipes/ENRT/BondRecipe.py
>  +++ b/lnst/Recipes/ENRT/BondRecipe.py
>  @@ -111,3 +111,7 @@ class BondRecipe(CommonHWSubConfigMixin, OffloadSubConfigMixin,
>       def parallel_stream_qdisc_hw_config_dev_list(self):
>           return [self.matched.host1.eth0, self.matched.host1.eth1,
>               self.matched.host2.eth0]
>  +
>  +     @property
>  +     def no_pause_frames_dev_list(self):
>  +         return [self.matched.host1.eth0, self.matched.host1.eth1,
> self.matched.host2.eth0]
>  -- 
>  2.24.1
>  _______________________________________________
>  LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
>  To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...
I fixed the typo in the name and the line length.

Pushed the patch upstream.

thanks,
-Ondrej

[Ondrej Lichtner]

On Wed, Apr 29, 2020 at 01:41:42PM -0400, aloughla(a)redhat.com wrote:
>  From: Aniss Loughalm <aloughla(a)redhat.com&gt;
>  
>  Signed-off-by: Aniss Loughalm <aloughla(a)redhat.com&gt;
>  ---
>   lnst/Recipes/ENRT/BondRecipe.py | 4 ++++
>   1 file changed, 4 insertions(+)
>  
>  diff --git a/lnst/Recipes/ENRT/BondRecipe.py b/lnst/Recipes/ENRT/BondRecipe.py
>  index 6ef40db..07d7cfc 100644
>  --- a/lnst/Recipes/ENRT/BondRecipe.py
>  +++ b/lnst/Recipes/ENRT/BondRecipe.py
>  @@ -111,3 +111,7 @@ class BondRecipe(CommonHWSubConfigMixin, OffloadSubConfigMixin,
>       def parallel_stream_qdisc_hw_config_dev_list(self):
>           return [self.matched.host1.eth0, self.matched.host1.eth1,
>               self.matched.host2.eth0]
>  +
>  +     @property
>  +     def no_pause_frames_dev_list(self):
>  +         return [self.matched.host1.eth0, self.matched.host1.eth1,
> self.matched.host2.eth0]
>  -- 
>  2.24.1
>  _______________________________________________
>  LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
>  To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...
For some reason there are 5 indentation spaces in your patch... that may
be a configuration problem with your editor I recommend double checking
that.

-Ondrej