[PATCH] Add skb_clone option to PktgenTx test

[Jan Tluka]

The pktgen's skb_clone > 0 is not valid for bonds/vlans in RHEL. This is
due to fix of bug https://bugzilla.redhat.com/show_bug.cgi?id=678794.

Following patch adds skb_clone option that can be set to 0 for such cases. 
The default value remains 100000. Tested by myself on RHEL6.

---
 Tests/TestPktgenTx.py |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/Tests/TestPktgenTx.py b/Tests/TestPktgenTx.py
index 5e48f2c..5ec500f 100644
--- a/Tests/TestPktgenTx.py
+++ b/Tests/TestPktgenTx.py
@@ -57,6 +57,7 @@ class TestPktgenTx(TestGeneric):
         addr = self.get_mopt("addr", opt_type="addr")
         hwaddr = self.get_mopt("hwaddr")
         vlan_tci = self.get_opt("vlan_tci", default=0)
+        skb_clone = self.get_opt("skb_clone", default=100000)
 
         exec_cmd("modprobe pktgen")
 
@@ -67,7 +68,7 @@ class TestPktgenTx(TestGeneric):
             for dev_name in dev_names:
                 pgwrkr.add_device(dev_name)
                 pg = Pktgen("/proc/net/pktgen/%s" % dev_name)
-                pg.set("clone_skb 100000")
+                pg.set("clone_skb %s" % skb_clone)
                 pg.set("pkt_size 60")
                 pg.set("dst %s" % addr)
                 pg.set("dst_mac %s" % hwaddr)
-- 
1.7.6.5

[Jiri Pirko]

applied

Thu, Apr 26, 2012 at 05:45:15PM CEST, jtluka(a)redhat.com wrote:
> The pktgen's skb_clone > 0 is not valid for bonds/vlans in
> RHEL. This is
> due to fix of bug https://bugzilla.redhat.com/show_bug.cgi?id=678794.
>
> Following patch adds skb_clone option that can be set to 0 for such cases. 
> The default value remains 100000. Tested by myself on RHEL6.
>
> ---
>  Tests/TestPktgenTx.py |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/Tests/TestPktgenTx.py b/Tests/TestPktgenTx.py
> index 5e48f2c..5ec500f 100644
> --- a/Tests/TestPktgenTx.py
> +++ b/Tests/TestPktgenTx.py
> @@ -57,6 +57,7 @@ class TestPktgenTx(TestGeneric):
>          addr = self.get_mopt("addr", opt_type="addr")
>          hwaddr = self.get_mopt("hwaddr")
>          vlan_tci = self.get_opt("vlan_tci", default=0)
> +        skb_clone = self.get_opt("skb_clone", default=100000)
>  
>          exec_cmd("modprobe pktgen")
>  
> @@ -67,7 +68,7 @@ class TestPktgenTx(TestGeneric):
>              for dev_name in dev_names:
>                  pgwrkr.add_device(dev_name)
>                  pg = Pktgen("/proc/net/pktgen/%s" % dev_name)
> -                pg.set("clone_skb 100000")
> +                pg.set("clone_skb %s" % skb_clone)
>                  pg.set("pkt_size 60")
>                  pg.set("dst %s" % addr)
>                  pg.set("dst_mac %s" % hwaddr)
> -- 
> 1.7.6.5
>
> _______________________________________________
> LNST-developers mailing list
> LNST-developers(a)lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/lnst-developers