[PATCH-next] lnst.Devices: edit cleanup method in Device

From: Christos Sfakianakis

Have any master device(s) cleaned up before the cleanup of
the slave(s) is started. This helps preventing DeviceConfigError
thrown during the deconfiguration stage which would result in
device(s) not being cleaned up after the test. This has been notable
with VirtualOvsBridge* recipes.

Signed-off-by: Christos Sfakianakis 
---
 lnst/Devices/Device.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lnst/Devices/Device.py b/lnst/Devices/Device.py
index d9aa023..b78b295 100644
--- a/lnst/Devices/Device.py
+++ b/lnst/Devices/Device.py
@@ -329,6 +329,7 @@ class Device(object):
         values.
         """
         if self.master:
+            self.master.cleanup()
             self.master = None
         self.down()
         self.ip_flush()

[Ondrej Lichtner]

On Tue, Mar 19, 2019 at 05:19:59PM +0100, [e-mail] wrote:
> From: Christos Sfakianakis
>
> Have any master device(s) cleaned up before the cleanup of
> the slave(s) is started. This helps preventing DeviceConfigError
> thrown during the deconfiguration stage which would result in
> device(s) not being cleaned up after the test. This has been notable
> with VirtualOvsBridge* recipes.
> Signed-off-by: Christos Sfakianakis
>
> lnst/Devices/Device.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lnst/Devices/Device.py b/lnst/Devices/Device.py
> index d9aa023..b78b295 100644
> --- a/lnst/Devices/Device.py
> +++ b/lnst/Devices/Device.py
> @@ -329,6 +329,7 @@ class Device(object):
>          values.
>          """
>          if self.master:
>        self.master.cleanup()
>        self.master = None
>    self.down()
>    self.ip_flush()
>
> -- 
> 2.17.1
> _______________________________________________
> LNST-developers mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: https://lists.fedorahosted.org/archives/list/[e-mail]...

Looks good, pushed.

Thanks.
-Ondrej