[PATCH] Don't remove any modules on device cleanup

[Jan Tluka]

Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
---
 lnst/Slave/NetConfigDevice.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lnst/Slave/NetConfigDevice.py b/lnst/Slave/NetConfigDevice.py
index 53e89b2..0c71fc7 100644
--- a/lnst/Slave/NetConfigDevice.py
+++ b/lnst/Slave/NetConfigDevice.py
@@ -72,9 +72,6 @@ class NetConfigDeviceGeneric:
     def type_cleanup(self):
         if self._cleanupcmd:
             exec_cmd(self._cleanupcmd, die_on_err=False)
-        if self._modulename:
-            kmod_in_use(self._modulename, 300)
-            exec_cmd("modprobe -q -r %s" % self._modulename, die_on_err=False)
 
 class NetConfigDeviceEth(NetConfigDeviceGeneric):
     def configure(self):
-- 
1.8.1.4

[Jiri Pirko]

Please provide some description...


Fri, Jan 17, 2014 at 03:46:57PM CET, jtluka(a)redhat.com wrote:
> Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
> ---
>  lnst/Slave/NetConfigDevice.py | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/lnst/Slave/NetConfigDevice.py b/lnst/Slave/NetConfigDevice.py
> index 53e89b2..0c71fc7 100644
> --- a/lnst/Slave/NetConfigDevice.py
> +++ b/lnst/Slave/NetConfigDevice.py
> @@ -72,9 +72,6 @@ class NetConfigDeviceGeneric:
>      def type_cleanup(self):
>          if self._cleanupcmd:
>              exec_cmd(self._cleanupcmd, die_on_err=False)
> -        if self._modulename:
> -            kmod_in_use(self._modulename, 300)
> -            exec_cmd("modprobe -q -r %s" % self._modulename, die_on_err=False)
>  
>  class NetConfigDeviceEth(NetConfigDeviceGeneric):
>      def configure(self):
> -- 
> 1.8.1.4
>
> _______________________________________________
> LNST-developers mailing list
> LNST-developers(a)lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/lnst-developers

[Jan Tluka]

Sat, Jan 25, 2014 at 01:10:40PM CET, jpirko(a)redhat.com wrote:
> Please provide some description...
>  
I've resent the patch with a description.

> Fri, Jan 17, 2014 at 03:46:57PM CET, jtluka(a)redhat.com wrote:
> >Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
> >---
> > lnst/Slave/NetConfigDevice.py | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> >diff --git a/lnst/Slave/NetConfigDevice.py b/lnst/Slave/NetConfigDevice.py
> >index 53e89b2..0c71fc7 100644
> >--- a/lnst/Slave/NetConfigDevice.py
> >+++ b/lnst/Slave/NetConfigDevice.py
> >@@ -72,9 +72,6 @@ class NetConfigDeviceGeneric:
> >     def type_cleanup(self):
> >         if self._cleanupcmd:
> >             exec_cmd(self._cleanupcmd, die_on_err=False)
> >-        if self._modulename:
> >-            kmod_in_use(self._modulename, 300)
> >-            exec_cmd("modprobe -q -r %s" % self._modulename,
> die_on_err=False)
> > 
> > class NetConfigDeviceEth(NetConfigDeviceGeneric):
> >     def configure(self):
> >-- 
> >1.8.1.4
> >
> >_______________________________________________
> >LNST-developers mailing list
> &gt;LNST-developers(a)lists.fedorahosted.org
> >https://lists.fedorahosted.org/mailman/listinfo/lnst-developers