[PATCH] Revert "add sleep between start of iperf server and client"

[Jan Tluka]

This reverts commit a961862ff4734b609d7b6325bc2555829833f906.

Some issues popped up when this patch was used.

First issue was with the CPUStatMeasurement that is used in ENRT recipes.
The 2 seconds delay caused the measurement to include samples when the CPUs
were idle and reported 1-2% lower utilization.

Second issue was a result of iperf bug [1], when the iperf measures CPU
utilization from the moment the iperf server program is started, again
this includes 2 seconds of idling.

Until both issues are dealt with, the simplest solution is to revert the
patch.

[1] https://github.com/esnet/iperf/issues/1076

Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
---
 lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py
b/lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py
index c0ead127..c1939875 100644
--- a/lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py
+++ b/lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py
@@ -57,7 +57,6 @@ class IperfFlowMeasurement(BaseFlowMeasurement):
         for flow in test_flows:
             flow.server_job.start(bg=True)
 
-        time.sleep(2)
         for flow in test_flows:
             flow.client_job.start(bg=True)
 
-- 
2.26.2

[Jan Tluka]

Fri, Nov 27, 2020 at 11:31:34AM CET, jtluka(a)redhat.com wrote:
> This reverts commit a961862ff4734b609d7b6325bc2555829833f906.
>
> Some issues popped up when this patch was used.
>
> First issue was with the CPUStatMeasurement that is used in ENRT recipes.
> The 2 seconds delay caused the measurement to include samples when the CPUs
> were idle and reported 1-2% lower utilization.
>
> Second issue was a result of iperf bug [1], when the iperf measures CPU
> utilization from the moment the iperf server program is started, again
> this includes 2 seconds of idling.
>
> Until both issues are dealt with, the simplest solution is to revert the
> patch.
>
> [1] https://github.com/esnet/iperf/issues/1076
>
> Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
> ---
>  lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py
> b/lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py
> index c0ead127..c1939875 100644
> --- a/lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py
> +++ b/lnst/RecipeCommon/Perf/Measurements/IperfFlowMeasurement.py
> @@ -57,7 +57,6 @@ class IperfFlowMeasurement(BaseFlowMeasurement):
>          for flow in test_flows:
>              flow.server_job.start(bg=True)
>  
> -        time.sleep(2)
>          for flow in test_flows:
>              flow.client_job.start(bg=True)
>  
> -- 
> 2.26.2
> _______________________________________________
> LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
> To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...
Pushed to master.

-Jan