[PATCH 1/2] Rename InterfaceAPI method get_ip_addr to get_ip, but keep the old one as alias

[Jiri Prochazka]

Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com&gt;
---
 lnst/Controller/Task.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/lnst/Controller/Task.py b/lnst/Controller/Task.py
index 0d437f3..4d0908d 100644
--- a/lnst/Controller/Task.py
+++ b/lnst/Controller/Task.py
@@ -355,12 +355,18 @@ class InterfaceAPI(object):
     def get_hwaddr(self):
         return VolatileValue(self._if.get_hwaddr)
 
-    def get_ip_addr(self, ip_index):
+    def get_ip(self, ip_index):
         return VolatileValue(self._if.get_address, ip_index)
 
-    def get_ip_addrs(self):
+    def get_ips(self):
         return VolatileValue(self._if.get_addresses)
 
+    def get_ip_addr(self, ip_index):
+        return self.get_ip(ip_index)
+
+    def get_ip_addrs(self):
+        return self.get_ips()
+
     def get_ip_prefix(self, ip_index):
         return VolatileValue(self._if.get_prefix, ip_index)
 
-- 
2.4.3

[PATCH 2/2] Show warning log message when HostAPI get_ip method is used

[Jiri Prochazka]

Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com&gt;
---
 lnst/Controller/Task.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lnst/Controller/Task.py b/lnst/Controller/Task.py
index 4d0908d..2b89d6e 100644
--- a/lnst/Controller/Task.py
+++ b/lnst/Controller/Task.py
@@ -12,6 +12,7 @@ rpazdera(a)redhat.com (Radek Pazdera)
 
 import hashlib
 import re
+import logging
 from lnst.Controller.PerfRepo import PerfRepoRESTAPI
 from lnst.Controller.PerfRepo import PerfRepoTestExecution
 from lnst.Controller.PerfRepo import PerfRepoValue
@@ -285,7 +286,10 @@ class HostAPI(object):
         iface = self._interfaces[interface_id]
         return iface.get_hwaddr()
 
+    # deprecated
     def get_ip(self, interface_id, addr_number=0):
+        logging.warning("Deprecated HostAPI method get_ip is used in Python "\
+                        "task, please, use InterfaceAPI method get_ip
instead.")
         """
             Returns an IP address of the interface.
 
-- 
2.4.3

[PATCH 2/2] Show warning log message when HostAPI get_ip method is used

[Jan Tluka]

I think you want to the deprecation warning to get_ip_addr() and not to
the fresh and shiny new get_ip(), correct?

Mon, Aug 24, 2015 at 04:28:31PM CEST, jprochaz(a)redhat.com wrote:
> Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com&gt;
> ---
>  lnst/Controller/Task.py | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lnst/Controller/Task.py b/lnst/Controller/Task.py
> index 4d0908d..2b89d6e 100644
> --- a/lnst/Controller/Task.py
> +++ b/lnst/Controller/Task.py
> @@ -12,6 +12,7 @@ rpazdera(a)redhat.com (Radek Pazdera)
>  
>  import hashlib
>  import re
> +import logging
>  from lnst.Controller.PerfRepo import PerfRepoRESTAPI
>  from lnst.Controller.PerfRepo import PerfRepoTestExecution
>  from lnst.Controller.PerfRepo import PerfRepoValue
> @@ -285,7 +286,10 @@ class HostAPI(object):
>          iface = self._interfaces[interface_id]
>          return iface.get_hwaddr()
>  
> +    # deprecated
>      def get_ip(self, interface_id, addr_number=0):
> +        logging.warning("Deprecated HostAPI method get_ip is used in Python "\
> +                        "task, please, use InterfaceAPI method get_ip
> instead.")
>          """
>              Returns an IP address of the interface.
>  
> -- 
> 2.4.3
>
> _______________________________________________
> LNST-developers mailing list
> LNST-developers(a)lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/lnst-developers

[PATCH 2/2] Show warning log message when HostAPI get_ip method is used

[Jiri Prochazka]

We have 2 get_ip methods, one is old, rusty HostAPI::get_ip(), which we
don't want to support and one fresh, shiny, new InterfaceAPI::get_ip()
method, which is in fact just renamed InterfaceAPI::get_ip_addr(). This
deprecation warning will be shown in both HostAPI::get_ip(), since the
issue #144 was filed on removing this method, and in
InterfaceAPI::get_ip_addr(), since that is only alias for
InterfaceAPI::get_ip() method.

2015-08-24 20:36 GMT+02:00 Jan Tluka <jtluka(a)redhat.com&gt;:

>  I think you want to the deprecation warning to get_ip_addr() and not
> to
>  the fresh and shiny new get_ip(), correct?
>
>  Mon, Aug 24, 2015 at 04:28:31PM CEST, jprochaz(a)redhat.com wrote:
>  >Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com&gt;
>  >---
>  > lnst/Controller/Task.py | 4 ++++
>  > 1 file changed, 4 insertions(+)
>  >
>  >diff --git a/lnst/Controller/Task.py b/lnst/Controller/Task.py
>  >index 4d0908d..2b89d6e 100644
>  >--- a/lnst/Controller/Task.py
>  >+++ b/lnst/Controller/Task.py
>  >@@ -12,6 +12,7 @@ rpazdera(a)redhat.com (Radek Pazdera)
>  >
>  > import hashlib
>  > import re
>  >+import logging
>  > from lnst.Controller.PerfRepo import PerfRepoRESTAPI
>  > from lnst.Controller.PerfRepo import PerfRepoTestExecution
>  > from lnst.Controller.PerfRepo import PerfRepoValue
>  >@@ -285,7 +286,10 @@ class HostAPI(object):
>  >         iface = self._interfaces[interface_id]
>  >         return iface.get_hwaddr()
>  >
>  >+    # deprecated
>  >     def get_ip(self, interface_id, addr_number=0):
>  >+        logging.warning("Deprecated HostAPI method get_ip is used in
>  Python "\
>  >+                        "task, please, use InterfaceAPI method get_ip
>  instead.")
>  >         """
>  >             Returns an IP address of the interface.
>  >
>  >--
>  >2.4.3
>  >
>  >_______________________________________________
>  >LNST-developers mailing list
>  &gt;LNST-developers(a)lists.fedorahosted.org
>  >https://lists.fedorahosted.org/mailman/listinfo/lnst-developers
>

[PATCH 2/2] Show warning log message when HostAPI get_ip method is used

[Jan Tluka]

Mon, Aug 24, 2015 at 09:52:13PM CEST, jprochaz(a)redhat.com wrote:
> We have 2 get_ip methods, one is old, rusty HostAPI::get_ip(), which
> we
> don't want to support and one fresh, shiny, new InterfaceAPI::get_ip()
> method, which is in fact just renamed InterfaceAPI::get_ip_addr(). This
> deprecation warning will be shown in both HostAPI::get_ip(), since the
> issue #144 was filed on removing this method, and in
> InterfaceAPI::get_ip_addr(), since that is only alias for
> InterfaceAPI::get_ip() method.
>  
Oh, sorry Jirka. I did not notice that.

Will review again tomorrow. Obviously it is quite late to review patches.

-Jan

> 2015-08-24 20:36 GMT+02:00 Jan Tluka <jtluka(a)redhat.com&gt;:
>
> > I think you want to the deprecation warning to get_ip_addr() and not to
> > the fresh and shiny new get_ip(), correct?
> >
> > Mon, Aug 24, 2015 at 04:28:31PM CEST, jprochaz(a)redhat.com wrote:
> > >Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com&gt;
> > >---
> > > lnst/Controller/Task.py | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > >diff --git a/lnst/Controller/Task.py b/lnst/Controller/Task.py
> > >index 4d0908d..2b89d6e 100644
> > >--- a/lnst/Controller/Task.py
> > >+++ b/lnst/Controller/Task.py
> > >@@ -12,6 +12,7 @@ rpazdera(a)redhat.com (Radek Pazdera)
> > >
> > > import hashlib
> > > import re
> > >+import logging
> > > from lnst.Controller.PerfRepo import PerfRepoRESTAPI
> > > from lnst.Controller.PerfRepo import PerfRepoTestExecution
> > > from lnst.Controller.PerfRepo import PerfRepoValue
> > >@@ -285,7 +286,10 @@ class HostAPI(object):
> > >         iface = self._interfaces[interface_id]
> > >         return iface.get_hwaddr()
> > >
> > >+    # deprecated
> > >     def get_ip(self, interface_id, addr_number=0):
> > >+        logging.warning("Deprecated HostAPI method get_ip is used in
> > Python "\
> > >+                        "task, please, use InterfaceAPI method get_ip
> > instead.")
> > >         """
> > >             Returns an IP address of the interface.
> > >
> > >--
> > >2.4.3
> > >
> > >_______________________________________________
> > >LNST-developers mailing list
> > &gt;LNST-developers(a)lists.fedorahosted.org
> > >https://lists.fedorahosted.org/mailman/listinfo/lnst-developers
> >

[PATCH 2/2] Show warning log message when HostAPI get_ip method is used

[Jiri Prochazka]

this patch is now invalid, as new implementation with decorator was
created, please review the new patchset

Thanks

​Best regards,​

Jiri Prochazka
LNST Developer
​| www.lnst-project.org​

[phone] | jprochaz(a)redhat.com
Red Hat Czech | Purkyňova 71/99, 612 00 Brno

2015-08-24 21:59 GMT+02:00 Jan Tluka <jtluka(a)redhat.com&gt;:

>  Mon, Aug 24, 2015 at 09:52:13PM CEST, jprochaz(a)redhat.com wrote:
>  >We have 2 get_ip methods, one is old, rusty HostAPI::get_ip(), which we
>  >don't want to support and one fresh, shiny, new InterfaceAPI::get_ip()
>  >method, which is in fact just renamed InterfaceAPI::get_ip_addr(). This
>  >deprecation warning will be shown in both HostAPI::get_ip(), since the
>  >issue #144 was filed on removing this method, and in
>  >InterfaceAPI::get_ip_addr(), since that is only alias for
>  >InterfaceAPI::get_ip() method.
>  >
>
>  Oh, sorry Jirka. I did not notice that.
>
>  Will review again tomorrow. Obviously it is quite late to review patches.
>
>  -Jan
>
>  >2015-08-24 20:36 GMT+02:00 Jan Tluka <jtluka(a)redhat.com&gt;:
>  >
>  >> I think you want to the deprecation warning to get_ip_addr() and not to
>  >> the fresh and shiny new get_ip(), correct?
>  >>
>  >> Mon, Aug 24, 2015 at 04:28:31PM CEST, jprochaz(a)redhat.com wrote:
>  >> >Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com&gt;
>  >> >---
>  >> > lnst/Controller/Task.py | 4 ++++
>  >> > 1 file changed, 4 insertions(+)
>  >> >
>  >> >diff --git a/lnst/Controller/Task.py b/lnst/Controller/Task.py
>  >> >index 4d0908d..2b89d6e 100644
>  >> >--- a/lnst/Controller/Task.py
>  >> >+++ b/lnst/Controller/Task.py
>  >> >@@ -12,6 +12,7 @@ rpazdera(a)redhat.com (Radek Pazdera)
>  >> >
>  >> > import hashlib
>  >> > import re
>  >> >+import logging
>  >> > from lnst.Controller.PerfRepo import PerfRepoRESTAPI
>  >> > from lnst.Controller.PerfRepo import PerfRepoTestExecution
>  >> > from lnst.Controller.PerfRepo import PerfRepoValue
>  >> >@@ -285,7 +286,10 @@ class HostAPI(object):
>  >> >         iface = self._interfaces[interface_id]
>  >> >         return iface.get_hwaddr()
>  >> >
>  >> >+    # deprecated
>  >> >     def get_ip(self, interface_id, addr_number=0):
>  >> >+        logging.warning("Deprecated HostAPI method get_ip is used in
>  >> Python "\
>  >> >+                        "task, please, use InterfaceAPI method get_ip
>  >> instead.")
>  >> >         """
>  >> >             Returns an IP address of the interface.
>  >> >
>  >> >--
>  >> >2.4.3
>  >> >
>  >> >_______________________________________________
>  >> >LNST-developers mailing list
>  >> &gt;LNST-developers(a)lists.fedorahosted.org
>  >> >https://lists.fedorahosted.org/mailman/listinfo/lnst-developers
>  >>
>

[Jiri Prochazka]

This patch is still valid and should be applied before Add deprecated
decorator patchset

Please review, ack and push this before the above mentioned patchset

Thanks

​Best regards,​

Jiri Prochazka
LNST Developer
​| www.lnst-project.org​

[phone] | jprochaz(a)redhat.com
Red Hat Czech | Purkyňova 71/99, 612 00 Brno

2015-08-24 16:28 GMT+02:00 Jiri Prochazka <jprochaz(a)redhat.com&gt;:

>  Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com&gt;
>  ---
>   lnst/Controller/Task.py | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>
>  diff --git a/lnst/Controller/Task.py b/lnst/Controller/Task.py
>  index 0d437f3..4d0908d 100644
>  --- a/lnst/Controller/Task.py
>  +++ b/lnst/Controller/Task.py
>  @@ -355,12 +355,18 @@ class InterfaceAPI(object):
>       def get_hwaddr(self):
>           return VolatileValue(self._if.get_hwaddr)
>
>  -    def get_ip_addr(self, ip_index):
>  +    def get_ip(self, ip_index):
>           return VolatileValue(self._if.get_address, ip_index)
>
>  -    def get_ip_addrs(self):
>  +    def get_ips(self):
>           return VolatileValue(self._if.get_addresses)
>
>  +    def get_ip_addr(self, ip_index):
>  +        return self.get_ip(ip_index)
>  +
>  +    def get_ip_addrs(self):
>  +        return self.get_ips()
>  +
>       def get_ip_prefix(self, ip_index):
>           return VolatileValue(self._if.get_prefix, ip_index)
>
>  --
>  2.4.3
>
>

[Ondrej Lichtner]

On Mon, Aug 24, 2015 at 04:28:30PM +0200, Jiri Prochazka wrote:
>  Signed-off-by: Jiri Prochazka <jprochaz(a)redhat.com&gt; 
Acked-by: Ondrej Lichtner <olichtne(a)redhat.com&gt;