From: Ondrej Lichtner <olichtne(a)redhat.com>
The VirtOvsVxlanRecipe was missed during common hw config refactoring
and the old "hw_config" method was forgotten.
The recipe does inherit the correct subconfig mixin class however it's
not called due to this old hw_config method.
This patch removes the method and adds the missing device list
properties used by the common hw subconfig mixins.
The adaptive coalescing one is skipped for now as I have not found it
being used in the legacy version of the recipe.
Signed-off-by: Ondrej Lichtner <olichtne(a)redhat.com>
---
lnst/Recipes/ENRT/VirtOvsVxlanRecipe.py | 29 +++++++------------------
1 file changed, 8 insertions(+), 21 deletions(-)
diff --git a/lnst/Recipes/ENRT/VirtOvsVxlanRecipe.py
b/lnst/Recipes/ENRT/VirtOvsVxlanRecipe.py
index 9e9c0c5..66e6575 100644
--- a/lnst/Recipes/ENRT/VirtOvsVxlanRecipe.py
+++ b/lnst/Recipes/ENRT/VirtOvsVxlanRecipe.py
@@ -141,32 +141,19 @@ def generate_ping_endpoints(self, config):
def generate_perf_endpoints(self, config):
return [(self.matched.guest1.eth0, self.matched.guest3.eth0)]
+ @property
+ def pause_frames_dev_list(self):
+ return [self.matched.host1.eth0, self.matched.host2.eth0]
+
@property
def mtu_hw_config_dev_list(self):
return [self.matched.guest1.eth0, self.matched.guest2.eth0,
self.matched.guest3.eth0, self.matched.guest4.eth0]
@property
- def parallel_stream_qdisc_hw_config_dev_list(self):
+ def dev_interrupt_hw_config_dev_list(self):
return [self.matched.host1.eth0, self.matched.host2.eth0]
- def hw_config(self, config):
- host1, host2, guest1, guest2, guest3, guest4 = (self.matched.host1,
- self.matched.host2, self.matched.guest1, self.matched.guest2,
- self.matched.guest3, self.matched.guest4)
-
- config.hw_config = {}
- hw_config = config.hw_config
-
- if "dev_intr_cpu" in self.params:
- intr_cfg = hw_config["dev_intr_cpu_configuration"] = {}
- intr_cfg["irq_devs"] = {}
- intr_cfg["irqbalance_hosts"] = []
-
- for host in [host1, host2, guest1, guest2, guest3, guest4]:
- host.run("service irqbalance stop")
- intr_cfg["irqbalance_hosts"].append(host)
-
- for dev in [host1.eth0, host2.eth0]:
- self._pin_dev_interrupts(dev, self.params.dev_intr_cpu)
- intr_cfg["irq_devs"][dev] = self.params.dev_intr_cpu
+ @property
+ def parallel_stream_qdisc_hw_config_dev_list(self):
+ return [self.matched.host1.eth0, self.matched.host2.eth0]
--
2.28.0
Show replies by date
On Tue, Sep 01, 2020 at 02:21:29PM +0200, olichtne(a)redhat.com wrote:
From: Ondrej Lichtner <olichtne(a)redhat.com>
The VirtOvsVxlanRecipe was missed during common hw config refactoring
and the old "hw_config" method was forgotten.
The recipe does inherit the correct subconfig mixin class however it's
not called due to this old hw_config method.
This patch removes the method and adds the missing device list
properties used by the common hw subconfig mixins.
The adaptive coalescing one is skipped for now as I have not found it
being used in the legacy version of the recipe.
Signed-off-by: Ondrej Lichtner <olichtne(a)redhat.com>
---
lnst/Recipes/ENRT/VirtOvsVxlanRecipe.py | 29 +++++++------------------
1 file changed, 8 insertions(+), 21 deletions(-)
Tested internally and it's a straightforward patch so immediatelly
pushing.
-Ondrej