[PATCH] Recipes.ENRT.BaseEnrtRecipe: skip cross-vlan ping for IPv6

[Jan Tluka]

With the current implementation of ping6 there's no way to test
a ping from one vlan to a different one in a similar way to IPv4.

When ping6 -I <ip> makes a bind(sockfd, &ipv6address) the bind is only
a hint so it tries to use the address but if it fails it uses the other
address from the vlan interface.

We had the same issue in legacy LNST and conclusion was to disable
this test for IPv6.

Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
---
 lnst/Recipes/ENRT/BaseEnrtRecipe.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lnst/Recipes/ENRT/BaseEnrtRecipe.py b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
index 9a35cd44..f7bb5886 100644
--- a/lnst/Recipes/ENRT/BaseEnrtRecipe.py
+++ b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
@@ -367,6 +367,9 @@ class BaseEnrtRecipe(BaseSubConfigMixin, PingTestAndEvaluate,
PerfRecipe):
         """
         for endpoints in self.generate_ping_endpoints(config):
             for ipv in self.params.ip_versions:
+                if ipv == "ipv6" and not endpoints.reachable:
+                    continue
+
                 ip_filter = {}
                 if ipv == "ipv4":
                     ip_filter.update(family = AF_INET)
-- 
2.21.1

[Ondrej Lichtner]

On Thu, Apr 09, 2020 at 11:25:06AM +0200, Jan Tluka wrote:
>  With the current implementation of ping6 there's no way to test
>  a ping from one vlan to a different one in a similar way to IPv4.
>  
>  When ping6 -I <ip> makes a bind(sockfd, &ipv6address) the bind is only
>  a hint so it tries to use the address but if it fails it uses the other
>  address from the vlan interface.
>  
>  We had the same issue in legacy LNST and conclusion was to disable
>  this test for IPv6.
>  
>  Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
>  ---
>   lnst/Recipes/ENRT/BaseEnrtRecipe.py | 3 +++
>   1 file changed, 3 insertions(+)
>  
>  diff --git a/lnst/Recipes/ENRT/BaseEnrtRecipe.py b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
>  index 9a35cd44..f7bb5886 100644
>  --- a/lnst/Recipes/ENRT/BaseEnrtRecipe.py
>  +++ b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
>  @@ -367,6 +367,9 @@ class BaseEnrtRecipe(BaseSubConfigMixin, PingTestAndEvaluate,
> PerfRecipe):
>           """
>           for endpoints in self.generate_ping_endpoints(config):
>               for ipv in self.params.ip_versions:
>  +                if ipv == "ipv6" and not endpoints.reachable:
>  +                    continue
>  +
>                   ip_filter = {}
>                   if ipv == "ipv4":
>                       ip_filter.update(family = AF_INET)
>  -- 
>  2.21.1
>  _______________________________________________
>  LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
>  To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
>  Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>  List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...
ack.

-Ondrej

[Jan Tluka]

Thu, Apr 09, 2020 at 11:25:06AM CEST, jtluka(a)redhat.com wrote:
> With the current implementation of ping6 there's no way to test
> a ping from one vlan to a different one in a similar way to IPv4.
>
> When ping6 -I <ip> makes a bind(sockfd, &ipv6address) the bind is only
> a hint so it tries to use the address but if it fails it uses the other
> address from the vlan interface.
>
> We had the same issue in legacy LNST and conclusion was to disable
> this test for IPv6.
>
> Signed-off-by: Jan Tluka <jtluka(a)redhat.com&gt;
> ---
>  lnst/Recipes/ENRT/BaseEnrtRecipe.py | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lnst/Recipes/ENRT/BaseEnrtRecipe.py b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
> index 9a35cd44..f7bb5886 100644
> --- a/lnst/Recipes/ENRT/BaseEnrtRecipe.py
> +++ b/lnst/Recipes/ENRT/BaseEnrtRecipe.py
> @@ -367,6 +367,9 @@ class BaseEnrtRecipe(BaseSubConfigMixin, PingTestAndEvaluate,
> PerfRecipe):
>          """
>          for endpoints in self.generate_ping_endpoints(config):
>              for ipv in self.params.ip_versions:
> +                if ipv == "ipv6" and not endpoints.reachable:
> +                    continue
> +
>                  ip_filter = {}
>                  if ipv == "ipv4":
>                      ip_filter.update(family = AF_INET)
> -- 
> 2.21.1
> _______________________________________________
> LNST-developers mailing list -- lnst-developers(a)lists.fedorahosted.org
> To unsubscribe send an email to lnst-developers-leave(a)lists.fedorahosted.org
> Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedorahosted.org/archives/list/[e-mail]...
pushed

-Jan