[PATCH] lnst.Devices.VirtualDevice: mark device as deleted after cleanup

From: Ondrej Lichtner <olichtne(a)redhat.com&gt;

References to VirtualDevice instances are still available through the
result objects after recipe execution has finished. Attempting to access
properties (e.g. to print a summary of the recipe execution) of these
objects results in exceptions being raised.

Makring the device as 'deleted' fixes the issue.

Signed-off-by: Ondrej Lichtner <olichtne(a)redhat.com&gt;
---
 lnst/Devices/VirtualDevice.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lnst/Devices/VirtualDevice.py b/lnst/Devices/VirtualDevice.py
index de2db9c..7eb3244 100644
--- a/lnst/Devices/VirtualDevice.py
+++ b/lnst/Devices/VirtualDevice.py
@@ -97,3 +97,4 @@ class VirtualDevice(RemoteDevice):
 
         domain_ctl = self._machine.get_domain_ctl()
         domain_ctl.detach_interface(self.orig_hwaddr)
+        self.deleted = True
-- 
2.25.0

[Jan Tluka]

Fri, Feb 21, 2020 at 09:13:31AM CET, olichtne(a)redhat.com wrote:
> From: Ondrej Lichtner <olichtne(a)redhat.com&gt;
>
> References to VirtualDevice instances are still available through the
> result objects after recipe execution has finished. Attempting to access
> properties (e.g. to print a summary of the recipe execution) of these
> objects results in exceptions being raised.
>
> Makring the device as 'deleted' fixes the issue.
>
> Signed-off-by: Ondrej Lichtner <olichtne(a)redhat.com&gt;
> ---
>  lnst/Devices/VirtualDevice.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lnst/Devices/VirtualDevice.py b/lnst/Devices/VirtualDevice.py
> index de2db9c..7eb3244 100644
> --- a/lnst/Devices/VirtualDevice.py
> +++ b/lnst/Devices/VirtualDevice.py
> @@ -97,3 +97,4 @@ class VirtualDevice(RemoteDevice):
>  
>          domain_ctl = self._machine.get_domain_ctl()
>          domain_ctl.detach_interface(self.orig_hwaddr)
> +        self.deleted = True 
Makes sense.

Acked-by: Jan Tluka <jtluka(a)redhat.com&gt;

[Ondrej Lichtner]

On Fri, Feb 21, 2020 at 09:13:31AM +0100, olichtne(a)redhat.com wrote:
>  From: Ondrej Lichtner <olichtne(a)redhat.com&gt;
>  
>  References to VirtualDevice instances are still available through the
>  result objects after recipe execution has finished. Attempting to access
>  properties (e.g. to print a summary of the recipe execution) of these
>  objects results in exceptions being raised.
>  
>  Makring the device as 'deleted' fixes the issue.
>  
>  Signed-off-by: Ondrej Lichtner <olichtne(a)redhat.com&gt;
>  ---
>   lnst/Devices/VirtualDevice.py | 1 +
>   1 file changed, 1 insertion(+)
>  
>  diff --git a/lnst/Devices/VirtualDevice.py b/lnst/Devices/VirtualDevice.py
>  index de2db9c..7eb3244 100644
>  --- a/lnst/Devices/VirtualDevice.py
>  +++ b/lnst/Devices/VirtualDevice.py
>  @@ -97,3 +97,4 @@ class VirtualDevice(RemoteDevice):
>   
>           domain_ctl = self._machine.get_domain_ctl()
>           domain_ctl.detach_interface(self.orig_hwaddr)
>  +        self.deleted = True
>  -- 
>  2.25.0
>   
pushed

-Ondrej