master - Clean-up: Adjust message to be clearer on action taken and why
by Jonathan Brassow
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=7519d881ef07c4...
Commit: 7519d881ef07c4a515716099a4bf9566b7f71b1a
Parent: ea6a8078b41df75344aecff4c54aab9c78b67193
Author: Jonathan Brassow <jbrassow(a)redhat.com>
AuthorDate: Mon Oct 15 15:09:05 2012 -0500
Committer: Jonathan Brassow <jbrassow(a)redhat.com>
CommitterDate: Mon Oct 15 15:09:05 2012 -0500
Clean-up: Adjust message to be clearer on action taken and why
A message is printed when the region_size of a RAID LV is adjusted
to allow for large (> ~1TB) LVs. The message wasn't very clear.
Hopefully, this is better.
---
lib/metadata/lv_manip.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c
index d469fe8..5f006ab 100644
--- a/lib/metadata/lv_manip.c
+++ b/lib/metadata/lv_manip.c
@@ -2668,8 +2668,9 @@ static int _lv_extend_layered_lv(struct alloc_handle *ah,
*/
while (seg_is_raid(seg) && (seg->region_size < (lv->size / (1 << 21)))) {
seg->region_size *= 2;
- log_very_verbose("Forced to adjust RAID region_size to %uS",
- seg->region_size);
+ log_very_verbose("Adjusting RAID region_size from %uS to %uS"
+ " to support large LV size",
+ seg->region_size/2, seg->region_size);
}
return 1;
11 years, 6 months
master - release: prepare for release
by Alasdair Kergon
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=ea6a8078b41df7...
Commit: ea6a8078b41df75344aecff4c54aab9c78b67193
Parent: 5afa2ffcaaa69925673b1c0c82ebb3c1f66b1906
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: Mon Oct 15 15:19:32 2012 +0100
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: Mon Oct 15 15:19:32 2012 +0100
release: prepare for release
---
VERSION | 2 +-
VERSION_DM | 2 +-
WHATS_NEW | 41 ++++++++++++++++++++++++-----------------
WHATS_NEW_DM | 6 +++---
tools/lvcreate.c | 12 +++++-------
5 files changed, 34 insertions(+), 29 deletions(-)
diff --git a/VERSION b/VERSION
index 33b5cee..246867e 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.02.98(2)-git (2012-08-24)
+2.02.98(2)-git (2012-10-15)
diff --git a/VERSION_DM b/VERSION_DM
index 171ac28..bb267d5 100644
--- a/VERSION_DM
+++ b/VERSION_DM
@@ -1 +1 @@
-1.02.77-git (2012-08-24)
+1.02.77-git (2012-10-15)
diff --git a/WHATS_NEW b/WHATS_NEW
index b2b7c35..c0ae3df 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,11 +1,12 @@
-Version 2.02.98 -
-=================================
+Version 2.02.98 - 15th October 2012
+===================================
+ Switch from DEBUG() to DEBUGLOG() in lvmetad as -DDEBUG is already used.
Prohibit not yet supported change of thin-pool to read-only.
Support creation of read-only thin volumes (lvcreate -p r).
Using autoextend percent 0 for thin pool fails 'lvextend --use-policies'.
- Introduce blkdeactivate script.
- Implement devices/global_filter (affects lvmetad).
- Make vgscan --cache an alias to pvscan --cache.
+ Introduce blkdeactivate script to deactivate block devs with dependencies.
+ Implement devices/global_filter to hide devices from lvmetad.
+ Make vgscan --cache an alias for pvscan --cache.
Clear lvmetad metadata/PV cache before a rescan.
Fix a segmentation fault upon receiving a corrupt lvmetad response.
Give inconsistent metadata warnings in pvscan --cache.
@@ -13,9 +14,9 @@ Version 2.02.98 -
Avoid overlapping locks that could cause a deadlock in lvmetad.
Fix memory leaks in libdaemon and lvmetad.
Optimize libdaemon logging for a fast no-output path.
- example.conf: Warn about running lvmetad with use_lvmetad = 0.
Only create lvmetad pidfile when running as a daemon (no -f).
Warn if lvmetad is running but disabled.
+ Warn about running lvmetad with use_lvmetad = 0 in example.conf.
Update lvmetad help output (flags and their meaning).
Make pvscan --cache read metadata from LVM1 PVs.
Make libdaemon buffer handling asymptotically more efficient.
@@ -31,25 +32,29 @@ Version 2.02.98 -
Remove pvscan --cache from lvm2-lvmetad init script.
Remove ExecStartPost with pvscan --cache from lvm2-lvmetad.service.
Report invalid percentage for property snap_percent of non-snaphot LVs.
- Disallow convertion of thins to mirrors.
+ Disallow conversion of thin LVs to mirrors.
Fix lvm2api data_percent reporting for thin volumes.
Do not allow RAID LVs in a clustered volume group.
- Update lvconvert to support stacking of devs for thin meta/data devs.
+ Add --discards to lvconvert.
+ Add --poolmetadata to lvconvert and support thin meta/data dev stacking.
Support changes of permissions for thin snapshot volumes.
Enhance insert_layer_for_lv() with recursive rename for _tdata LVs.
Skip building dm tree for thin pool when called with origin_only flag.
Add internal lv_rename_update() to rename LV without updating mda.
- Ensure descriptors 0,1,2 are always available.
- Use /proc/self/fd for closing openned descriptors.
+ Ensure descriptors 0,1,2 are always available, using /dev/null if necessary.
+ Use /proc/self/fd when available for closing opened descriptors efficiently.
Add missing pkg init with --enable-testing in configure.in (2.02.71).
Fix inability to create, extend or convert to a large (> 1TiB) RAID LV.
+ Split out daemon-io from daemon-shared and always build libdaemonclient.
+ Update lvmetad communications to cope with clients using different filters.
Add (p)artial attribute to lvs.
Don't try to issue discards to a missing PV to avoid segfault.
Clear LV_NOSYNCED flag when a RAID1 LV is converted to a linear LV.
Disallow RAID1 upconvert if the LV was created with --nosync.
Depend on systemd-udev-settle in units generated by activation generator.
- Fix vgchange -aay to activate proper logical volumes.
- Properly handle 'resync' of RAID LVs.
+ Fix vgchange -aay not to activate non-matching LVs that follow a matching LV.
+ Fix lvchange --resync for RAID LVs which had no effect.
+ Restructure mirror resync code.
Disallow addition of RAID images until the array is in-sync.
Fix RAID LV creation with '--test' so valid commands do not fail.
Add lvm_lv_rename() to lvm2api.
@@ -60,20 +65,22 @@ Version 2.02.98 -
Suppress non-essential stdout with -qq.
Switch non-essential log_print messages to log_print_unless_silent.
Use -q as short form of --quiet.
- Add RAID10 support.
+ Add RAID10 support (--type raid10).
Reuse _reload_lv() in more lvconvert functions.
+ Fix 32-bit device size arithmetic needing 64-bit casting throughout tree.
+ Remove numerous unnecessary #includes and the empty util.c.
Fix dereference of NULL in lvmetad error path logging.
Fix buffer memory leak in lvmetad logging.
- Use 'ignore' discards for thin metadata created with older versions.
- Use proper condition to check for unsupported discards settings.
- Update lvs manpage with discards (2.02.97).
Add support for lvcreate --discards.
+ Correct the discards field in the lvs manpage (2.02.97).
+ Use proper condition to check for discards settings unsupported by kernel.
+ Reinstate correct default to ignore discards for thin metadata from old tools.
+ Issue error message when -i and -m args do not match specified RAID type.
Change lvmetad logging syntax from -ddd to -l {all|wire|debug}.
Add new libdaemon logging infrastructure.
Version 2.02.97 - 7th August 2012
=================================
- Issue error message when arguments do not match specified RAID type.
Improve documention of allocation policies in lvm.8.
Increase limit for major:minor to 4095:1048575 when using -My option.
Add make install_systemd_generators.
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 342605f..2d0b05c 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,12 +1,12 @@
-Version 1.02.77 -
-=================================
+Version 1.02.77 - 15th October 2012
+===================================
Support unmount of thin volumes from pool above thin pool threshold.
Update man page to reflect that dm UUIDs are being mangled as well.
Apply 'dmsetup mangle' for dm UUIDs besides dm names.
Add 'mangled_uuid' and 'unmangled_uuid' fields to dmsetup info -c -o.
Mangle device UUID on dm_task_set_uuid/newuuid call if necessary.
Add dm_task_get_uuid_mangled/unmangled to libdevmapper.
- Always reset delay_resume_if_new flag when stacking thin pool.
+ Always reset delay_resume_if_new flag when stacking thin pool over anything.
Don't create value for dm_config_node and require dm_config_create_value call.
Check for existing new_name for dmsetup rename.
Fix memory leak in dmsetup _get_split_name() error path.
diff --git a/tools/lvcreate.c b/tools/lvcreate.c
index 55b6a2c..3ea8f46 100644
--- a/tools/lvcreate.c
+++ b/tools/lvcreate.c
@@ -819,9 +819,9 @@ static int _lvcreate_params(struct lvcreate_params *lp,
!_read_raid_params(lp, cmd))
return_0;
- if (lp->create_thin_pool) {
+ if (lp->create_thin_pool)
lp->discards = (thin_discards_t) arg_uint_value(cmd, discards_ARG, THIN_DISCARDS_PASSDOWN);
- } else if (arg_count(cmd, discards_ARG)) {
+ else if (arg_count(cmd, discards_ARG)) {
log_error("--discards is only available for thin pool creation.");
return 0;
}
@@ -872,11 +872,9 @@ static int _lvcreate_params(struct lvcreate_params *lp,
if (!lp->thin && lp->snapshot && !(lp->segtype = get_segtype_from_string(cmd, "snapshot")))
return_0;
- } else {
- if (arg_count(cmd, chunksize_ARG)) {
- log_error("-c is only available with snapshots and thin pools");
- return 0;
- }
+ } else if (arg_count(cmd, chunksize_ARG)) {
+ log_error("-c is only available with snapshots and thin pools");
+ return 0;
}
/*
11 years, 6 months
master - scripts: blk-availability - use full name for clarity
by Peter Rajnoha
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=5afa2ffcaaa699...
Commit: 5afa2ffcaaa69925673b1c0c82ebb3c1f66b1906
Parent: 3ff080c59190caa6f5002d73f4da63b7e4e39620
Author: Peter Rajnoha <prajnoha(a)redhat.com>
AuthorDate: Mon Oct 15 16:10:58 2012 +0200
Committer: Peter Rajnoha <prajnoha(a)redhat.com>
CommitterDate: Mon Oct 15 16:10:58 2012 +0200
scripts: blk-availability - use full name for clarity
"Stopping blk-availability" -> "Stopping block device availability:"
---
scripts/blk_availability_init_red_hat.in | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/blk_availability_init_red_hat.in b/scripts/blk_availability_init_red_hat.in
index 60dd240..5638def 100644
--- a/scripts/blk_availability_init_red_hat.in
+++ b/scripts/blk_availability_init_red_hat.in
@@ -46,7 +46,7 @@ case "$1" in
;;
stop)
- action "Stopping blk-availability" $sbindir/$script $options
+ action "Stopping block device availability:" $sbindir/$script $options
rm -f $LOCK_FILE
;;
11 years, 6 months
master - libdm: fix comments in libdevmapper.h
by Peter Rajnoha
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=3ff080c59190ca...
Commit: 3ff080c59190caa6f5002d73f4da63b7e4e39620
Parent: 8290de964fbf0e6dcb9622f2e234a1bd794ea2e2
Author: Peter Rajnoha <prajnoha(a)redhat.com>
AuthorDate: Mon Oct 15 15:40:37 2012 +0200
Committer: Peter Rajnoha <prajnoha(a)redhat.com>
CommitterDate: Mon Oct 15 15:40:37 2012 +0200
libdm: fix comments in libdevmapper.h
---
libdm/libdevmapper.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libdm/libdevmapper.h b/libdm/libdevmapper.h
index 70862f3..c853ab4 100644
--- a/libdm/libdevmapper.h
+++ b/libdm/libdevmapper.h
@@ -168,10 +168,10 @@ int dm_task_get_info(struct dm_task *dmt, struct dm_info *dmi);
/*
* This function returns dm device's UUID based on the value
* of the mangling mode set during preceding dm_task_run call:
- * - unmangled name for DM_STRING_MANGLING_{AUTO, HEX},
- * - name without any changes for DM_STRING_MANGLING_NONE.
+ * - unmangled UUID for DM_STRING_MANGLING_{AUTO, HEX},
+ * - UUID without any changes for DM_STRING_MANGLING_NONE.
*
- * To get mangled or unmangled form of the name directly, use
+ * To get mangled or unmangled form of the UUID directly, use
* dm_task_get_uuid_mangled or dm_task_get_uuid_unmangled function.
*/
const char *dm_task_get_uuid(const struct dm_task *dmt);
11 years, 6 months
master - lvmetad: rename DEBUG() to DEBUGLOG()
by Alasdair Kergon
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=8290de964fbf0e...
Commit: 8290de964fbf0e6dcb9622f2e234a1bd794ea2e2
Parent: 895ee616425215136ec346d4637d2887add27913
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: Mon Oct 15 14:20:11 2012 +0100
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: Mon Oct 15 14:20:11 2012 +0100
lvmetad: rename DEBUG() to DEBUGLOG()
DEBUG is already defined by -DDEBUG
---
daemons/lvmetad/lvmetad-core.c | 42 ++++++++++++++++++++--------------------
libdaemon/server/daemon-log.h | 9 +------
2 files changed, 23 insertions(+), 28 deletions(-)
diff --git a/daemons/lvmetad/lvmetad-core.c b/daemons/lvmetad/lvmetad-core.c
index ebb8bc3..0a1c884 100644
--- a/daemons/lvmetad/lvmetad-core.c
+++ b/daemons/lvmetad/lvmetad-core.c
@@ -139,7 +139,7 @@ static struct dm_config_tree *lock_vg(lvmetad_state *s, const char *id) {
/* We never remove items from s->lock.vg => the pointer remains valid. */
pthread_mutex_unlock(&s->lock.vg_lock_map);
- DEBUG(s, "locking VG %s", id);
+ DEBUGLOG(s, "locking VG %s", id);
pthread_mutex_lock(vg);
/* Protect against structure changes of the vgid_to_metadata hash. */
@@ -152,7 +152,7 @@ static struct dm_config_tree *lock_vg(lvmetad_state *s, const char *id) {
static void unlock_vg(lvmetad_state *s, const char *id) {
pthread_mutex_t *vg;
- DEBUG(s, "unlocking VG %s", id);
+ DEBUGLOG(s, "unlocking VG %s", id);
/* Protect the s->lock.vg structure from concurrent access. */
pthread_mutex_lock(&s->lock.vg_lock_map);
if ((vg = dm_hash_lookup(s->lock.vg, id)))
@@ -437,7 +437,7 @@ static response vg_lookup(lvmetad_state *s, request r)
buffer_init( &res.buffer );
- DEBUG(s, "vg_lookup: uuid = %s, name = %s", uuid, name);
+ DEBUGLOG(s, "vg_lookup: uuid = %s, name = %s", uuid, name);
if (!uuid || !name) {
lock_vgid_to_metadata(s);
@@ -448,7 +448,7 @@ static response vg_lookup(lvmetad_state *s, request r)
unlock_vgid_to_metadata(s);
}
- DEBUG(s, "vg_lookup: updated uuid = %s, name = %s", uuid, name);
+ DEBUGLOG(s, "vg_lookup: updated uuid = %s, name = %s", uuid, name);
if (!uuid)
return reply_unknown("VG not found");
@@ -533,7 +533,7 @@ static int compare_config(struct dm_config_node *a, struct dm_config_node *b)
result = compare_config(a->child, b->child);
if (result) {
- // DEBUG("config inequality at %s / %s", a->key, b->key);
+ // DEBUGLOG("config inequality at %s / %s", a->key, b->key);
return result;
}
@@ -579,7 +579,7 @@ static int update_pvid_to_vgid(lvmetad_state *s, struct dm_config_tree *vg,
if (!dm_hash_insert(s->pvid_to_vgid, pvid, (void*) vgid))
goto out;
- DEBUG(s, "moving PV %s to VG %s", pvid, vgid);
+ DEBUGLOG(s, "moving PV %s to VG %s", pvid, vgid);
}
for (n = dm_hash_get_first(to_check); n;
@@ -649,7 +649,7 @@ static int vg_remove_if_missing(lvmetad_state *s, const char *vgid)
}
if (missing) {
- DEBUG(s, "removing empty VG %s", vgid);
+ DEBUGLOG(s, "removing empty VG %s", vgid);
remove_metadata(s, vgid, 0);
}
@@ -702,17 +702,17 @@ static int update_metadata(lvmetad_state *s, const char *name, const char *_vgid
retval = 1;
if (compare_config(metadata, old->root))
retval = 0;
- DEBUG(s, "Not updating metadata for %s at %d (%s)", _vgid, haveseq,
+ DEBUGLOG(s, "Not updating metadata for %s at %d (%s)", _vgid, haveseq,
retval ? "ok" : "MISMATCH");
if (!retval) {
- DEBUG_cft(s, "OLD: ", old->root);
- DEBUG_cft(s, "NEW: ", metadata);
+ DEBUGLOG_cft(s, "OLD: ", old->root);
+ DEBUGLOG_cft(s, "NEW: ", metadata);
}
goto out;
}
if (seq < haveseq) {
- DEBUG(s, "Refusing to update metadata for %s (at %d) to %d", _vgid, haveseq, seq);
+ DEBUGLOG(s, "Refusing to update metadata for %s (at %d) to %d", _vgid, haveseq, seq);
/* TODO: notify the client that their metadata is out of date? */
retval = 1;
goto out;
@@ -727,7 +727,7 @@ static int update_metadata(lvmetad_state *s, const char *name, const char *_vgid
vgid = dm_config_find_str(cft->root, "metadata/id", NULL);
if (!vgid || !name) {
- DEBUG(s, "Name '%s' or uuid '%s' missing!", name, vgid);
+ DEBUGLOG(s, "Name '%s' or uuid '%s' missing!", name, vgid);
goto out;
}
@@ -740,7 +740,7 @@ static int update_metadata(lvmetad_state *s, const char *name, const char *_vgid
}
lock_vgid_to_metadata(s);
- DEBUG(s, "Mapping %s to %s", vgid, name);
+ DEBUGLOG(s, "Mapping %s to %s", vgid, name);
retval = ((cfgname = dm_pool_strdup(dm_config_memory(cft), name)) &&
dm_hash_insert(s->vgid_to_metadata, vgid, cft) &&
@@ -767,7 +767,7 @@ static response pv_gone(lvmetad_state *s, request r)
struct dm_config_tree *pvmeta;
char *pvid_old;
- DEBUG(s, "pv_gone: %s / %" PRIu64, pvid, device);
+ DEBUGLOG(s, "pv_gone: %s / %" PRIu64, pvid, device);
lock_pvid_to_pvmeta(s);
if (!pvid && device > 0)
@@ -777,7 +777,7 @@ static response pv_gone(lvmetad_state *s, request r)
return reply_unknown("device not in cache");
}
- DEBUG(s, "pv_gone (updated): %s / %" PRIu64, pvid, device);
+ DEBUGLOG(s, "pv_gone (updated): %s / %" PRIu64, pvid, device);
pvmeta = dm_hash_lookup(s->pvid_to_pvmeta, pvid);
pvid_old = dm_hash_lookup_binary(s->device_to_pvid, &device, sizeof(device));
@@ -798,7 +798,7 @@ static response pv_gone(lvmetad_state *s, request r)
static response pv_clear_all(lvmetad_state *s, request r)
{
- DEBUG(s, "pv_clear_all");
+ DEBUGLOG(s, "pv_clear_all");
lock_pvid_to_pvmeta(s);
lock_vgid_to_metadata(s);
@@ -844,7 +844,7 @@ static response pv_found(lvmetad_state *s, request r)
}
pvmeta_old_pvid = dm_hash_lookup(s->pvid_to_pvmeta, pvid);
- DEBUG(s, "pv_found %s, vgid = %s, device = %" PRIu64 ", old = %s", pvid, vgid, device, old);
+ DEBUGLOG(s, "pv_found %s, vgid = %s, device = %" PRIu64 ", old = %s", pvid, vgid, device, old);
dm_free(old);
@@ -870,7 +870,7 @@ static response pv_found(lvmetad_state *s, request r)
if (metadata) {
if (!vgid)
return reply_fail("need VG UUID");
- DEBUG(s, "obtained vgid = %s, vgname = %s", vgid, vgname);
+ DEBUGLOG(s, "obtained vgid = %s, vgname = %s", vgid, vgname);
if (!vgname)
return reply_fail("need VG name");
if (daemon_request_int(r, "metadata/seqno", -1) < 0)
@@ -934,7 +934,7 @@ static response vg_remove(lvmetad_state *s, request r)
if (!vgid)
return reply_fail("need VG UUID");
- DEBUG(s, "vg_remove: %s", vgid);
+ DEBUGLOG(s, "vg_remove: %s", vgid);
lock_pvid_to_vgid(s);
remove_metadata(s, vgid, 1);
@@ -1101,7 +1101,7 @@ static int init(daemon_state *s)
if (!daemon_log_parse(ls->log, DAEMON_LOG_OUTLET_STDERR, ls->log_config, 1))
return 0;
- DEBUG(s, "initialised state: vgid_to_metadata = %p", ls->vgid_to_metadata);
+ DEBUGLOG(s, "initialised state: vgid_to_metadata = %p", ls->vgid_to_metadata);
if (!ls->pvid_to_vgid || !ls->vgid_to_metadata)
return 0;
@@ -1116,7 +1116,7 @@ static int fini(daemon_state *s)
lvmetad_state *ls = s->private;
struct dm_hash_node *n;
- DEBUG(s, "fini");
+ DEBUGLOG(s, "fini");
destroy_metadata_hashes(ls);
diff --git a/libdaemon/server/daemon-log.h b/libdaemon/server/daemon-log.h
index f09fc2a..e2e11c5 100644
--- a/libdaemon/server/daemon-log.h
+++ b/libdaemon/server/daemon-log.h
@@ -23,13 +23,8 @@ enum { DAEMON_LOG_FATAL = 0 /* usually preceding daemon death */
, DAEMON_LOG_DEBUG = 5 /* unsorted debug stuff */
};
-/*
- * FIXME: We are currently compiling with -DDEBUG
- * so this define DEBUG collision needs fixing
- */
-#undef DEBUG
-#define DEBUG(s, x...) daemon_logf((s)->log, DAEMON_LOG_DEBUG, x)
-#define DEBUG_cft(s, i, n) daemon_log_cft((s)->log, DAEMON_LOG_DEBUG, i, n)
+#define DEBUGLOG(s, x...) daemon_logf((s)->log, DAEMON_LOG_DEBUG, x)
+#define DEBUGLOG_cft(s, i, n) daemon_log_cft((s)->log, DAEMON_LOG_DEBUG, i, n)
#define WARN(s, x...) daemon_logf((s)->log, DAEMON_LOG_WARN, x)
#define INFO(s, x...) daemon_logf((s)->log, DAEMON_LOG_INFO, x)
#define ERROR(s, x...) daemon_logf((s)->log, DAEMON_LOG_ERROR, x)
11 years, 6 months
master - Makefiles: fix distclean dir dependency
by Alasdair Kergon
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=895ee616425215...
Commit: 895ee616425215136ec346d4637d2887add27913
Parent: d365bfe7e96b23297d3aac3485f98998bb220613
Author: Alasdair G Kergon <agk(a)redhat.com>
AuthorDate: Mon Oct 15 14:15:59 2012 +0100
Committer: Alasdair G Kergon <agk(a)redhat.com>
CommitterDate: Mon Oct 15 14:15:59 2012 +0100
Makefiles: fix distclean dir dependency
test distclean uses tools so must distclean tools after test
---
Makefile.in | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile.in b/Makefile.in
index bbfcf2c..4d39577 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -44,6 +44,7 @@ ifeq ($(MAKECMDGOALS),distclean)
libdaemon lib tools daemons libdm \
udev po liblvm python \
unit-tests/datastruct unit-tests/mm unit-tests/regex
+tools.distclean: test.distclean
endif
DISTCLEAN_DIRS += lcov_reports*
DISTCLEAN_TARGETS += config.cache config.log config.status make.tmpl
11 years, 6 months
master - scripts: blk-availability should be stopped before FCoE
by Peter Rajnoha
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=d365bfe7e96b23...
Commit: d365bfe7e96b23297d3aac3485f98998bb220613
Parent: d864c6eacd3e2f40034eb583cb2df9fa7c72efbe
Author: Peter Rajnoha <prajnoha(a)redhat.com>
AuthorDate: Mon Oct 15 14:50:17 2012 +0200
Committer: Peter Rajnoha <prajnoha(a)redhat.com>
CommitterDate: Mon Oct 15 15:00:12 2012 +0200
scripts: blk-availability should be stopped before FCoE
---
scripts/blk_availability_init_red_hat.in | 2 +-
.../blk_availability_systemd_red_hat.service.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/blk_availability_init_red_hat.in b/scripts/blk_availability_init_red_hat.in
index 618f3d3..60dd240 100644
--- a/scripts/blk_availability_init_red_hat.in
+++ b/scripts/blk_availability_init_red_hat.in
@@ -15,7 +15,7 @@
# devices that were created using the -m option of lvcreate.
#
#
-# chkconfig: 12345 10 80
+# chkconfig: 12345 25 75
# description: Controls availability of block devices
#
# For Red-Hat-based distributions such as Fedora, RHEL, CentOS.
diff --git a/scripts/blk_availability_systemd_red_hat.service.in b/scripts/blk_availability_systemd_red_hat.service.in
index fef919b..9c1cb78 100644
--- a/scripts/blk_availability_systemd_red_hat.service.in
+++ b/scripts/blk_availability_systemd_red_hat.service.in
@@ -1,6 +1,6 @@
[Unit]
Description=Availability of block devices
-After=lvm2-activation.service lvm2-lvmetad.service iscsi.service iscsid.service
+After=lvm2-activation.service lvm2-lvmetad.service iscsi.service iscsid.service fcoe.service
DefaultDependencies=no
Conflicts=shutdown.target
11 years, 6 months
master - test: resync is for mirror devices
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=d864c6eacd3e2f...
Commit: d864c6eacd3e2f40034eb583cb2df9fa7c72efbe
Parent: 457387718600579b862fe940c9a9daea3da59141
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Mon Oct 15 14:31:41 2012 +0200
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Mon Oct 15 14:31:41 2012 +0200
test: resync is for mirror devices
---
test/shell/covercmd.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/test/shell/covercmd.sh b/test/shell/covercmd.sh
index 12d9be1..b77d378 100644
--- a/test/shell/covercmd.sh
+++ b/test/shell/covercmd.sh
@@ -79,7 +79,7 @@ for i in dumpconfig formats segtypes; do
done
for i in pr "p rw" an ay "-monitor y" "-monitor n" \
- -resync -refresh "-addtag MYTAG" "-deltag MYETAG"; do
+ -refresh "-addtag MYTAG" "-deltag MYETAG"; do
lvchange -$i $vg/$lv
done
11 years, 6 months
master - lvchange: resync returns error on usupported volumes
by Zdenek Kabelac
Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=45738771860057...
Commit: 457387718600579b862fe940c9a9daea3da59141
Parent: b3899056d94d14eaa80c49e4a5a52c8e7865f08a
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Mon Oct 15 13:42:18 2012 +0200
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Mon Oct 15 14:09:37 2012 +0200
lvchange: resync returns error on usupported volumes
---
tools/lvchange.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/lvchange.c b/tools/lvchange.c
index 85253ef..04facdd 100644
--- a/tools/lvchange.c
+++ b/tools/lvchange.c
@@ -343,7 +343,7 @@ static int lvchange_resync(struct cmd_context *cmd,
if (!(lv->status & MIRRORED) && !seg_is_raid(seg)) {
log_error("Unable to resync %s. It is not RAID or mirrored.",
lv->name);
- return 1;
+ return 0;
}
if (lv->status & PVMOVE) {
11 years, 6 months
