April 2016 - lvm2-commits - Fedora mailing-lists

master - cleanup: gcc warn about comparing int with uint
by Zdenek Kabelac 12 Apr '16

12 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=1be74cfd7f948123… Commit: 1be74cfd7f948123544872abb5e80994182e04d8 Parent: 0f7975cb351158d3b2245b4262761a698c6c5d7b Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Tue Apr 12 11:47:21 2016 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Tue Apr 12 11:47:51 2016 +0200 cleanup: gcc warn about comparing int with uint --- .../dmeventd/plugins/snapshot/dmeventd_snapshot.c | 4 ++-- lib/activate/dev_manager.c | 2 +- libdm/ioctl/libdm-iface.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/daemons/dmeventd/plugins/snapshot/dmeventd_snapshot.c b/daemons/dmeventd/plugins/snapshot/dmeventd_snapshot.c index 26fdfed..7b060ed 100644 --- a/daemons/dmeventd/plugins/snapshot/dmeventd_snapshot.c +++ b/daemons/dmeventd/plugins/snapshot/dmeventd_snapshot.c @@ -148,8 +148,8 @@ static void _umount(const char *device, int major, int minor) continue; /* can't stat, skip this one */ if (S_ISBLK(st.st_mode) && - major(st.st_rdev) == major && - minor(st.st_rdev) == minor) { + (int) major(st.st_rdev) == major && + (int) minor(st.st_rdev) == minor) { log_error("Unmounting invalid snapshot %s from %s.", device, words[1]); if (!_run(UMOUNT_COMMAND, "-fl", words[1], NULL)) log_error("Failed to umount snapshot %s from %s: %s.", diff --git a/lib/activate/dev_manager.c b/lib/activate/dev_manager.c index 3f91654..a0e05ad 100644 --- a/lib/activate/dev_manager.c +++ b/lib/activate/dev_manager.c @@ -1687,7 +1687,7 @@ static int _add_dev_to_dtree(struct dev_manager *dm, struct dm_tree *dtree, /* * FIXME compare info.major with lv->major if multiple major support */ - if (info.exists && (info.minor != lv->minor)) { + if (info.exists && ((int) info.minor != lv->minor)) { log_error("Volume %s (%" PRIu32 ":%" PRIu32")" " differs from already active device " "(%" PRIu32 ":%" PRIu32")", diff --git a/libdm/ioctl/libdm-iface.c b/libdm/ioctl/libdm-iface.c index 2733b86..0c798f5 100644 --- a/libdm/ioctl/libdm-iface.c +++ b/libdm/ioctl/libdm-iface.c @@ -1169,9 +1169,9 @@ static struct dm_ioctl *_flatten(struct dm_task *dmt, unsigned repeat_count) } if (!_dm_multiple_major_support && dmt->allow_default_major_fallback && - dmt->major != _dm_device_major) { - log_verbose("Overriding major number of %" PRIu32 - " with %" PRIu32 " for persistent device.", + dmt->major != (int) _dm_device_major) { + log_verbose("Overriding major number of %d " + "with %u for persistent device.", dmt->major, _dm_device_major); dmt->major = _dm_device_major; }

1 0

master - cleanup: avoid declaring var in the middle of code
by Zdenek Kabelac 12 Apr '16

12 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=0f7975cb351158d3… Commit: 0f7975cb351158d3b2245b4262761a698c6c5d7b Parent: 147c9c01a21687b82314a62571cfc390a9a606a8 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Tue Apr 12 11:46:41 2016 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Tue Apr 12 11:47:51 2016 +0200 cleanup: avoid declaring var in the middle of code Easier to read code. --- lib/device/dev-cache.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/device/dev-cache.c b/lib/device/dev-cache.c index 6abb6a7..b5f2152 100644 --- a/lib/device/dev-cache.c +++ b/lib/device/dev-cache.c @@ -904,11 +904,11 @@ int dev_cache_index_devs(void) } else if (!sysfs_has_dev_block) return 1; - int with_udev = obtain_device_list_from_udev() && - udev_get_library_context(); + if (obtain_device_list_from_udev() && + udev_get_library_context()) + return _dev_cache_iterate_devs_for_index(); /* with udev */ - return with_udev ? _dev_cache_iterate_devs_for_index() - : _dev_cache_iterate_sysfs_for_index(path); + return _dev_cache_iterate_sysfs_for_index(path); } #ifdef UDEV_SYNC_SUPPORT

1 0

master - rename function read_vgname to read_vgsummary
by David Teigland 11 Apr '16

11 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=147c9c01a21687b8… Commit: 147c9c01a21687b82314a62571cfc390a9a606a8 Parent: fe65a86cbc98bb38014b238266a7732de42d0aa1 Author: David Teigland <teigland(a)redhat.com> AuthorDate: Tue Feb 9 13:32:26 2016 -0600 Committer: David Teigland <teigland(a)redhat.com> CommitterDate: Mon Apr 11 13:07:48 2016 -0500 rename function read_vgname to read_vgsummary The name did not clearly represent what it does. --- lib/format_text/format-text.c | 2 +- lib/format_text/import-export.h | 8 ++++---- lib/format_text/import.c | 4 ++-- lib/format_text/import_vsn1.c | 12 ++++++++---- 4 files changed, 15 insertions(+), 11 deletions(-) diff --git a/lib/format_text/format-text.c b/lib/format_text/format-text.c index 408e63c..6053610 100644 --- a/lib/format_text/format-text.c +++ b/lib/format_text/format-text.c @@ -1210,7 +1210,7 @@ int vgname_from_mda(const struct format_type *fmt, used_cached_metadata = 1; /* FIXME 64-bit */ - if (!text_vgname_import(fmt, dev_area->dev, + if (!text_vgsummary_import(fmt, dev_area->dev, (off_t) (dev_area->start + rlocn->offset), (uint32_t) (rlocn->size - wrap), (off_t) (dev_area->start + MDA_HEADER_SIZE), diff --git a/lib/format_text/import-export.h b/lib/format_text/import-export.h index 074b118..c081c51 100644 --- a/lib/format_text/import-export.h +++ b/lib/format_text/import-export.h @@ -51,9 +51,9 @@ struct text_vg_version_ops { unsigned allow_lvmetad_extensions); void (*read_desc) (struct dm_pool * mem, const struct dm_config_tree *cf, time_t *when, char **desc); - int (*read_vgname) (const struct format_type *fmt, - const struct dm_config_tree *cft, - struct lvmcache_vgsummary *vgsummary); + int (*read_vgsummary) (const struct format_type *fmt, + const struct dm_config_tree *cft, + struct lvmcache_vgsummary *vgsummary); }; struct text_vg_version_ops *text_vg_vsn1_init(void); @@ -78,7 +78,7 @@ struct volume_group *text_vg_import_fd(struct format_instance *fid, uint32_t checksum, time_t *when, char **desc); -int text_vgname_import(const struct format_type *fmt, +int text_vgsummary_import(const struct format_type *fmt, struct device *dev, off_t offset, uint32_t size, off_t offset2, uint32_t size2, diff --git a/lib/format_text/import.c b/lib/format_text/import.c index 5b4f4a9..629884b 100644 --- a/lib/format_text/import.c +++ b/lib/format_text/import.c @@ -35,7 +35,7 @@ static void _init_text_import(void) /* * Find out vgname on a given device. */ -int text_vgname_import(const struct format_type *fmt, +int text_vgsummary_import(const struct format_type *fmt, struct device *dev, off_t offset, uint32_t size, off_t offset2, uint32_t size2, @@ -74,7 +74,7 @@ int text_vgname_import(const struct format_type *fmt, if (!(*vsn)->check_version(cft)) continue; - if (!(*vsn)->read_vgname(fmt, cft, vgsummary)) + if (!(*vsn)->read_vgsummary(fmt, cft, vgsummary)) goto_out; r = 1; diff --git a/lib/format_text/import_vsn1.c b/lib/format_text/import_vsn1.c index 3bf5f7b..22f519e 100644 --- a/lib/format_text/import_vsn1.c +++ b/lib/format_text/import_vsn1.c @@ -1229,12 +1229,16 @@ static void _read_desc(struct dm_pool *mem, } /* - * It would be more accurate to call this _read_vgsummary(). * It is used to read vgsummary information about a VG * before locking and reading the VG via vg_read(). + * read_vgsummary: read VG metadata before VG is locked + * and save the data in struct vgsummary + * read_vg: read VG metadata after VG is locked + * and save the data in struct volume_group + * FIXME: why are these separate? */ -static int _read_vgname(const struct format_type *fmt, const struct dm_config_tree *cft, - struct lvmcache_vgsummary *vgsummary) +static int _read_vgsummary(const struct format_type *fmt, const struct dm_config_tree *cft, + struct lvmcache_vgsummary *vgsummary) { const struct dm_config_node *vgn; struct dm_pool *mem = fmt->cmd->mem; @@ -1285,7 +1289,7 @@ static struct text_vg_version_ops _vsn1_ops = { .check_version = _vsn1_check_version, .read_vg = _read_vg, .read_desc = _read_desc, - .read_vgname = _read_vgname, + .read_vgsummary = _read_vgsummary }; struct text_vg_version_ops *text_vg_vsn1_init(void)

1 0

master - devcache: do not insert devices without device node
by Zdenek Kabelac 11 Apr '16

11 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=fe65a86cbc98bb38… Commit: fe65a86cbc98bb38014b238266a7732de42d0aa1 Parent: 07a60b59f789e089761170f977defbd38defacef Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Mon Apr 11 10:08:16 2016 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Mon Apr 11 10:33:14 2016 +0200 devcache: do not insert devices without device node When not obtaining device from udev, we are doing deep devdir scan, and at the same time we try to insert everything what /sys/dev/block knows about. However in case lvm2 is configured to use nonstardard devdir this way it will see (and scan) devices from a real system. lvm2 test suite is using its own test devdir with its own device nodes. To avoid touching real /dev devices, validate the device node exist in give dir and do not insert such device into a cache. With obtain list from udev this patch has no effect (the normal user path). --- WHATS_NEW | 1 + lib/device/dev-cache.c | 9 +++++++++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 777c44e..f4eb6ad 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.151 ================================= + When not obtaining devs from udev, check they exist before caching them. Detect device mismatch also when compiling without udev support. Version 2.02.150 - 9th April 2016 diff --git a/lib/device/dev-cache.c b/lib/device/dev-cache.c index 84471ab..6abb6a7 100644 --- a/lib/device/dev-cache.c +++ b/lib/device/dev-cache.c @@ -433,6 +433,8 @@ static struct dm_list *_get_or_add_list_by_index_key(struct dm_hash_table *idx, static struct device *_insert_sysfs_dev(dev_t devno, const char *devname) { + static struct device _fake_dev = { .flags = DEV_USED_FOR_LV }; + struct stat stat0; char path[PATH_MAX]; char *path_copy; struct device *dev; @@ -442,6 +444,13 @@ static struct device *_insert_sysfs_dev(dev_t devno, const char *devname) return NULL; } + if (lstat(path, &stat0) < 0) { + /* When device node does not exist return fake entry. + * This may happen when i.e. lvm2 device dir != /dev */ + log_debug("%s: Not available device node", path); + return &_fake_dev; + } + if (!(dev = _dev_create(devno))) return_NULL;

1 0

master - devcache: index devices also without udev
by Zdenek Kabelac 11 Apr '16

11 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=07a60b59f789e089… Commit: 07a60b59f789e089761170f977defbd38defacef Parent: 9e14abb887c5ac2a5a7446d08eb878a22eade051 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Mon Apr 11 10:23:16 2016 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Mon Apr 11 10:32:19 2016 +0200 devcache: index devices also without udev We have _insert_dirs() for udev and non-udev compilation. Compiling without udev missed to call dev_cache_index_devs(). Move the call after _insert_dirs() call so both compilation gets it. --- WHATS_NEW | 4 ++++ lib/device/dev-cache.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index bf2972f..777c44e 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,3 +1,7 @@ +Version 2.02.151 +================================= + Detect device mismatch also when compiling without udev support. + Version 2.02.150 - 9th April 2016 ================================= Avoid using flushing dm status ioctl when checking for usable DM device. diff --git a/lib/device/dev-cache.c b/lib/device/dev-cache.c index 8461f40..84471ab 100644 --- a/lib/device/dev-cache.c +++ b/lib/device/dev-cache.c @@ -999,8 +999,6 @@ static void _insert_dirs(struct dm_list *dirs) log_debug_devs("%s: Failed to insert devices to " "device cache fully", dl->dir); } - - (void) dev_cache_index_devs(); } #else /* UDEV_SYNC_SUPPORT */ @@ -1074,6 +1072,8 @@ static void _full_scan(int dev_scan) _insert_dirs(&_cache.dirs); + (void) dev_cache_index_devs(); + dm_list_iterate_items(dl, &_cache.files) _insert_file(dl->dir);

1 0

v2_02_150 annotated tag has been created
by Alasdair Kergon 08 Apr '16

08 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=eadbe39b7a9017c6… Commit: eadbe39b7a9017c63cec232c2f62717048f551f1 Parent: 0000000000000000000000000000000000000000 Author: Alasdair G Kergon <agk(a)redhat.com> AuthorDate: 2016-04-09 01:09 +0000 Committer: Alasdair G Kergon <agk(a)redhat.com> CommitterDate: 2016-04-09 01:09 +0000 annotated tag: v2_02_150 has been created at eadbe39b7a9017c63cec232c2f62717048f551f1 (tag) tagging 3aab784aa5cbbe4f86cbc1c8a33579dc32c991eb (commit) replaces v2_02_149 Release 2.02.150 A small bug-fix release. 24 files changed, 262 insertions(+), 139 deletions(-) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iEYEABECAAYFAlcIVm4ACgkQIoGRwVZ+LBe1DQCgg02s7rQe1ll+DpzphKvqXTpw GQIAn3X5HiuGNflwPFs28bBd3RGyXqmd =FTsd -----END PGP SIGNATURE----- Alasdair G Kergon (6): post-release lvmdump: Allow dir to exist already if it is empty lvmdump: If dir exists check dir perms too. libdm: Correct typo. activation: Skip another non-prefixed info ioctl. pre-release Marian Csontos (1): test: Fix testing of installed lvmdbusd Peter Rajnoha (3): cleanup: use #define for field's quote and pair character and also for the error msg while extending output line cleanup: use common init/destroy_processing_handle in _report fn and cleanup error paths report: remove superfluous SEGSSTATUS report type Zdenek Kabelac (17): mirror: fix flushing for mirror target suspend: fix suspend with noflush limitation preload: preserve flushing state libdm: improve debug message with ioctl lvconvert: show percent with %.2 cleanup: indent tests: verify repair of failing mirror tests: do not break teardown on failing losetup WHATS_NEW: update lvcreate: %FREE -> %PVS activation: do not check for devs without LVM- tests: use mkfs.ext3 tests: require newer cache target dev_manager: device_is_usable does not flush cleanup: reuse _setup_task cleanup: simplier to read condition cleanup: avoid gcc warns

1 0

master - post-release
by Alasdair Kergon 08 Apr '16

08 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=9e14abb887c5ac2a… Commit: 9e14abb887c5ac2a5a7446d08eb878a22eade051 Parent: 3aab784aa5cbbe4f86cbc1c8a33579dc32c991eb Author: Alasdair G Kergon <agk(a)redhat.com> AuthorDate: Sat Apr 9 02:10:39 2016 +0100 Committer: Alasdair G Kergon <agk(a)redhat.com> CommitterDate: Sat Apr 9 02:10:39 2016 +0100 post-release --- VERSION | 2 +- VERSION_DM | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/VERSION b/VERSION index 78b4a66..4731ad0 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -2.02.150(2)-git (2016-04-09) +2.02.151(2)-git (2016-04-09) diff --git a/VERSION_DM b/VERSION_DM index 8eb5316..359ada7 100644 --- a/VERSION_DM +++ b/VERSION_DM @@ -1 +1 @@ -1.02.122-git (2016-04-09) +1.02.123-git (2016-04-09)

1 0

master - pre-release
by Alasdair Kergon 08 Apr '16

08 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=3aab784aa5cbbe4f… Commit: 3aab784aa5cbbe4f86cbc1c8a33579dc32c991eb Parent: af148a9d7715a8026d3d51a4c4c176bf59d3cc5f Author: Alasdair G Kergon <agk(a)redhat.com> AuthorDate: Sat Apr 9 02:08:44 2016 +0100 Committer: Alasdair G Kergon <agk(a)redhat.com> CommitterDate: Sat Apr 9 02:08:44 2016 +0100 pre-release --- VERSION | 2 +- VERSION_DM | 2 +- WHATS_NEW | 2 +- WHATS_NEW_DM | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/VERSION b/VERSION index 3a2d7d1..78b4a66 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -2.02.150(2)-git (2016-04-01) +2.02.150(2)-git (2016-04-09) diff --git a/VERSION_DM b/VERSION_DM index 77d3356..8eb5316 100644 --- a/VERSION_DM +++ b/VERSION_DM @@ -1 +1 @@ -1.02.122-git (2016-04-01) +1.02.122-git (2016-04-09) diff --git a/WHATS_NEW b/WHATS_NEW index 0fa9f50..bf2972f 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,4 +1,4 @@ -Version 2.02.150 - +Version 2.02.150 - 9th April 2016 ================================= Avoid using flushing dm status ioctl when checking for usable DM device. Check for devices without LVM- uuid prefix only with kernels < 3.X. diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM index 6bd857e..08d7d45 100644 --- a/WHATS_NEW_DM +++ b/WHATS_NEW_DM @@ -1,6 +1,6 @@ -Version 1.02.122 - -================================== - Improve log_debug ioctl bit attrs. +Version 1.02.122 - 9th April 2016 +================================= + Change log_debug ioctl flags from single characters into words. Version 1.02.121 - 26th March 2016 ==================================

1 0

master - cleanup: avoid gcc warns
by Zdenek Kabelac 08 Apr '16

08 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=af148a9d7715a802… Commit: af148a9d7715a8026d3d51a4c4c176bf59d3cc5f Parent: 5cfa6cb347c5b7d8c5e3119b59bc7331388cb47e Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Fri Apr 8 11:36:02 2016 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Fri Apr 8 20:20:16 2016 +0200 cleanup: avoid gcc warns Some older systems may had global declaration to cause gcc warning. Rename for cases we don't care... --- daemons/dmeventd/libdevmapper-event.c | 4 ++-- daemons/dmeventd/libdevmapper-event.h | 2 +- lib/cache/lvmcache.c | 2 +- lib/cache/lvmcache.h | 2 +- lib/metadata/metadata-exported.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/daemons/dmeventd/libdevmapper-event.c b/daemons/dmeventd/libdevmapper-event.c index 871c0d6..d395ed3 100644 --- a/daemons/dmeventd/libdevmapper-event.c +++ b/daemons/dmeventd/libdevmapper-event.c @@ -855,9 +855,9 @@ int dm_event_get_version(struct dm_event_fifos *fifos, int *version) { return 1; } -void dm_event_log_set(int debug_level, int use_syslog) +void dm_event_log_set(int debug_log_level, int use_syslog) { - _debug_level = debug_level; + _debug_level = debug_log_level; _use_syslog = use_syslog; } diff --git a/daemons/dmeventd/libdevmapper-event.h b/daemons/dmeventd/libdevmapper-event.h index f9fb442..4c97223 100644 --- a/daemons/dmeventd/libdevmapper-event.h +++ b/daemons/dmeventd/libdevmapper-event.h @@ -106,7 +106,7 @@ int dm_event_register_handler(const struct dm_event_handler *dmevh); int dm_event_unregister_handler(const struct dm_event_handler *dmevh); /* Set debug level for logging, and whether to log on stdout/stderr or syslog */ -void dm_event_log_set(int debug_level, int use_syslog); +void dm_event_log_set(int debug_log_level, int use_syslog); /* Log messages acroding to current debug level */ __attribute__((format(printf, 6, 0))) diff --git a/lib/cache/lvmcache.c b/lib/cache/lvmcache.c index b1e53e2..394745a 100644 --- a/lib/cache/lvmcache.c +++ b/lib/cache/lvmcache.c @@ -1133,7 +1133,7 @@ struct device *lvmcache_device_from_pvid(struct cmd_context *cmd, const struct i } const char *lvmcache_pvid_from_devname(struct cmd_context *cmd, - const char *devname) + const char *devname) { struct device *dev; struct label *label; diff --git a/lib/cache/lvmcache.h b/lib/cache/lvmcache.h index 9ca0379..0ebbe07 100644 --- a/lib/cache/lvmcache.h +++ b/lib/cache/lvmcache.h @@ -108,7 +108,7 @@ const char *lvmcache_vgid_from_vgname(struct cmd_context *cmd, const char *vgnam struct device *lvmcache_device_from_pvid(struct cmd_context *cmd, const struct id *pvid, unsigned *scan_done_once, uint64_t *label_sector); const char *lvmcache_pvid_from_devname(struct cmd_context *cmd, - const char *dev_name); + const char *devname); char *lvmcache_vgname_from_pvid(struct cmd_context *cmd, const char *pvid); const char *lvmcache_vgname_from_info(struct lvmcache_info *info); int lvmcache_vgs_locked(void); diff --git a/lib/metadata/metadata-exported.h b/lib/metadata/metadata-exported.h index ecca418..fb2ffa3 100644 --- a/lib/metadata/metadata-exported.h +++ b/lib/metadata/metadata-exported.h @@ -1061,7 +1061,7 @@ struct lv_segment *get_only_segment_using_this_lv(const struct logical_volume *l * Useful functions for managing snapshots. */ int lv_is_origin(const struct logical_volume *lv); -int lv_is_thin_origin(const struct logical_volume *lv, unsigned *snapshot_count); +int lv_is_thin_origin(const struct logical_volume *lv, unsigned *snap_count); int lv_is_cache_origin(const struct logical_volume *lv); int lv_is_cow(const struct logical_volume *lv); int lv_is_merging_cow(const struct logical_volume *cow);

1 0

master - cleanup: simplier to read condition
by Zdenek Kabelac 08 Apr '16

08 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=5cfa6cb347c5b7d8… Commit: 5cfa6cb347c5b7d8c5e3119b59bc7331388cb47e Parent: 74e704bb4465960b361711c890733cbae1f06e42 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Fri Apr 8 19:34:56 2016 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Fri Apr 8 20:20:16 2016 +0200 cleanup: simplier to read condition Make more readable what we are looking for and just test for KERNEL version at one place. --- lib/activate/dev_manager.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/activate/dev_manager.c b/lib/activate/dev_manager.c index 8c01b43..3f91654 100644 --- a/lib/activate/dev_manager.c +++ b/lib/activate/dev_manager.c @@ -669,14 +669,15 @@ static int _original_uuid_format_check_required(struct cmd_context *cmd) static int _kernel_major = 0; if (!_kernel_major) { - if ((sscanf(cmd->kernel_vsn, "%d", &_kernel_major) != 1)) - _kernel_major = 1; - else if (_kernel_major >= MIN_KERNEL_MAJOR) + if ((sscanf(cmd->kernel_vsn, "%d", &_kernel_major) == 1) && + (_kernel_major >= MIN_KERNEL_MAJOR)) log_debug_activation("Skipping checks for old devices without " UUID_PREFIX " dm uuid prefix (kernel vsn %d >= %d).", _kernel_major, MIN_KERNEL_MAJOR); + else + _kernel_major = -1; } - return (_kernel_major < MIN_KERNEL_MAJOR); + return (_kernel_major == -1); } static int _info(struct cmd_context *cmd, const char *dlid, int with_open_count, int with_read_ahead,

1 0

master - cleanup: reuse _setup_task
by Zdenek Kabelac 08 Apr '16

08 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=74e704bb4465960b… Commit: 74e704bb4465960b361711c890733cbae1f06e42 Parent: a09d65891fcf97130dd595eba320b647638d9a07 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Fri Apr 8 19:28:35 2016 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Fri Apr 8 20:20:16 2016 +0200 cleanup: reuse _setup_task Shorten code and use common code from _setup_task. Reorder naming of major:minor sscanf (as later it's been also used swapped there was no real bug). --- lib/activate/dev_manager.c | 58 ++++++++++++------------------------------- 1 files changed, 16 insertions(+), 42 deletions(-) diff --git a/lib/activate/dev_manager.c b/lib/activate/dev_manager.c index f2e3826..8c01b43 100644 --- a/lib/activate/dev_manager.c +++ b/lib/activate/dev_manager.c @@ -337,13 +337,8 @@ static int _ignore_blocked_mirror_devices(struct device *dev, * We avoid another system call if we can, but if a device is * dead, we have no choice but to look up the table too. */ - if (!(dmt = dm_task_create(DM_DEVICE_TABLE))) - goto_out; - - if (!dm_task_set_major_minor(dmt, MAJOR(dev->dev), MINOR(dev->dev), 1)) - goto_out; - - if (activation_checks() && !dm_task_enable_checks(dmt)) + if (!(dmt = _setup_task(NULL, NULL, NULL, DM_DEVICE_TABLE, + MAJOR(dev->dev), MINOR(dev->dev), 0))) goto_out; if (!dm_task_run(dmt)) @@ -384,13 +379,8 @@ static int _device_is_suspended(int major, int minor) struct dm_info info; int r = 0; - if (!(dmt = dm_task_create(DM_DEVICE_INFO))) - return 0; - - if (!dm_task_set_major_minor(dmt, major, minor, 1)) - goto_out; - - if (activation_checks() && !dm_task_enable_checks(dmt)) + if (!(dmt = _setup_task(NULL, NULL, NULL, DM_DEVICE_INFO, + major, minor, 0))) goto_out; if (!dm_task_run(dmt) || @@ -414,13 +404,8 @@ static int _ignore_suspended_snapshot_component(struct device *dev) int major1, minor1, major2, minor2; int r = 0; - if (!(dmt = dm_task_create(DM_DEVICE_TABLE))) - return_0; - - if (!dm_task_set_major_minor(dmt, MAJOR(dev->dev), MINOR(dev->dev), 1)) - goto_out; - - if (activation_checks() && !dm_task_enable_checks(dmt)) + if (!(dmt = _setup_task(NULL, NULL, NULL, DM_DEVICE_TABLE, + MAJOR(dev->dev), MINOR(dev->dev), 0))) goto_out; if (!dm_task_run(dmt)) { @@ -466,32 +451,29 @@ static int _ignore_unusable_thins(struct device *dev) if (!(mem = dm_pool_create("unusable_thins", 128))) return_0; - if (!(dmt = dm_task_create(DM_DEVICE_TABLE))) - goto_out; - if (!dm_task_no_open_count(dmt)) - goto_out; - if (!dm_task_set_major_minor(dmt, MAJOR(dev->dev), MINOR(dev->dev), 1)) + if (!(dmt = _setup_task(NULL, NULL, NULL, DM_DEVICE_TABLE, + MAJOR(dev->dev), MINOR(dev->dev), 0))) goto_out; + if (!dm_task_run(dmt)) { log_error("Failed to get state of mapped device."); goto out; } dm_get_next_target(dmt, next, &start, &length, &target_type, &params); - if (!params || sscanf(params, "%d:%d", &minor, &major) != 2) { + if (!params || sscanf(params, "%d:%d", &major, &minor) != 2) { log_error("Failed to get thin-pool major:minor for thin device %d:%d.", (int)MAJOR(dev->dev), (int)MINOR(dev->dev)); goto out; } dm_task_destroy(dmt); - if (!(dmt = dm_task_create(DM_DEVICE_STATUS))) + if (!(dmt = _setup_task(NULL, NULL, NULL, DM_DEVICE_STATUS, + major, minor, 0))) goto_out; + if (!dm_task_no_flush(dmt)) log_warn("Can't set no_flush."); - if (!dm_task_no_open_count(dmt)) - goto_out; - if (!dm_task_set_major_minor(dmt, minor, major, 1)) - goto_out; + if (!dm_task_run(dmt)) { log_error("Failed to get state of mapped device."); goto out; @@ -545,22 +527,14 @@ int device_is_usable(struct device *dev, struct dev_usable_check_params check) int only_error_target = 1; int r = 0; - if (!(dmt = dm_task_create(DM_DEVICE_STATUS))) - return_0; - - if (!dm_task_set_major_minor(dmt, MAJOR(dev->dev), MINOR(dev->dev), 1)) - goto_out; - - if (activation_checks() && !dm_task_enable_checks(dmt)) + if (!(dmt = _setup_task(NULL, NULL, NULL, DM_DEVICE_STATUS, + MAJOR(dev->dev), MINOR(dev->dev), 0))) goto_out; /* Non-blocking status read */ if (!dm_task_no_flush(dmt)) log_warn("WARNING: Can't set no_flush for dm status."); - if (!dm_task_no_open_count(dmt)) - goto_out; - if (!dm_task_run(dmt)) { log_error("Failed to get state of mapped device"); goto out;

1 0

master - dev_manager: device_is_usable does not flush
by Zdenek Kabelac 08 Apr '16

08 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=a09d65891fcf9713… Commit: a09d65891fcf97130dd595eba320b647638d9a07 Parent: f40dfb48ad0114c89ac5fc0a8670a3792565e9a9 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Fri Apr 8 16:00:03 2016 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Fri Apr 8 20:20:04 2016 +0200 dev_manager: device_is_usable does not flush When scanning if device is being usable as PV, we call STATUS - but this status should not cause any flushing. Skip also open_count information as it's not needed. --- WHATS_NEW | 1 + lib/activate/dev_manager.c | 9 ++++++++- 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 21970a8..0fa9f50 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.150 - ================================= + Avoid using flushing dm status ioctl when checking for usable DM device. Check for devices without LVM- uuid prefix only with kernels < 3.X. Reuse %FREE size aproximation with lvcreate -l%PVS thin-pool. Allow the lvmdump directory to exist already provided it is empty. diff --git a/lib/activate/dev_manager.c b/lib/activate/dev_manager.c index 89fa9e9..f2e3826 100644 --- a/lib/activate/dev_manager.c +++ b/lib/activate/dev_manager.c @@ -553,7 +553,14 @@ int device_is_usable(struct device *dev, struct dev_usable_check_params check) if (activation_checks() && !dm_task_enable_checks(dmt)) goto_out; - + + /* Non-blocking status read */ + if (!dm_task_no_flush(dmt)) + log_warn("WARNING: Can't set no_flush for dm status."); + + if (!dm_task_no_open_count(dmt)) + goto_out; + if (!dm_task_run(dmt)) { log_error("Failed to get state of mapped device"); goto out;

1 0

master - activation: Skip another non-prefixed info ioctl.
by Alasdair Kergon 08 Apr '16

08 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=f40dfb48ad0114c8… Commit: f40dfb48ad0114c89ac5fc0a8670a3792565e9a9 Parent: e6768997e192e26aaf091b6ed2700a3391f178b5 Author: Alasdair G Kergon <agk(a)redhat.com> AuthorDate: Fri Apr 8 16:27:12 2016 +0100 Committer: Alasdair G Kergon <agk(a)redhat.com> CommitterDate: Fri Apr 8 16:27:12 2016 +0100 activation: Skip another non-prefixed info ioctl. _percent() also does a lookup by dm uuid. Also get kernel version from cmd->kernel_vsn. --- lib/activate/activate.c | 4 +- lib/activate/dev_manager.c | 60 ++++++++++++++++++++++++------------------- lib/activate/dev_manager.h | 3 +- 3 files changed, 37 insertions(+), 30 deletions(-) diff --git a/lib/activate/activate.c b/lib/activate/activate.c index 985d6b9..ca82518 100644 --- a/lib/activate/activate.c +++ b/lib/activate/activate.c @@ -660,7 +660,7 @@ static int _lv_info(struct cmd_context *cmd, const struct logical_volume *lv, /* New thin-pool has no layer, but -tpool suffix needs to be queried */ if (!use_layer && lv_is_new_thin_pool(lv)) { /* Check if there isn't existing old thin pool mapping in the table */ - if (!dev_manager_info(cmd->mem, lv, NULL, 0, 0, &dminfo, NULL, NULL)) + if (!dev_manager_info(cmd, lv, NULL, 0, 0, &dminfo, NULL, NULL)) return_0; if (!dminfo.exists) use_layer = 1; @@ -669,7 +669,7 @@ static int _lv_info(struct cmd_context *cmd, const struct logical_volume *lv, if (seg_status) seg_status->seg = seg; - if (!dev_manager_info(cmd->mem, lv, + if (!dev_manager_info(cmd, lv, (use_layer) ? lv_layer(lv) : NULL, with_open_count, with_read_ahead, &dminfo, (info) ? &info->read_ahead : NULL, diff --git a/lib/activate/dev_manager.c b/lib/activate/dev_manager.c index 18e2081..89fa9e9 100644 --- a/lib/activate/dev_manager.c +++ b/lib/activate/dev_manager.c @@ -29,7 +29,6 @@ #include <limits.h> #include <dirent.h> -#include <sys/utsname.h> #define MAX_TARGET_PARAMSIZE 50000 #define LVM_UDEV_NOSCAN_FLAG DM_SUBSYSTEM_UDEV_FLAG0 @@ -675,25 +674,31 @@ int device_is_usable(struct device *dev, struct dev_usable_check_params check) return r; } -/* Returns 1 for kernels >= 3.X, otherwise 0 */ -static int _check_new_kernel(void) +/* + * If active LVs were activated by a version of LVM2 before 2.02.00 we must + * perform additional checks to find them because they do not have the LVM- + * prefix on their dm uuids. + * As of 2.02.150, we've chosen to disable this compatibility arbitrarily if + * we're running kernel version 3 or above. + */ +#define MIN_KERNEL_MAJOR 3 + +static int _original_uuid_format_check_required(struct cmd_context *cmd) { - static int major = 0; - struct utsname _uts; + static int _kernel_major = 0; - if (!major) { - if (uname(&_uts) || - (sscanf(_uts.release, "%d", &major) != 1)) - major = 1; - else if (major >= 3) - log_debug("Not checking for devices without prefix " - UUID_PREFIX " with newer kernel."); + if (!_kernel_major) { + if ((sscanf(cmd->kernel_vsn, "%d", &_kernel_major) != 1)) + _kernel_major = 1; + else if (_kernel_major >= MIN_KERNEL_MAJOR) + log_debug_activation("Skipping checks for old devices without " UUID_PREFIX + " dm uuid prefix (kernel vsn %d >= %d).", _kernel_major, MIN_KERNEL_MAJOR); } - return (major >= 3); + return (_kernel_major < MIN_KERNEL_MAJOR); } -static int _info(const char *dlid, int with_open_count, int with_read_ahead, +static int _info(struct cmd_context *cmd, const char *dlid, int with_open_count, int with_read_ahead, struct dm_info *dminfo, uint32_t *read_ahead, struct lv_seg_status *seg_status) { @@ -722,8 +727,8 @@ static int _info(const char *dlid, int with_open_count, int with_read_ahead, } } - /* With kernels > 3.X skip checking for devices without UUID_PREFIX */ - if (_check_new_kernel()) + /* Must we still check for the pre-2.02.00 dm uuid format? */ + if (!_original_uuid_format_check_required(cmd)) return r; /* Check for dlid before UUID_PREFIX was added */ @@ -740,7 +745,7 @@ static int _info_by_dev(uint32_t major, uint32_t minor, struct dm_info *info) return _info_run(INFO, NULL, NULL, info, NULL, 0, 0, 0, major, minor); } -int dev_manager_info(struct dm_pool *mem, const struct logical_volume *lv, +int dev_manager_info(struct cmd_context *cmd, const struct logical_volume *lv, const char *layer, int with_open_count, int with_read_ahead, struct dm_info *dminfo, uint32_t *read_ahead, @@ -749,19 +754,19 @@ int dev_manager_info(struct dm_pool *mem, const struct logical_volume *lv, char *dlid, *name; int r; - if (!(name = dm_build_dm_name(mem, lv->vg->name, lv->name, layer))) + if (!(name = dm_build_dm_name(cmd->mem, lv->vg->name, lv->name, layer))) return_0; - if (!(dlid = build_dm_uuid(mem, lv, layer))) { + if (!(dlid = build_dm_uuid(cmd->mem, lv, layer))) { r = 0; goto_out; } log_debug_activation("Getting device info for %s [%s]", name, dlid); - r = _info(dlid, with_open_count, with_read_ahead, + r = _info(cmd, dlid, with_open_count, with_read_ahead, dminfo, read_ahead, seg_status); out: - dm_pool_free(mem, name); + dm_pool_free(cmd->mem, name); return r; } @@ -1008,7 +1013,8 @@ static int _percent(struct dev_manager *dm, const char *name, const char *dlid, if (_percent_run(dm, NULL, dlid, target_type, wait, lv, percent, event_nr, fail_if_percent_unsupported)) return 1; - else if (_percent_run(dm, NULL, dlid + sizeof(UUID_PREFIX) - 1, + else if (_original_uuid_format_check_required(dm->cmd) && + _percent_run(dm, NULL, dlid + sizeof(UUID_PREFIX) - 1, target_type, wait, lv, percent, event_nr, fail_if_percent_unsupported)) return 1; @@ -1686,7 +1692,7 @@ static int _add_dev_to_dtree(struct dev_manager *dm, struct dm_tree *dtree, return_0; log_debug_activation("Getting device info for %s [%s]", name, dlid); - if (!_info(dlid, 1, 0, &info, NULL, NULL)) { + if (!_info(dm->cmd, dlid, 1, 0, &info, NULL, NULL)) { log_error("Failed to get info for %s [%s].", name, dlid); return 0; } @@ -1884,8 +1890,8 @@ static int _pool_callback(struct dm_tree_node *node, log_sys_error("close", argv[args]); if (ret == (int) DM_ARRAY_SIZE(buf)) { - log_debug("%s skipped, detect empty disk header on %s.", - argv[0], argv[args]); + log_debug_activation("%s skipped, detect empty disk header on %s.", + argv[0], argv[args]); return 1; } } @@ -2210,7 +2216,7 @@ static char *_add_error_device(struct dev_manager *dm, struct dm_tree *dtree, return_NULL; log_debug_activation("Getting device info for %s [%s]", name, dlid); - if (!_info(dlid, 1, 0, &info, NULL, NULL)) { + if (!_info(dm->cmd, dlid, 1, 0, &info, NULL, NULL)) { log_error("Failed to get info for %s [%s].", name, dlid); return 0; } diff --git a/lib/activate/dev_manager.h b/lib/activate/dev_manager.h index bcfb226..3744a61 100644 --- a/lib/activate/dev_manager.h +++ b/lib/activate/dev_manager.h @@ -45,11 +45,12 @@ void dev_manager_exit(void); * (eg, an origin is created before its snapshot, but is not * unsuspended until the snapshot is also created.) */ -int dev_manager_info(struct dm_pool *mem, const struct logical_volume *lv, +int dev_manager_info(struct cmd_context *cmd, const struct logical_volume *lv, const char *layer, int with_open_count, int with_read_ahead, struct dm_info *dminfo, uint32_t *read_ahead, struct lv_seg_status *seg_status); + int dev_manager_snapshot_percent(struct dev_manager *dm, const struct logical_volume *lv, dm_percent_t *percent);

1 0

master - test: Fix testing of installed lvmdbusd
by Marian Csontos 08 Apr '16

08 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=e6768997e192e26a… Commit: e6768997e192e26aaf091b6ed2700a3391f178b5 Parent: ed0c779bd120e7c36cb7f100df3c6edc98e8cc52 Author: Marian Csontos <mcsontos(a)redhat.com> AuthorDate: Fri Apr 1 09:28:31 2016 +0200 Committer: Marian Csontos <mcsontos(a)redhat.com> CommitterDate: Fri Apr 8 16:26:25 2016 +0200 test: Fix testing of installed lvmdbusd If lvmdbusd is missing expression triggers ERR trap instead of skipping the test. --- test/lib/aux.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/lib/aux.sh b/test/lib/aux.sh index c8985ed..3a44ae6 100644 --- a/test/lib/aux.sh +++ b/test/lib/aux.sh @@ -321,7 +321,7 @@ prepare_lvmdbusd() { # Setup the python path so we can run export PYTHONPATH=$abs_top_builddir/daemons else - daemon="$(which lvmdbusd)" + daemon="$(which lvmdbusd || :)" fi [[ -n $daemon && -x $daemon ]] || skip "The daemon is missing"

1 0

master - report: remove superfluous SEGSSTATUS report type
by Peter Rajnoha 08 Apr '16

08 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=ed0c779bd120e7c3… Commit: ed0c779bd120e7c36cb7f100df3c6edc98e8cc52 Parent: 50866034a2e612250c45116674765da08820fb27 Author: Peter Rajnoha <prajnoha(a)redhat.com> AuthorDate: Fri Apr 8 14:18:00 2016 +0200 Committer: Peter Rajnoha <prajnoha(a)redhat.com> CommitterDate: Fri Apr 8 14:21:47 2016 +0200 report: remove superfluous SEGSSTATUS report type We don't have any report field of this type yet. Return this patch into the play if we really need that. Currenly we always report status (result of "status" dm ioctl) for an LV as a whole where we choose segment which represents the LV, not calling status for each possible segment it contains - we don't need this now so I'm removing it to not make the code more complex uselessly. --- lib/report/report.c | 1 - lib/report/report.h | 7 +++---- tools/reporter.c | 8 +++----- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/lib/report/report.c b/lib/report/report.c index 5009ecc..08a6097 100644 --- a/lib/report/report.c +++ b/lib/report/report.c @@ -3667,7 +3667,6 @@ static const struct dm_report_object_type _report_types[] = { { PVS, "Physical Volume", "pv_", _obj_get_pv }, { LABEL, "Physical Volume Label", "pv_", _obj_get_label }, { SEGS, "Logical Volume Segment", "seg_", _obj_get_seg }, - { SEGSSTATUS, "Logical Volume Device Segment Status", "seg_", _obj_get_lv_with_info_and_seg_status }, { PVSEGS, "Physical Volume Segment", "pvseg_", _obj_get_pvseg }, { 0, "", "", NULL }, }; diff --git a/lib/report/report.h b/lib/report/report.h index 182f294..088a1ca 100644 --- a/lib/report/report.h +++ b/lib/report/report.h @@ -28,10 +28,9 @@ typedef enum { PVS = 16, VGS = 32, SEGS = 64, - SEGSSTATUS = 128, - PVSEGS = 256, - LABEL = 512, - DEVTYPES = 1024 + PVSEGS = 128, + LABEL = 256, + DEVTYPES = 512 } report_type_t; /* diff --git a/tools/reporter.c b/tools/reporter.c index 220e307..a4cae60 100644 --- a/tools/reporter.c +++ b/tools/reporter.c @@ -409,10 +409,10 @@ static int _get_final_report_type(int args_are_pvs, *lv_info_needed = (report_type & (LVSINFO | LVSINFOSTATUS)) ? 1 : 0; /* Do we need to acquire LV device status in addition? */ - *lv_segment_status_needed = (report_type & (SEGSSTATUS | LVSSTATUS | LVSINFOSTATUS)) ? 1 : 0; + *lv_segment_status_needed = (report_type & (LVSSTATUS | LVSINFOSTATUS)) ? 1 : 0; /* Ensure options selected are compatible */ - if (report_type & (SEGS | SEGSSTATUS)) + if (report_type & SEGS) report_type |= LVS; if (report_type & PVSEGS) report_type |= PVS; @@ -429,7 +429,7 @@ static int _get_final_report_type(int args_are_pvs, else if ((report_type & PVS) || ((report_type & LABEL) && (report_type & VGS))) report_type = PVS; - else if (report_type & (SEGS | SEGSSTATUS)) + else if (report_type & SEGS) report_type = SEGS; else if (report_type & (LVS | LVSINFO | LVSSTATUS | LVSINFOSTATUS)) report_type = LVS; @@ -907,8 +907,6 @@ static int _report(struct cmd_context *cmd, int argc, char **argv, r = process_each_vg(cmd, argc, argv, NULL, 0, handle, &_pvs_in_vg); break; - case SEGSSTATUS: - /* fall through */ case SEGS: r = process_each_lv(cmd, argc, argv, 0, handle, lv_info_needed && !lv_segment_status_needed ? &_lvsegs_with_info_single :

1 0

master - cleanup: use common init/destroy_processing_handle in _report fn and cleanup error paths
by Peter Rajnoha 08 Apr '16

08 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=50866034a2e61225… Commit: 50866034a2e612250c45116674765da08820fb27 Parent: f2e59e05eda9283911a8c7ea14c73ea4c30f8fa8 Author: Peter Rajnoha <prajnoha(a)redhat.com> AuthorDate: Fri Apr 8 11:01:19 2016 +0200 Committer: Peter Rajnoha <prajnoha(a)redhat.com> CommitterDate: Fri Apr 8 11:01:19 2016 +0200 cleanup: use common init/destroy_processing_handle in _report fn and cleanup error paths --- tools/reporter.c | 58 +++++++++++++++++++++++++++-------------------------- 1 files changed, 30 insertions(+), 28 deletions(-) diff --git a/tools/reporter.c b/tools/reporter.c index 1a708c4..220e307 100644 --- a/tools/reporter.c +++ b/tools/reporter.c @@ -733,10 +733,10 @@ out: static int _report(struct cmd_context *cmd, int argc, char **argv, report_type_t report_type) { - void *report_handle; - struct processing_handle handle = {0}; + void *report_handle = NULL; + struct processing_handle *handle = NULL; const char *keys = NULL, *options = NULL, *selection = NULL, *separator; - int r = ECMD_PROCESSED; + int r = ECMD_FAILED; int aligned, buffered, headings, field_prefixes, quoted; int columns_as_rows; unsigned args_are_pvs; @@ -809,13 +809,13 @@ static int _report(struct cmd_context *cmd, int argc, char **argv, break; default: log_error(INTERNAL_ERROR "Unknown report type."); - return ECMD_FAILED; + goto out; } /* If -o supplied use it, else use default for report_type */ if (arg_count(cmd, options_ARG) && ((r = _get_report_options(cmd, report_type, &options, &fields_to_compact) != ECMD_PROCESSED))) - return r; + goto_out; /* -O overrides default sort settings */ keys = arg_str_value(cmd, sort_ARG, keys); @@ -841,19 +841,24 @@ static int _report(struct cmd_context *cmd, int argc, char **argv, if (arg_count(cmd, select_ARG)) selection = arg_str_value(cmd, select_ARG, NULL); + if (!(handle = init_processing_handle(cmd))) + goto_out; + if (!(report_handle = report_init(cmd, options, keys, &report_type, separator, aligned, buffered, headings, field_prefixes, quoted, columns_as_rows, selection))) - return_ECMD_FAILED; + goto_out; + + handle->internal_report_for_select = 0; + handle->include_historical_lvs = cmd->include_historical_lvs; + handle->custom_handle = report_handle; if (!_get_final_report_type(args_are_pvs, report_type, &lv_info_needed, &lv_segment_status_needed, - &report_type)) { - dm_report_free(report_handle); - return ECMD_FAILED; - } + &report_type)) + goto_out; /* * We lock VG_GLOBAL to enable use of metadata cache. @@ -864,18 +869,13 @@ static int _report(struct cmd_context *cmd, int argc, char **argv, lock_global = 1; if (!lock_vol(cmd, VG_GLOBAL, LCK_VG_READ, NULL)) { log_error("Unable to obtain global lock."); - dm_report_free(report_handle); - return ECMD_FAILED; + goto out; } } - handle.internal_report_for_select = 0; - handle.include_historical_lvs = cmd->include_historical_lvs; - handle.custom_handle = report_handle; - switch (report_type) { case DEVTYPES: - r = _process_each_devtype(cmd, argc, &handle); + r = _process_each_devtype(cmd, argc, handle); break; case LVSINFO: /* fall through */ @@ -884,7 +884,7 @@ static int _report(struct cmd_context *cmd, int argc, char **argv, case LVSINFOSTATUS: /* fall through */ case LVS: - r = process_each_lv(cmd, argc, argv, 0, &handle, + r = process_each_lv(cmd, argc, argv, 0, handle, lv_info_needed && !lv_segment_status_needed ? &_lvs_with_info_single : !lv_info_needed && lv_segment_status_needed ? &_lvs_with_status_single : lv_info_needed && lv_segment_status_needed ? &_lvs_with_info_and_status_single : @@ -892,25 +892,25 @@ static int _report(struct cmd_context *cmd, int argc, char **argv, break; case VGS: r = process_each_vg(cmd, argc, argv, NULL, 0, - &handle, &_vgs_single); + handle, &_vgs_single); break; case LABEL: r = process_each_label(cmd, argc, argv, - &handle, &_label_single); + handle, &_label_single); break; case PVS: if (args_are_pvs) r = process_each_pv(cmd, argc, argv, NULL, arg_is_set(cmd, all_ARG), 0, - &handle, &_pvs_single); + handle, &_pvs_single); else r = process_each_vg(cmd, argc, argv, NULL, 0, - &handle, &_pvs_in_vg); + handle, &_pvs_in_vg); break; case SEGSSTATUS: /* fall through */ case SEGS: - r = process_each_lv(cmd, argc, argv, 0, &handle, + r = process_each_lv(cmd, argc, argv, 0, handle, lv_info_needed && !lv_segment_status_needed ? &_lvsegs_with_info_single : !lv_info_needed && lv_segment_status_needed ? &_lvsegs_with_status_single : lv_info_needed && lv_segment_status_needed ? &_lvsegs_with_info_and_status_single : @@ -920,14 +920,14 @@ static int _report(struct cmd_context *cmd, int argc, char **argv, if (args_are_pvs) r = process_each_pv(cmd, argc, argv, NULL, arg_is_set(cmd, all_ARG), 0, - &handle, + handle, lv_info_needed && !lv_segment_status_needed ? &_pvsegs_with_lv_info_single : !lv_info_needed && lv_segment_status_needed ? &_pvsegs_with_lv_status_single : lv_info_needed && lv_segment_status_needed ? &_pvsegs_with_lv_info_and_status_single : &_pvsegs_single); else r = process_each_vg(cmd, argc, argv, NULL, 0, - &handle, &_pvsegs_in_vg); + handle, &_pvsegs_in_vg); break; } @@ -942,11 +942,13 @@ static int _report(struct cmd_context *cmd, int argc, char **argv, dm_report_output(report_handle); - dm_report_free(report_handle); - if (lock_global) unlock_vg(cmd, VG_GLOBAL); - +out: + if (handle) + destroy_processing_handle(cmd, handle); + if (report_handle) + dm_report_free(report_handle); return r; }

1 0

master - cleanup: use #define for field's quote and pair character and also for the error msg while extending output line
by Peter Rajnoha 08 Apr '16

08 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=f2e59e05eda92839… Commit: f2e59e05eda9283911a8c7ea14c73ea4c30f8fa8 Parent: 248f47d489df42ce29f74f71185a4e266a9e78e0 Author: Peter Rajnoha <prajnoha(a)redhat.com> AuthorDate: Fri Apr 8 10:55:13 2016 +0200 Committer: Peter Rajnoha <prajnoha(a)redhat.com> CommitterDate: Fri Apr 8 10:55:13 2016 +0200 cleanup: use #define for field's quote and pair character and also for the error msg while extending output line --- libdm/libdm-report.c | 31 ++++++++++++++++++------------- 1 files changed, 18 insertions(+), 13 deletions(-) diff --git a/libdm/libdm-report.c b/libdm/libdm-report.c index 8250a35..3896b3c 100644 --- a/libdm/libdm-report.c +++ b/libdm/libdm-report.c @@ -4175,6 +4175,11 @@ static int _sort_rows(struct dm_report *rh) return 1; } +#define STANDARD_QUOTE "\'" +#define STANDARD_PAIR "=" + +#define UNABLE_TO_EXTEND_OUTPUT_LINE_MSG "dm_report: Unable to extend output line" + /* * Produce report output */ @@ -4196,27 +4201,27 @@ static int _output_field(struct dm_report *rh, struct dm_report_field *field) } if (!dm_pool_grow_object(rh->mem, rh->output_field_name_prefix, 0)) { - log_error("dm_report: Unable to extend output line"); + log_error(UNABLE_TO_EXTEND_OUTPUT_LINE_MSG); dm_free(field_id); return 0; } if (!dm_pool_grow_object(rh->mem, _toupperstr(field_id), 0)) { - log_error("dm_report: Unable to extend output line"); + log_error(UNABLE_TO_EXTEND_OUTPUT_LINE_MSG); dm_free(field_id); return 0; } dm_free(field_id); - if (!dm_pool_grow_object(rh->mem, "=", 1)) { - log_error("dm_report: Unable to extend output line"); + if (!dm_pool_grow_object(rh->mem, STANDARD_PAIR, 1)) { + log_error(UNABLE_TO_EXTEND_OUTPUT_LINE_MSG); return 0; } if (!(rh->flags & DM_REPORT_OUTPUT_FIELD_UNQUOTED) && - !dm_pool_grow_object(rh->mem, "\'", 1)) { - log_error("dm_report: Unable to extend output line"); + !dm_pool_grow_object(rh->mem, STANDARD_QUOTE, 1)) { + log_error(UNABLE_TO_EXTEND_OUTPUT_LINE_MSG); return 0; } } @@ -4225,7 +4230,7 @@ static int _output_field(struct dm_report *rh, struct dm_report_field *field) width = field->props->width; if (!(rh->flags & DM_REPORT_OUTPUT_ALIGNED)) { if (!dm_pool_grow_object(rh->mem, repstr, 0)) { - log_error("dm_report: Unable to extend output line"); + log_error(UNABLE_TO_EXTEND_OUTPUT_LINE_MSG); return 0; } } else { @@ -4248,7 +4253,7 @@ static int _output_field(struct dm_report *rh, struct dm_report_field *field) goto bad; } if (!dm_pool_grow_object(rh->mem, buf, width)) { - log_error("dm_report: Unable to extend output line"); + log_error(UNABLE_TO_EXTEND_OUTPUT_LINE_MSG); goto bad; } } else if (align & DM_REPORT_FIELD_ALIGN_RIGHT) { @@ -4258,7 +4263,7 @@ static int _output_field(struct dm_report *rh, struct dm_report_field *field) goto bad; } if (!dm_pool_grow_object(rh->mem, buf, width)) { - log_error("dm_report: Unable to extend output line"); + log_error(UNABLE_TO_EXTEND_OUTPUT_LINE_MSG); goto bad; } } @@ -4266,8 +4271,8 @@ static int _output_field(struct dm_report *rh, struct dm_report_field *field) if ((rh->flags & DM_REPORT_OUTPUT_FIELD_NAME_PREFIX) && !(rh->flags & DM_REPORT_OUTPUT_FIELD_UNQUOTED)) - if (!dm_pool_grow_object(rh->mem, "\'", 1)) { - log_error("dm_report: Unable to extend output line"); + if (!dm_pool_grow_object(rh->mem, STANDARD_QUOTE, 1)) { + log_error(UNABLE_TO_EXTEND_OUTPUT_LINE_MSG); goto bad; } @@ -4345,7 +4350,7 @@ static int _output_as_rows(struct dm_report *rh) if (!dm_list_end(&rh->rows, &row->list)) if (!dm_pool_grow_object(rh->mem, rh->separator, 0)) { - log_error("dm_report: Unable to extend output line"); + log_error(UNABLE_TO_EXTEND_OUTPUT_LINE_MSG); goto bad; } } @@ -4393,7 +4398,7 @@ static int _output_as_columns(struct dm_report *rh) if (!dm_list_end(&row->fields, fh)) if (!dm_pool_grow_object(rh->mem, rh->separator, 0)) { - log_error("dm_report: Unable to extend output line"); + log_error(UNABLE_TO_EXTEND_OUTPUT_LINE_MSG); goto bad; }

1 0

master - tests: require newer cache target
by Zdenek Kabelac 07 Apr '16

07 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=248f47d489df42ce… Commit: 248f47d489df42ce29f74f71185a4e266a9e78e0 Parent: 9ab53dddf553867ba9a19367bf74307a36c43c9f Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Fri Apr 8 00:04:26 2016 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Fri Apr 8 00:04:26 2016 +0200 tests: require newer cache target Older cache target is likely not updating status at all... --- test/shell/lvconvert-repair-cache.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/shell/lvconvert-repair-cache.sh b/test/shell/lvconvert-repair-cache.sh index 1fdfd3f..756fd12 100644 --- a/test/shell/lvconvert-repair-cache.sh +++ b/test/shell/lvconvert-repair-cache.sh @@ -25,7 +25,7 @@ which "$FSCK" || skip # # Main # -aux have_cache 1 3 0 || skip +aux have_cache 1 5 0 || skip aux prepare_vg 4

1 0

master - tests: use mkfs.ext3
by Zdenek Kabelac 07 Apr '16

07 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=9ab53dddf553867b… Commit: 9ab53dddf553867ba9a19367bf74307a36c43c9f Parent: 8b2108e6b16cbcb528a138413e9050dd6f420e0d Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Thu Apr 7 22:07:41 2016 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Thu Apr 7 22:32:09 2016 +0200 tests: use mkfs.ext3 mkfs.ext4 is not really needed so use more widespread mkfs.ext3 so test runs on older system. --- test/shell/lvconvert-repair-mirror.sh | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/test/shell/lvconvert-repair-mirror.sh b/test/shell/lvconvert-repair-mirror.sh index 242028d..e40f9aa 100644 --- a/test/shell/lvconvert-repair-mirror.sh +++ b/test/shell/lvconvert-repair-mirror.sh @@ -12,10 +12,13 @@ SKIP_WITH_LVMLOCKD=1 SKIP_WITH_LVMPOLLD=1 +MKFS=mkfs.ext3 MOUNT_DIR=mnt . lib/inittest +which "$MKFS" || skp + cleanup_mounted_and_teardown() { umount "$MOUNT_DIR" || true @@ -33,7 +36,7 @@ aux prepare_vg 5 # with the default 512K - my C2D T61 reads just couple MB/s! # lvcreate -aey --type mirror -L10 --regionsize 1M -m1 -n $lv1 $vg "$dev1" "$dev2" "$dev3" -mkfs.ext4 "$DM_DEV_DIR/$vg/$lv1" +"$MKFS" "$DM_DEV_DIR/$vg/$lv1" mkdir "$MOUNT_DIR" aux delay_dev "$dev2" 0 500 $(get first_extent_sector "$dev2"): @@ -42,7 +45,7 @@ aux delay_dev "$dev4" 0 500 $(get first_extent_sector "$dev4"): # Enforce syncronization # ATM requires unmounted/unused LV?? # -lvchange --yes --resync --noudevsync $vg/$lv1 +lvchange --yes --resync $vg/$lv1 trap 'cleanup_mounted_and_teardown' EXIT mount "$DM_DEV_DIR/$vg/$lv1" "$MOUNT_DIR" @@ -52,7 +55,8 @@ dd if=/dev/zero of=mnt/zero bs=4K count=100 conv=fdatasync 2>err & PERCENT=$(get lv_field $vg/$lv1 copy_percent) PERCENT=${PERCENT%%\.*} # cut decimal -test "$PERCENT" -lt 50 # and check less then 50% mirror is in sync +# and check less then 50% mirror is in sync (could be unusable delay_dev ?) +test "$PERCENT" -lt 50 || skip #lvs -a -o+devices $vg #aux disable_dev "$dev3"

1 0

master - activation: do not check for devs without LVM-
by Zdenek Kabelac 07 Apr '16

07 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=8b2108e6b16cbcb5… Commit: 8b2108e6b16cbcb528a138413e9050dd6f420e0d Parent: 097a724bda160e4c0b5c7760e7a710d3e00b898c Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Thu Apr 7 21:37:26 2016 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Thu Apr 7 22:32:08 2016 +0200 activation: do not check for devs without LVM- Devices without "LVM-" uuid prefix have been generated by very old version of lvm2 2.00 and 2.01. Since version 2.02 all lvm2 devices are using prefix "LVM-". However checking for present of ancient non prefixed devices does take extra IOCTL per every call and for majority of todays user it will not find anything new. So use the assumption that users with kernel 3.X and newer are not really using such old versions of lvm2 (year <2005) and with their new kernel they are also using new version of lvm2 and skip checking for them. This change also makes trace logs more readable. --- WHATS_NEW | 1 + lib/activate/dev_manager.c | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+), 0 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 8387eab..21970a8 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.150 - ================================= + Check for devices without LVM- uuid prefix only with kernels < 3.X. Reuse %FREE size aproximation with lvcreate -l%PVS thin-pool. Allow the lvmdump directory to exist already provided it is empty. Show lvconverted percentage with 2 decimal digits. diff --git a/lib/activate/dev_manager.c b/lib/activate/dev_manager.c index b3e97db..18e2081 100644 --- a/lib/activate/dev_manager.c +++ b/lib/activate/dev_manager.c @@ -29,6 +29,7 @@ #include <limits.h> #include <dirent.h> +#include <sys/utsname.h> #define MAX_TARGET_PARAMSIZE 50000 #define LVM_UDEV_NOSCAN_FLAG DM_SUBSYSTEM_UDEV_FLAG0 @@ -674,6 +675,24 @@ int device_is_usable(struct device *dev, struct dev_usable_check_params check) return r; } +/* Returns 1 for kernels >= 3.X, otherwise 0 */ +static int _check_new_kernel(void) +{ + static int major = 0; + struct utsname _uts; + + if (!major) { + if (uname(&_uts) || + (sscanf(_uts.release, "%d", &major) != 1)) + major = 1; + else if (major >= 3) + log_debug("Not checking for devices without prefix " + UUID_PREFIX " with newer kernel."); + } + + return (major >= 3); +} + static int _info(const char *dlid, int with_open_count, int with_read_ahead, struct dm_info *dminfo, uint32_t *read_ahead, struct lv_seg_status *seg_status) @@ -703,6 +722,10 @@ static int _info(const char *dlid, int with_open_count, int with_read_ahead, } } + /* With kernels > 3.X skip checking for devices without UUID_PREFIX */ + if (_check_new_kernel()) + return r; + /* Check for dlid before UUID_PREFIX was added */ if ((r = _info_run(seg_status ? STATUS : INFO, NULL, dlid + sizeof(UUID_PREFIX) - 1, dminfo, read_ahead, seg_status, with_open_count,

1 0

master - lvcreate: %FREE -> %PVS
by Zdenek Kabelac 07 Apr '16

07 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=097a724bda160e4c… Commit: 097a724bda160e4c0b5c7760e7a710d3e00b898c Parent: e2d4f53c827a14597e51956adb2202d32660f54c Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Thu Apr 7 11:12:49 2016 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Thu Apr 7 22:32:08 2016 +0200 lvcreate: %FREE -> %PVS This is hotfix for RHBZ: https://bugzilla.redhat.com/1324537 However already the %FREE is not a good fit and we need something better. Meanwhile make -l%PVS work at least as good as %FREE for thin-pool. TODO: this needs rework - it should be allocator to do all the size decisions at one place. --- WHATS_NEW | 1 + tools/lvcreate.c | 2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 0c940b6..8387eab 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.150 - ================================= + Reuse %FREE size aproximation with lvcreate -l%PVS thin-pool. Allow the lvmdump directory to exist already provided it is empty. Show lvconverted percentage with 2 decimal digits. Fix regression in suspend when repairing --type mirror (2.02.133). diff --git a/tools/lvcreate.c b/tools/lvcreate.c index 283e52a..9714789 100644 --- a/tools/lvcreate.c +++ b/tools/lvcreate.c @@ -368,7 +368,7 @@ static int _update_extents_params(struct volume_group *vg, &lp->discards, &lp->zero)) return_0; - if (lcp->percent == PERCENT_FREE) { + if (lcp->percent == PERCENT_FREE || lcp->percent == PERCENT_PVS) { if (lp->extents <= (2 * lp->pool_metadata_extents)) { log_error("Not enough space for thin pool creation."); return 0;

1 0

master - WHATS_NEW: update
by Zdenek Kabelac 07 Apr '16

07 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=e2d4f53c827a1459… Commit: e2d4f53c827a14597e51956adb2202d32660f54c Parent: 7dcbf1dfd0bc5e2d057d41900f10016d170bdae2 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Thu Apr 7 22:20:01 2016 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Thu Apr 7 22:31:40 2016 +0200 WHATS_NEW: update doc for previous commits. --- WHATS_NEW | 2 ++ WHATS_NEW_DM | 1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index b1da1b0..0c940b6 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,6 +1,8 @@ Version 2.02.150 - ================================= Allow the lvmdump directory to exist already provided it is empty. + Show lvconverted percentage with 2 decimal digits. + Fix regression in suspend when repairing --type mirror (2.02.133). Version 2.02.149 - 1st April 2016 ================================= diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM index d84f8cf..6bd857e 100644 --- a/WHATS_NEW_DM +++ b/WHATS_NEW_DM @@ -1,5 +1,6 @@ Version 1.02.122 - ================================== + Improve log_debug ioctl bit attrs. Version 1.02.121 - 26th March 2016 ==================================

1 0

master - nothing
by Alasdair Kergon 06 Apr '16

06 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=6a3b31733ff5cd1f… Commit: 6a3b31733ff5cd1fc426166adb990d370e1adbaf Parent: 91a8a45a52fc3ca4b98f91d6e318d3aeab9fe776 Author: Alasdair G Kergon <agk(a)redhat.com> AuthorDate: Thu Apr 7 02:30:52 2016 +0100 Committer: Alasdair G Kergon <agk(a)redhat.com> CommitterDate: Thu Apr 7 02:30:52 2016 +0100 nothing --- WHATS_NEW | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index b1da1b0..b9758ac 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,4 +1,4 @@ -Version 2.02.150 - +Version 2.02.150 ================================= Allow the lvmdump directory to exist already provided it is empty.

1 0

master - nothing
by Alasdair Kergon 06 Apr '16

06 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=6fa8d3f04dd13801… Commit: 6fa8d3f04dd13801f906c93a32754bd7e2c67d2d Parent: 4a9b0895759ec7af6d86a3e411eeca488eada4f0 Author: Alasdair G Kergon <agk(a)redhat.com> AuthorDate: Thu Apr 7 02:26:14 2016 +0100 Committer: Alasdair G Kergon <agk(a)redhat.com> CommitterDate: Thu Apr 7 02:26:14 2016 +0100 nothing --- WHATS_NEW | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index b9758ac..b1da1b0 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,4 +1,4 @@ -Version 2.02.150 +Version 2.02.150 - ================================= Allow the lvmdump directory to exist already provided it is empty.

1 0

master - nothing
by Alasdair Kergon 06 Apr '16

06 Apr '16

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=af8403e743165ac2… Commit: af8403e743165ac26e9f71051b49087659b60675 Parent: 94625c405b0c21bcd015cdc3e07de4a87e712779 Author: Alasdair G Kergon <agk(a)redhat.com> AuthorDate: Thu Apr 7 02:17:47 2016 +0100 Committer: Alasdair G Kergon <agk(a)redhat.com> CommitterDate: Thu Apr 7 02:17:47 2016 +0100 nothing --- WHATS_NEW | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index b9758ac..b1da1b0 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,4 +1,4 @@ -Version 2.02.150 +Version 2.02.150 - ================================= Allow the lvmdump directory to exist already provided it is empty.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

lvm2-commits April 2016