August 2018 - lvm2-commits - Fedora mailing-lists

master - lvconvert: avoid superfluous interim raid type
by Heinz Mauelshagen 31 Aug '18

31 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=22a13043683a5647e8cc4… Commit: 22a13043683a5647e8cc4e3aead911e5269ffd2f Parent: 61600f8fa7e150b02c1be5e1f8ee1b008b4efa90 Author: Heinz Mauelshagen <heinzm(a)redhat.com> AuthorDate: Fri Aug 31 19:03:52 2018 +0200 Committer: Heinz Mauelshagen <heinzm(a)redhat.com> CommitterDate: Fri Aug 31 19:04:19 2018 +0200 lvconvert: avoid superfluous interim raid type When converting striped/raid0*/raid6_n_6 <-> raid4, avoid superfluous interim raid5_n layout. Related: rhbz1447809 --- lib/metadata/raid_manip.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/metadata/raid_manip.c b/lib/metadata/raid_manip.c index 6cbf601..2bc179a 100644 --- a/lib/metadata/raid_manip.c +++ b/lib/metadata/raid_manip.c @@ -6130,7 +6130,7 @@ static int _set_convenient_raid145610_segtype_to(const struct lv_segment *seg_fr seg_flag = SEG_RAID6_N_6; if (segtype_is_linear(*segtype) || - (!segtype_is_raid10(*segtype) && !segtype_is_striped(*segtype))) + (!segtype_is_raid4(*segtype) && !segtype_is_raid10(*segtype) && !segtype_is_striped(*segtype))) seg_flag = SEG_RAID5_N; /* raid1 -> */ @@ -6199,10 +6199,9 @@ static int _set_convenient_raid145610_segtype_to(const struct lv_segment *seg_fr lvseg_name(seg_from), display_lvname(seg_from->lv), *new_image_count); } - /* raid4 -> !raid4/raid5* */ - } else if (seg_is_raid4(seg_from) && - !segtype_is_raid4(*segtype) && !segtype_is_any_raid5(*segtype)) { - seg_flag = SEG_RAID5_N; + /* raid4 -> * */ + } else if (seg_is_raid4(seg_from) && !segtype_is_raid4(*segtype) && !segtype_is_striped(*segtype)) { + seg_flag = segtype_is_any_raid6(*segtype) ? SEG_RAID6_N_6 : SEG_RAID5_N; /* raid6 -> striped/raid0/raid5/raid10 */ } else if (seg_is_any_raid6(seg_from)) {

1 0

master - test: comment fixes
by Heinz Mauelshagen 31 Aug '18

31 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=61600f8fa7e150b02c1be… Commit: 61600f8fa7e150b02c1be5e1f8ee1b008b4efa90 Parent: fa0a04236c613fb82e3cd559c6b451f5eb7102ad Author: Heinz Mauelshagen <heinzm(a)redhat.com> AuthorDate: Fri Aug 31 15:07:24 2018 +0200 Committer: Heinz Mauelshagen <heinzm(a)redhat.com> CommitterDate: Fri Aug 31 15:09:55 2018 +0200 test: comment fixes Fix comments in test/shell/lvconvert-raid-reshape-stripes-load-fail.sh test/shell/lvconvert-raid-reshape-stripes-load-reload.sh test/shell/lvconvert-raid-reshape-stripes-load.sh --- .../lvconvert-raid-reshape-stripes-load-fail.sh | 2 +- .../lvconvert-raid-reshape-stripes-load-reload.sh | 2 +- test/shell/lvconvert-raid-reshape-stripes-load.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/shell/lvconvert-raid-reshape-stripes-load-fail.sh b/test/shell/lvconvert-raid-reshape-stripes-load-fail.sh index c7ccad8..5fa21dc 100644 --- a/test/shell/lvconvert-raid-reshape-stripes-load-fail.sh +++ b/test/shell/lvconvert-raid-reshape-stripes-load-fail.sh @@ -39,7 +39,7 @@ vgcreate $SHARED -s 1M "$vg" "${DEVICES[@]}" trap 'cleanup_mounted_and_teardown' EXIT -# Create 13-way striped raid5 (14 legs total) +# Create 10-way striped raid5 (11 legs total) lvcreate --yes --type raid5_ls --stripesize 64K --stripes 10 -L200M -n$lv1 $vg check lv_first_seg_field $vg/$lv1 segtype "raid5_ls" check lv_first_seg_field $vg/$lv1 stripesize "64.00k" diff --git a/test/shell/lvconvert-raid-reshape-stripes-load-reload.sh b/test/shell/lvconvert-raid-reshape-stripes-load-reload.sh index 839e704..f317b7e 100644 --- a/test/shell/lvconvert-raid-reshape-stripes-load-reload.sh +++ b/test/shell/lvconvert-raid-reshape-stripes-load-reload.sh @@ -39,7 +39,7 @@ vgcreate $SHARED -s 1M "$vg" "${DEVICES[@]}" trap 'cleanup_mounted_and_teardown' EXIT -# Create 13-way striped raid5 (14 legs total) +# Create 10-way striped raid5 (11 legs total) lvcreate --yes --type raid5_ls --stripesize 64K --stripes 10 -L200M -n$lv1 $vg check lv_first_seg_field $vg/$lv1 segtype "raid5_ls" check lv_first_seg_field $vg/$lv1 stripesize "64.00k" diff --git a/test/shell/lvconvert-raid-reshape-stripes-load.sh b/test/shell/lvconvert-raid-reshape-stripes-load.sh index 29790aa..dd04798 100644 --- a/test/shell/lvconvert-raid-reshape-stripes-load.sh +++ b/test/shell/lvconvert-raid-reshape-stripes-load.sh @@ -39,7 +39,7 @@ vgcreate $SHARED -s 1M "$vg" "${DEVICES[@]}" trap 'cleanup_mounted_and_teardown' EXIT -# Create 13-way striped raid5 (14 legs total) +# Create 10-way striped raid5 (11 legs total) lvcreate --yes --type raid5_ls --stripesize 64K --stripes 10 -L200M -n$lv1 $vg check lv_first_seg_field $vg/$lv1 segtype "raid5_ls" check lv_first_seg_field $vg/$lv1 stripesize "64.00k"

1 0

master - tests: add scan-lvs
by David Teigland 30 Aug '18

30 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=fa0a04236c613fb82e3cd… Commit: fa0a04236c613fb82e3cd559c6b451f5eb7102ad Parent: bfcecbbce182570d040f3ec446dccb84ca07efcd Author: David Teigland <teigland(a)redhat.com> AuthorDate: Thu Aug 30 09:54:02 2018 -0500 Committer: David Teigland <teigland(a)redhat.com> CommitterDate: Thu Aug 30 10:00:36 2018 -0500 tests: add scan-lvs --- test/shell/scan-lvs.sh | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 47 insertions(+), 0 deletions(-) diff --git a/test/shell/scan-lvs.sh b/test/shell/scan-lvs.sh new file mode 100644 index 0000000..8e8a77d --- /dev/null +++ b/test/shell/scan-lvs.sh @@ -0,0 +1,47 @@ +#!/bin/bash +# Copyright (C) 2014 Red Hat, Inc. All rights reserved. +# +# This copyrighted material is made available to anyone wishing to use, +# modify, copy, or redistribute it subject to the terms and conditions +# of the GNU General Public License v.2. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software Foundation, +# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + +# Test scan_lvs config setting + +SKIP_WITH_LVMPOLLD=1 + +. lib/inittest + +aux extend_filter_LVMTEST + +aux lvmconf 'devices/scan_lvs = 1' + +aux prepare_pvs 1 + +vgcreate $SHARED $vg1 "$dev1" + +lvcreate -l1 -n $lv1 $vg1 + +pvcreate "$DM_DEV_DIR/$vg1/$lv1" + +pvs "$DM_DEV_DIR/$vg1/$lv1" + +aux lvmconf 'devices/scan_lvs = 0' + +not pvs "$DM_DEV_DIR/$vg1/$lv1" + +pvs --config devices/scan_lvs=1 "$DM_DEV_DIR/$vg1/$lv1" + +not pvremove "$DM_DEV_DIR/$vg1/$lv1" + +pvremove --config devices/scan_lvs=1 "$DM_DEV_DIR/$vg1/$lv1" + +lvchange -an "$vg1/$lv1" + +lvremove "$vg1/$lv1" + +vgremove $vg1 +

1 0

master - filter: add config setting to skip scanning LVs
by David Teigland 30 Aug '18

30 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=bfcecbbce182570d040f3… Commit: bfcecbbce182570d040f3ec446dccb84ca07efcd Parent: a0f6f188416823c2d32bb54bddff00e09f4426e4 Author: David Teigland <teigland(a)redhat.com> AuthorDate: Wed Aug 29 13:14:18 2018 -0500 Committer: David Teigland <teigland(a)redhat.com> CommitterDate: Thu Aug 30 09:59:50 2018 -0500 filter: add config setting to skip scanning LVs devices/scan_lvs (default 1) determines whether lvm will scan LVs for layered PVs. The lvm behavior has always been to scan LVs, but it's rare for LVs to have layered PVs, and much more common for there to be many LVs that substantially slow down scanning with no benefit. This is implemented in the usable filter, and has the same effect as listing all LVs in the global_filter. --- lib/activate/activate.h | 1 + lib/activate/dev_manager.c | 5 +++++ lib/commands/toolcontext.c | 2 +- lib/config/config_settings.h | 3 +++ lib/config/defaults.h | 2 ++ lib/filters/filter-usable.c | 27 ++++++++++++++++++++++----- lib/filters/filter.h | 2 +- 7 files changed, 35 insertions(+), 7 deletions(-) diff --git a/lib/activate/activate.h b/lib/activate/activate.h index cca2504..9530c36 100644 --- a/lib/activate/activate.h +++ b/lib/activate/activate.h @@ -240,6 +240,7 @@ struct dev_usable_check_params { unsigned int check_suspended:1; unsigned int check_error_target:1; unsigned int check_reserved:1; + unsigned int check_lv:1; }; /* diff --git a/lib/activate/dev_manager.c b/lib/activate/dev_manager.c index 43dba8c..67a49be 100644 --- a/lib/activate/dev_manager.c +++ b/lib/activate/dev_manager.c @@ -648,6 +648,11 @@ int device_is_usable(struct device *dev, struct dev_usable_check_params check) } } + if (check.check_lv && uuid && !strncmp(uuid, "LVM-", 4)) { + /* Skip LVs */ + goto out; + } + if (check.check_reserved && uuid && (!strncmp(uuid, CRYPT_TEMP, sizeof(CRYPT_TEMP) - 1) || !strncmp(uuid, STRATIS, sizeof(STRATIS) - 1))) { diff --git a/lib/commands/toolcontext.c b/lib/commands/toolcontext.c index 961962c..fa87bcc 100644 --- a/lib/commands/toolcontext.c +++ b/lib/commands/toolcontext.c @@ -1088,7 +1088,7 @@ static struct dev_filter *_init_lvmetad_filter_chain(struct cmd_context *cmd) nr_filt++; /* usable device filter. Required. */ - if (!(filters[nr_filt] = usable_filter_create(cmd->dev_types, FILTER_MODE_NO_LVMETAD))) { + if (!(filters[nr_filt] = usable_filter_create(cmd, cmd->dev_types, FILTER_MODE_NO_LVMETAD))) { log_error("Failed to create usabled device filter"); goto bad; } diff --git a/lib/config/config_settings.h b/lib/config/config_settings.h index 1d0cc79..b47b225 100644 --- a/lib/config/config_settings.h +++ b/lib/config/config_settings.h @@ -337,6 +337,9 @@ cfg(devices_sysfs_scan_CFG, "sysfs_scan", devices_CFG_SECTION, 0, CFG_TYPE_BOOL, "This is a quick way of filtering out block devices that are not\n" "present on the system. sysfs must be part of the kernel and mounted.)\n") +cfg(devices_scan_lvs_CFG, "scan_lvs", devices_CFG_SECTION, 0, CFG_TYPE_BOOL, DEFAULT_SCAN_LVS, vsn(2, 2, 182), NULL, 0, NULL, + "Scan LVM LVs for layered PVs.\n") + cfg(devices_multipath_component_detection_CFG, "multipath_component_detection", devices_CFG_SECTION, 0, CFG_TYPE_BOOL, DEFAULT_MULTIPATH_COMPONENT_DETECTION, vsn(2, 2, 89), NULL, 0, NULL, "Ignore devices that are components of DM multipath devices.\n") diff --git a/lib/config/defaults.h b/lib/config/defaults.h index 9928fb1..9fbe8c2 100644 --- a/lib/config/defaults.h +++ b/lib/config/defaults.h @@ -300,4 +300,6 @@ #define DEFAULT_VDO_POOL_AUTOEXTEND_THRESHOLD 100 #define DEFAULT_VDO_POOL_AUTOEXTEND_PERCENT 20 +#define DEFAULT_SCAN_LVS 1 + #endif /* _LVM_DEFAULTS_H */ diff --git a/lib/filters/filter-usable.c b/lib/filters/filter-usable.c index ab5c02f..6997368 100644 --- a/lib/filters/filter-usable.c +++ b/lib/filters/filter-usable.c @@ -21,6 +21,11 @@ #include "lib/device/dev-ext-udev-constants.h" #endif +struct filter_data { + filter_mode_t mode; + int skip_lvs; +}; + static const char *_too_small_to_hold_pv_msg = "Too small to hold a PV"; static int _native_check_pv_min_size(struct device *dev) @@ -102,7 +107,9 @@ static int _check_pv_min_size(struct device *dev) static int _passes_usable_filter(struct cmd_context *cmd, struct dev_filter *f, struct device *dev) { - filter_mode_t mode = *((filter_mode_t *) f->private); + struct filter_data *data = f->private; + filter_mode_t mode = data->mode; + int skip_lvs = data->skip_lvs; struct dev_usable_check_params ucp = {0}; int r = 1; @@ -115,6 +122,7 @@ static int _passes_usable_filter(struct cmd_context *cmd, struct dev_filter *f, ucp.check_suspended = ignore_suspended_devices(); ucp.check_error_target = 1; ucp.check_reserved = 1; + ucp.check_lv = skip_lvs; break; case FILTER_MODE_PRE_LVMETAD: ucp.check_empty = 1; @@ -122,6 +130,7 @@ static int _passes_usable_filter(struct cmd_context *cmd, struct dev_filter *f, ucp.check_suspended = 0; ucp.check_error_target = 1; ucp.check_reserved = 1; + ucp.check_lv = skip_lvs; break; case FILTER_MODE_POST_LVMETAD: ucp.check_empty = 0; @@ -129,6 +138,7 @@ static int _passes_usable_filter(struct cmd_context *cmd, struct dev_filter *f, ucp.check_suspended = ignore_suspended_devices(); ucp.check_error_target = 0; ucp.check_reserved = 0; + ucp.check_lv = skip_lvs; break; } @@ -162,8 +172,9 @@ static void _usable_filter_destroy(struct dev_filter *f) free(f); } -struct dev_filter *usable_filter_create(struct dev_types *dt __attribute__((unused)), filter_mode_t mode) +struct dev_filter *usable_filter_create(struct cmd_context *cmd, struct dev_types *dt __attribute__((unused)), filter_mode_t mode) { + struct filter_data *data; struct dev_filter *f; if (!(f = zalloc(sizeof(struct dev_filter)))) { @@ -174,14 +185,20 @@ struct dev_filter *usable_filter_create(struct dev_types *dt __attribute__((unus f->passes_filter = _passes_usable_filter; f->destroy = _usable_filter_destroy; f->use_count = 0; - if (!(f->private = zalloc(sizeof(filter_mode_t)))) { + + if (!(data = zalloc(sizeof(struct filter_data)))) { log_error("Usable device filter mode allocation failed"); free(f); return NULL; } - *((filter_mode_t *) f->private) = mode; - log_debug_devs("Usable device filter initialised."); + data->mode = mode; + + data->skip_lvs = !find_config_tree_bool(cmd, devices_scan_lvs_CFG, NULL); + + f->private = data; + + log_debug_devs("Usable device filter initialised (scan_lvs %d).", !data->skip_lvs); return f; } diff --git a/lib/filters/filter.h b/lib/filters/filter.h index cdd5a14..7333cfe 100644 --- a/lib/filters/filter.h +++ b/lib/filters/filter.h @@ -50,6 +50,6 @@ typedef enum { FILTER_MODE_PRE_LVMETAD, FILTER_MODE_POST_LVMETAD } filter_mode_t; -struct dev_filter *usable_filter_create(struct dev_types *dt, filter_mode_t mode); +struct dev_filter *usable_filter_create(struct cmd_context *cmd, struct dev_types *dt, filter_mode_t mode); #endif /* _LVM_FILTER_H */

1 0

master - configure: fix LVMCONFIG_PATH assignment
by Peter Rajnoha 30 Aug '18

30 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=a0f6f188416823c2d32bb… Commit: a0f6f188416823c2d32bb54bddff00e09f4426e4 Parent: 03ed2aae3a54afcc521a1af9b8a62827c1fb76d6 Author: Peter Rajnoha <prajnoha(a)redhat.com> AuthorDate: Thu Aug 30 12:59:59 2018 +0200 Committer: Peter Rajnoha <prajnoha(a)redhat.com> CommitterDate: Thu Aug 30 13:14:10 2018 +0200 configure: fix LVMCONFIG_PATH assignment --- configure | 2 +- configure.ac | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 4ad2d4d..d6ddbc2 100755 --- a/configure +++ b/configure @@ -13417,7 +13417,7 @@ cat >>confdefs.h <<_ACEOF _ACEOF -LVMCONFIG_PATH="$$BINDIR/lvmconfig" +LVMCONFIG_PATH="$SBINDIR/lvmconfig" cat >>confdefs.h <<_ACEOF #define LVMCONFIG_PATH "$LVMCONFIG_PATH" diff --git a/configure.ac b/configure.ac index 8f5349f..6d9308f 100644 --- a/configure.ac +++ b/configure.ac @@ -1494,7 +1494,7 @@ SBINDIR="$(eval echo $(eval echo $sbindir))" LVM_PATH="$SBINDIR/lvm" AC_DEFINE_UNQUOTED(LVM_PATH, ["$LVM_PATH"], [Path to lvm binary.]) -LVMCONFIG_PATH="$$BINDIR/lvmconfig" +LVMCONFIG_PATH="$SBINDIR/lvmconfig" AC_DEFINE_UNQUOTED(LVMCONFIG_PATH, ["$LVMCONFIG_PATH"], [Path to lvmconfig binary.]) USRSBINDIR="$(eval echo $(eval echo $usrsbindir))"

1 0

master - scripts: lvm2-activation-generator: also log possible execv error
by Peter Rajnoha 30 Aug '18

30 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=03ed2aae3a54afcc521a1… Commit: 03ed2aae3a54afcc521a1af9b8a62827c1fb76d6 Parent: 3d5c4847b663c42573ffabba7f26f30196f54d82 Author: Peter Rajnoha <prajnoha(a)redhat.com> AuthorDate: Thu Aug 30 12:48:50 2018 +0200 Committer: Peter Rajnoha <prajnoha(a)redhat.com> CommitterDate: Thu Aug 30 13:14:10 2018 +0200 scripts: lvm2-activation-generator: also log possible execv error --- scripts/generator-internals.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/scripts/generator-internals.c b/scripts/generator-internals.c index c38323b..00a15e5 100644 --- a/scripts/generator-internals.c +++ b/scripts/generator-internals.c @@ -56,7 +56,8 @@ static bool _open_child(struct child_process *child, const char *cmd, const char close(pipe_fd[1]); } - execv(cmd, (char *const *) argv); + if (execv(cmd, (char *const *) argv) < 0) + _error("execv failed: %s\n", strerror(errno)); // Shouldn't get here unless exec failed. exit(1); } else {

1 0

master - scripts: lvm2-activation-generator: add prefix for all kmsg messages
by Peter Rajnoha 30 Aug '18

30 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=3d5c4847b663c42573ffa… Commit: 3d5c4847b663c42573ffabba7f26f30196f54d82 Parent: cb17ef221bdefea3625a22c19c6d8f5504441771 Author: Peter Rajnoha <prajnoha(a)redhat.com> AuthorDate: Thu Aug 30 12:46:41 2018 +0200 Committer: Peter Rajnoha <prajnoha(a)redhat.com> CommitterDate: Thu Aug 30 13:14:10 2018 +0200 scripts: lvm2-activation-generator: add prefix for all kmsg messages Add "lvm2-activation-generator: " prefix for all kmsg messages written by lvm2-activation-generator so we can identify the message in global system log. --- WHATS_NEW | 1 + .../lvm2_activation_generator_systemd_red_hat.c | 24 ++++++++++---------- 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 8489252..6003f0a 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 3.0.0 ============= + Add 'lvm2-activation-generator:' prefix for kmsg messages logged by generator. Add After=rbdmap.service to {lvm2-activation-net,blk-availability}.service. Reduce max concurrent aios to avoid EMFILE with many devices. Fix lvconvert conversion attempts to linear. diff --git a/scripts/lvm2_activation_generator_systemd_red_hat.c b/scripts/lvm2_activation_generator_systemd_red_hat.c index b751841..5dc39ae 100644 --- a/scripts/lvm2_activation_generator_systemd_red_hat.c +++ b/scripts/lvm2_activation_generator_systemd_red_hat.c @@ -57,19 +57,19 @@ static void _error(const char *format, ...) { int n; va_list ap; - char message[PATH_MAX + 3]; /* +3 for '<n>' where n is the log level */ + char message[PATH_MAX + 30]; /* +3 for '<n>' where n is the log level and +27 for lvm2-activation-generator: " prefix */ - snprintf(message, 4, "<%d>", LOG_ERR); + snprintf(message, 31, "<%d>lvm2-activation-generator: ", LOG_ERR); va_start(ap, format); - n = vsnprintf(message + 3, PATH_MAX, format, ap); + n = vsnprintf(message + 30, PATH_MAX, format, ap); va_end(ap); if (_kmsg_fd < 0 || (n < 0 || ((unsigned) n + 1 > PATH_MAX))) return; - /* The n+4: +3 for "<n>" prefix and +1 for '\0' suffix */ - (void) write(_kmsg_fd, message, n + 4); + /* The n+31: +30 for "<n>lvm2-activation-generator: " prefix and +1 for '\0' suffix */ + (void) write(_kmsg_fd, message, n + 31); } //---------------------------------------------------------------- @@ -112,7 +112,7 @@ static int register_unit_with_target(struct generator *gen, const char *unit, (void) dm_prepare_selinux_context(gen->target_path, S_IFDIR); if (mkdir(gen->target_path, 0755) < 0 && errno != EEXIST) { - _error("LVM: Failed to create target directory %s: %m.\n", gen->target_path); + _error("Failed to create target directory %s: %m.\n", gen->target_path); r = 0; goto out; } @@ -124,7 +124,7 @@ static int register_unit_with_target(struct generator *gen, const char *unit, } (void) dm_prepare_selinux_context(gen->target_path, S_IFLNK); if (symlink(gen->unit_path, gen->target_path) < 0) { - _error("LVM: Failed to create symlink for unit %s: %m.\n", unit); + _error("Failed to create symlink for unit %s: %m.\n", unit); r = 0; } out: @@ -144,7 +144,7 @@ static int generate_unit(struct generator *gen, int unit) return 0; if (!(f = fopen(gen->unit_path, "wxe"))) { - _error("LVM: Failed to create unit file %s: %m.\n", unit_name); + _error("Failed to create unit file %s: %m.\n", unit_name); return 0; } @@ -181,12 +181,12 @@ static int generate_unit(struct generator *gen, int unit) fputs("\nType=oneshot\n", f); if (fclose(f) < 0) { - _error("LVM: Failed to write unit file %s: %m.\n", unit_name); + _error("Failed to write unit file %s: %m.\n", unit_name); return 0; } if (!register_unit_with_target(gen, unit_name, target_name)) { - _error("LVM: Failed to register unit %s with target %s.\n", + _error("Failed to register unit %s with target %s.\n", unit_name, target_name); return 0; } @@ -197,7 +197,7 @@ static int generate_unit(struct generator *gen, int unit) static bool _parse_command_line(struct generator *gen, int argc, const char **argv) { if (argc != 4) { - _error("LVM: Incorrect number of arguments for activation generator.\n"); + _error("Incorrect number of arguments for activation generator.\n"); return false; } @@ -239,7 +239,7 @@ int main(int argc, const char **argv) _log_init(); r = _run(argc, argv); if (!r) - _error("LVM: Activation generator failed.\n"); + _error("Activation generator failed.\n"); _log_exit(); return r ? EXIT_SUCCESS : EXIT_FAILURE;

1 0

master - scripts: add After=rbdmap.service to {lvm2-activation-net, blk-availability}.service
by Peter Rajnoha 30 Aug '18

30 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=cb17ef221bdefea3625a2… Commit: cb17ef221bdefea3625a22c19c6d8f5504441771 Parent: fade9ca3b6ee1432ae8c2878815bbf871cacf92d Author: Peter Rajnoha <prajnoha(a)redhat.com> AuthorDate: Thu Aug 30 12:35:58 2018 +0200 Committer: Peter Rajnoha <prajnoha(a)redhat.com> CommitterDate: Thu Aug 30 12:35:58 2018 +0200 scripts: add After=rbdmap.service to {lvm2-activation-net,blk-availability}.service We need to have Ceph RBD devices mapped first before use in a stack where LVM is on top so make sure rbdmap.service is called before generated lvm2-activation-net.service. On shutdown, we need to stop blk-availability first before we stop the rbdmap.service. Resolves: rhbz1623479 --- WHATS_NEW | 1 + .../blk_availability_systemd_red_hat.service.in | 2 +- .../lvm2_activation_generator_systemd_red_hat.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index bf03c49..8489252 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 3.0.0 ============= + Add After=rbdmap.service to {lvm2-activation-net,blk-availability}.service. Reduce max concurrent aios to avoid EMFILE with many devices. Fix lvconvert conversion attempts to linear. Fix lvconvert raid0/raid0_meta -> striped regression. diff --git a/scripts/blk_availability_systemd_red_hat.service.in b/scripts/blk_availability_systemd_red_hat.service.in index 1198baa..9462072 100644 --- a/scripts/blk_availability_systemd_red_hat.service.in +++ b/scripts/blk_availability_systemd_red_hat.service.in @@ -1,6 +1,6 @@ [Unit] Description=Availability of block devices -After=lvm2-activation.service lvm2-lvmetad.service iscsi-shutdown.service iscsi.service iscsid.service fcoe.service +After=lvm2-activation.service lvm2-lvmetad.service iscsi-shutdown.service iscsi.service iscsid.service fcoe.service rbdmap.service DefaultDependencies=no Conflicts=shutdown.target diff --git a/scripts/lvm2_activation_generator_systemd_red_hat.c b/scripts/lvm2_activation_generator_systemd_red_hat.c index b3d18d2..b751841 100644 --- a/scripts/lvm2_activation_generator_systemd_red_hat.c +++ b/scripts/lvm2_activation_generator_systemd_red_hat.c @@ -160,7 +160,7 @@ static int generate_unit(struct generator *gen, int unit) "SourcePath=/etc/lvm/lvm.conf\n" "DefaultDependencies=no\n", f); if (unit == UNIT_NET) { - fprintf(f, "After=%s iscsi.service fcoe.service\n" + fprintf(f, "After=%s iscsi.service fcoe.service rbdmap.service\n" "Before=remote-fs-pre.target shutdown.target\n\n" "[Service]\n" "ExecStartPre=/usr/bin/udevadm settle\n", _unit_names[UNIT_MAIN]);

1 0

master - bcache: reduce MAX_IO to 256
by David Teigland 24 Aug '18

24 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=fade9ca3b6ee1432ae8c2… Commit: fade9ca3b6ee1432ae8c2878815bbf871cacf92d Parent: 3c966e637fe1bec587ceb9ad13aa009db64b4f8e Author: David Teigland <teigland(a)redhat.com> AuthorDate: Fri Aug 24 14:46:51 2018 -0500 Committer: David Teigland <teigland(a)redhat.com> CommitterDate: Fri Aug 24 14:55:12 2018 -0500 bcache: reduce MAX_IO to 256 This is the number of concurrent async io requests that the scan layer will submit to the bcache layer. There will be an open fd for each of these, so it is best to keep this well below the default limit for max open files (1024), otherwise lvm may get EMFILE from open(2) when there are around 1024 devices to scan on the system. --- WHATS_NEW | 1 + lib/device/bcache.c | 10 +++++++++- 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index fd1b732..bf03c49 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 3.0.0 ============= + Reduce max concurrent aios to avoid EMFILE with many devices. Fix lvconvert conversion attempts to linear. Fix lvconvert raid0/raid0_meta -> striped regression. Fix lvconvert --splitmirror for mirror type (2.02.178). diff --git a/lib/device/bcache.c b/lib/device/bcache.c index 8d55c36..e759997 100644 --- a/lib/device/bcache.c +++ b/lib/device/bcache.c @@ -198,7 +198,15 @@ static bool _async_issue(struct io_engine *ioe, enum dir d, int fd, return true; } -#define MAX_IO 1024 +/* + * MAX_IO is returned to the layer above via bcache_max_prefetches() which + * tells the caller how many devices to submit io for concurrently. There will + * be an open file descriptor for each of these, so keep it low enough to avoid + * reaching the default max open file limit (1024) when there are over 1024 + * devices being scanned. + */ + +#define MAX_IO 256 #define MAX_EVENT 64 static bool _async_wait(struct io_engine *ioe, io_complete_fn fn)

1 0

master - test: add striped -> raid0 test script
by Heinz Mauelshagen 22 Aug '18

22 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=3c966e637fe1bec587ceb… Commit: 3c966e637fe1bec587ceb9ad13aa009db64b4f8e Parent: e83c4f07ca4a84808178d5d22cba655e5e370cd8 Author: Heinz Mauelshagen <heinzm(a)redhat.com> AuthorDate: Wed Aug 22 17:11:03 2018 +0200 Committer: Heinz Mauelshagen <heinzm(a)redhat.com> CommitterDate: Wed Aug 22 17:12:44 2018 +0200 test: add striped -> raid0 test script --- test/shell/lvconvert-striped-raid0.sh | 25 +++++++++++++++++++++++++ 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/test/shell/lvconvert-striped-raid0.sh b/test/shell/lvconvert-striped-raid0.sh new file mode 100644 index 0000000..5cfb792 --- /dev/null +++ b/test/shell/lvconvert-striped-raid0.sh @@ -0,0 +1,25 @@ +#!/usr/bin/env bash + +# Copyright (C) 2018 Red Hat, Inc. All rights reserved. +# +# This copyrighted material is made available to anyone wishing to use, +# modify, copy, or redistribute it subject to the terms and conditions +# of the GNU General Public License v.2. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software Foundation, +# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + + +SKIP_WITH_LVMPOLLD=1 + +. lib/inittest + +aux have_raid 1 7 0 || skip + +aux prepare_vg 3 16 + +lvcreate -aey --type striped -i 3 -l3 -n $lv $vg +lvconvert -y --type raid0_meta $vg/$lv +check lv_field $vg/$lv segtype "raid0_meta" +vgremove -ff $vg

1 0

master - lvconvert: fix conversion attempts to linear
by Heinz Mauelshagen 22 Aug '18

22 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=e83c4f07ca4a84808178d… Commit: e83c4f07ca4a84808178d5d22cba655e5e370cd8 Parent: 10ede2cc0fdabaeb19c5b5b3341164432f6d4425 Author: Heinz Mauelshagen <heinzm(a)redhat.com> AuthorDate: Wed Aug 22 16:39:36 2018 +0200 Committer: Heinz Mauelshagen <heinzm(a)redhat.com> CommitterDate: Wed Aug 22 17:12:43 2018 +0200 lvconvert: fix conversion attempts to linear "lvconvert --type linear RaidLV" on striped and raid4/5/6/10 have to provide the convenient interim layouts. Fix involves a cleanup to the convenience type function. As a result of testing, add missing sync waits to lvconvert-raid-reshape-linear_to_raid6-single-type.sh. Resolves: rhbz1447809 --- WHATS_NEW | 1 + lib/metadata/raid_manip.c | 147 +++++++++----------- ...ert-raid-reshape-linear_to_raid6-single-type.sh | 2 + 3 files changed, 69 insertions(+), 81 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 0ea2789..fd1b732 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 3.0.0 ============= + Fix lvconvert conversion attempts to linear. Fix lvconvert raid0/raid0_meta -> striped regression. Fix lvconvert --splitmirror for mirror type (2.02.178). Do not pair cache policy and cache metadata format. diff --git a/lib/metadata/raid_manip.c b/lib/metadata/raid_manip.c index 5441527..6cbf601 100644 --- a/lib/metadata/raid_manip.c +++ b/lib/metadata/raid_manip.c @@ -6110,8 +6110,7 @@ static int _set_convenient_raid145610_segtype_to(const struct lv_segment *seg_fr const struct segment_type *segtype_sav = *segtype; /* Linear -> striped request */ - if (seg_is_striped(seg_from) && - seg_from->area_count == 1 && + if (seg_is_linear(seg_from) && segtype_is_striped(*segtype)) ; /* Bail out if same RAID level is requested. */ @@ -6120,24 +6119,20 @@ static int _set_convenient_raid145610_segtype_to(const struct lv_segment *seg_fr log_debug("Checking LV %s requested %s segment type for convenience", display_lvname(seg_from->lv), (*segtype)->name); - /* striped/raid0 -> raid5/6 */ - if (seg_is_striped(seg_from) || seg_is_any_raid0(seg_from)) { - /* linear -> raid*, interim/first conversion is to raid1 */ - if (seg_from->area_count == 1) - seg_flag = SEG_RAID1; - - else if (seg_is_any_raid0(seg_from) && segtype_is_striped(*segtype)) - ; - - /* If this is any raid5 conversion request -> enforce raid5_n, because we convert from striped */ - else if (((segtype_is_striped(*segtype) && !segtype_is_any_raid0(*segtype)) || segtype_is_any_raid5(*segtype)) && - !segtype_is_raid5_n(*segtype)) - seg_flag = SEG_RAID5_N; - /* If this is any raid6 conversion request -> enforce raid6_n_6, because we convert from striped */ - else if (segtype_is_any_raid6(*segtype) && !segtype_is_raid6_n_6(*segtype)) + /* linear -> */ + if (seg_is_linear(seg_from)) { + seg_flag = SEG_RAID1; + + /* striped/raid0 -> */ + } else if (seg_is_striped(seg_from) || seg_is_any_raid0(seg_from)) { + if (segtype_is_any_raid6(*segtype)) seg_flag = SEG_RAID6_N_6; + if (segtype_is_linear(*segtype) || + (!segtype_is_raid10(*segtype) && !segtype_is_striped(*segtype))) + seg_flag = SEG_RAID5_N; + /* raid1 -> */ } else if (seg_is_raid1(seg_from) && !segtype_is_mirror(*segtype)) { if (seg_from->area_count != 2) { @@ -6147,85 +6142,68 @@ static int _set_convenient_raid145610_segtype_to(const struct lv_segment *seg_fr } if (segtype_is_striped(*segtype) || - segtype_is_any_raid0(*segtype) || - segtype_is_raid10(*segtype)) + segtype_is_any_raid0(*segtype) || + segtype_is_raid10(*segtype)) seg_flag = SEG_RAID5_N; else if (!segtype_is_raid4(*segtype) && !segtype_is_any_raid5(*segtype)) seg_flag = SEG_RAID5_LS; - /* raid4/raid5 -> striped/raid0/raid1/raid6/raid10 */ - } else if (seg_is_raid4(seg_from) || seg_is_any_raid5(seg_from)) { - if ((segtype_is_raid1(*segtype) || segtype_is_linear(*segtype)) && seg_is_raid5_n(seg_from)) { + /* raid5* -> */ + } else if (seg_is_any_raid5(seg_from)) { + if (segtype_is_raid1(*segtype) || segtype_is_linear(*segtype)) { if (seg_from->area_count != 2) { log_error("Converting %s LV %s to 2 stripes first.", lvseg_name(seg_from), display_lvname(seg_from->lv)); *new_image_count = 2; - seg_flag = SEG_RAID5_N; + *segtype = seg_from->segtype; + seg_flag = 0; } else seg_flag = SEG_RAID1; - } else if (segtype_is_raid1(*segtype) && seg_from->area_count != 2) { - log_error("Convert %s LV %s to 2 stripes first (i.e. --stripes 1).", - lvseg_name(seg_from), display_lvname(seg_from->lv)); - return 0; - - } else if (seg_is_raid4(seg_from) && - (segtype_is_linear(*segtype) || segtype_is_any_raid5(*segtype)) && - !segtype_is_raid5_n(*segtype)) - seg_flag = SEG_RAID5_N; + } else if (segtype_is_any_raid6(*segtype)) { + if (seg_from->area_count < 4) { + if (*stripes > 3) + *new_image_count = *stripes + seg_from->segtype->parity_devs; + else + *new_image_count = 4; - else if (seg_is_raid5_n(seg_from) && seg_from->area_count == 2) { - if (*stripes >= 2) { + *segtype = seg_from->segtype; log_error("Converting %s LV %s to %u stripes first.", - lvseg_name(seg_from), display_lvname(seg_from->lv), *stripes); + lvseg_name(seg_from), display_lvname(seg_from->lv), *new_image_count); + + } else + seg_flag = _raid_seg_flag_5_to_6(seg_from); + + } else if (segtype_is_striped(*segtype) || segtype_is_raid10(*segtype)) { + int change = 0; + + if (!seg_is_raid5_n(seg_from)) { + seg_flag = SEG_RAID5_N; + + } else if (*stripes > 2 && *stripes != seg_from->area_count - seg_from->segtype->parity_devs) { + change = 1; *new_image_count = *stripes + seg_from->segtype->parity_devs; seg_flag = SEG_RAID5_N; - } else { - log_error("Convert %s LV %s to minimum 3 stripes first (i.e. --stripes 2).", - lvseg_name(seg_from), display_lvname(seg_from->lv)); - return 0; - } - } else if (seg_is_any_raid5(seg_from) && - (segtype_is_linear(*segtype) || segtype_is_raid4(*segtype)) && - !segtype_is_raid5_n(*segtype)) - seg_flag = SEG_RAID5_N; - else if (segtype_is_raid10(*segtype)) { - if (seg_from->area_count < 3) { - if (*stripes >= 2) { - log_error("Converting %s LV %s to %u stripes first.", - lvseg_name(seg_from), display_lvname(seg_from->lv), *stripes); - *new_image_count = *stripes + seg_from->segtype->parity_devs; - seg_flag = SEG_RAID5_N; - } else { - log_error("Convert %s LV %s to minimum 3 stripes first (i.e. --stripes 2).", - lvseg_name(seg_from), display_lvname(seg_from->lv)); - return 0; - } - } else - seg_flag = seg_is_raid5_n(seg_from) ? SEG_RAID0_META : SEG_RAID5_N; + } else if (seg_from->area_count < 3) { + change = 1; + *new_image_count = 3; + seg_flag = SEG_RAID5_N; - } else if (segtype_is_any_raid6(*segtype)) { - if (seg_from->area_count < 4 && - seg_is_any_raid5(seg_from)) { - if (*stripes >= 3) { - log_error("Converting %s LV %s to %u stripes first.", - lvseg_name(seg_from), display_lvname(seg_from->lv), *stripes); - *new_image_count = *stripes + seg_from->segtype->parity_devs; - seg_flag = SEG_RAID5_LS; - } else { - log_error("Convert %s LV %s to minimum 4 stripes first (i.e. --stripes 3).", - lvseg_name(seg_from), display_lvname(seg_from->lv)); - return 0; - } + } else if (!segtype_is_striped(*segtype)) + seg_flag = SEG_RAID0_META; - } else if (seg_is_raid4(seg_from) && !segtype_is_raid6_n_6(*segtype)) - seg_flag = SEG_RAID6_N_6; - else - seg_flag = _raid_seg_flag_5_to_6(seg_from); + if (change) + log_error("Converting %s LV %s to %u stripes first.", + lvseg_name(seg_from), display_lvname(seg_from->lv), *new_image_count); } + /* raid4 -> !raid4/raid5* */ + } else if (seg_is_raid4(seg_from) && + !segtype_is_raid4(*segtype) && !segtype_is_any_raid5(*segtype)) { + seg_flag = SEG_RAID5_N; + /* raid6 -> striped/raid0/raid5/raid10 */ } else if (seg_is_any_raid6(seg_from)) { if (segtype_is_raid1(*segtype)) { @@ -6237,6 +6215,9 @@ static int _set_convenient_raid145610_segtype_to(const struct lv_segment *seg_fr } else if (segtype_is_any_raid10(*segtype)) { seg_flag = seg_is_raid6_n_6(seg_from) ? SEG_RAID0_META : SEG_RAID6_N_6; + } else if (segtype_is_linear(*segtype)) { + seg_flag = seg_is_raid6_n_6(seg_from) ? SEG_RAID5_N : SEG_RAID6_N_6; + } else if (segtype_is_striped(*segtype) || segtype_is_any_raid0(*segtype)) { if (!seg_is_raid6_n_6(seg_from)) seg_flag = SEG_RAID6_N_6; @@ -6267,12 +6248,16 @@ static int _set_convenient_raid145610_segtype_to(const struct lv_segment *seg_fr return 0; } - /* raid10 -> ... */ - } else if (seg_is_raid10(seg_from) && - !segtype_is_striped(*segtype) && - !segtype_is_any_raid0(*segtype)) - seg_flag = SEG_RAID0_META; + } else if (seg_is_raid10(seg_from)) { + if (segtype_is_linear(*segtype) || + (!segtype_is_striped(*segtype) && + !segtype_is_any_raid0(*segtype))) { + seg_flag = SEG_RAID0_META; + } + } + + /* raid10 -> ... */ if (seg_flag) { if (!(*segtype = get_segtype_from_flag(cmd, seg_flag))) return_0; diff --git a/test/shell/lvconvert-raid-reshape-linear_to_raid6-single-type.sh b/test/shell/lvconvert-raid-reshape-linear_to_raid6-single-type.sh index f01e7ef..05cb616 100644 --- a/test/shell/lvconvert-raid-reshape-linear_to_raid6-single-type.sh +++ b/test/shell/lvconvert-raid-reshape-linear_to_raid6-single-type.sh @@ -78,6 +78,7 @@ check lv_first_seg_field $vg/$lv data_stripes 3 check lv_first_seg_field $vg/$lv stripesize "64.00k" check lv_first_seg_field $vg/$lv regionsize "128.00k" check lv_first_seg_field $vg/$lv reshape_len_le 0 +aux wait_for_sync $vg $lv # Convert raid6_ls_6 -> raid6(_zr) (reshape) lvconvert -y --type raid6 --stripes 3 --stripesize 64K --regionsize 128K $vg/$lv @@ -88,6 +89,7 @@ check lv_first_seg_field $vg/$lv data_stripes 3 check lv_first_seg_field $vg/$lv stripesize "64.00k" check lv_first_seg_field $vg/$lv regionsize "128.00k" check lv_first_seg_field $vg/$lv reshape_len_le 10 +aux wait_for_sync $vg $lv # Remove reshape space lvconvert -y --type raid6 --stripes 3 --stripesize 64K --regionsize 128K $vg/$lv

1 0

master - config: improve use_blkid_wiping
by David Teigland 21 Aug '18

21 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=10ede2cc0fdabaeb19c5b… Commit: 10ede2cc0fdabaeb19c5b5b3341164432f6d4425 Parent: 4578411633a40c8c9068ff439ef3c33cbe78d25a Author: David Teigland <teigland(a)redhat.com> AuthorDate: Tue Aug 21 12:24:35 2018 -0500 Committer: David Teigland <teigland(a)redhat.com> CommitterDate: Tue Aug 21 12:24:35 2018 -0500 config: improve use_blkid_wiping mention that libblkid is used to both detect and erase signatures. --- lib/config/config_settings.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/config/config_settings.h b/lib/config/config_settings.h index 7882e95..1d0cc79 100644 --- a/lib/config/config_settings.h +++ b/lib/config/config_settings.h @@ -471,7 +471,7 @@ cfg(allocation_maximise_cling_CFG, "maximise_cling", allocation_CFG_SECTION, 0, "and revert to the previous algorithm.\n") cfg(allocation_use_blkid_wiping_CFG, "use_blkid_wiping", allocation_CFG_SECTION, 0, CFG_TYPE_BOOL, DEFAULT_USE_BLKID_WIPING, vsn(2, 2, 105), "@DEFAULT_USE_BLKID_WIPING@", 0, NULL, - "Use blkid to detect existing signatures on new PVs and LVs.\n" + "Use blkid to detect and erase existing signatures on new PVs and LVs.\n" "The blkid library can detect more signatures than the native LVM\n" "detection code, but may take longer. LVM needs to be compiled with\n" "blkid wiping support for this setting to apply. LVM native detection\n"

1 0

master - lvconvert: fix regression preventing direct striped conversion
by Heinz Mauelshagen 21 Aug '18

21 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=4578411633a40c8c9068f… Commit: 4578411633a40c8c9068ff439ef3c33cbe78d25a Parent: 8b05f1f230517aa42878aa160d94383ed0534c64 Author: Heinz Mauelshagen <heinzm(a)redhat.com> AuthorDate: Tue Aug 21 17:12:33 2018 +0200 Committer: Heinz Mauelshagen <heinzm(a)redhat.com> CommitterDate: Tue Aug 21 17:28:56 2018 +0200 lvconvert: fix regression preventing direct striped conversion Conversion to striped from raid0/raid0_meta is directly possible. Fix a regression setting superfluous interim raid5_n conversion type introduced by commit bd7cdd0b09ba123b064937fddde08daacbed7dab. Add new test script lvconvert-raid0-striped.sh. Resolves: rhbz1608067 --- WHATS_NEW | 1 + lib/metadata/raid_manip.c | 3 +++ test/shell/lvconvert-raid0-striped.sh | 25 +++++++++++++++++++++++++ 3 files changed, 29 insertions(+), 0 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 0a0b6e9..0ea2789 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 3.0.0 ============= + Fix lvconvert raid0/raid0_meta -> striped regression. Fix lvconvert --splitmirror for mirror type (2.02.178). Do not pair cache policy and cache metadata format. lvconvert: reject conversions on raid1 LVs with split tracked SubLVs diff --git a/lib/metadata/raid_manip.c b/lib/metadata/raid_manip.c index 931b411..5441527 100644 --- a/lib/metadata/raid_manip.c +++ b/lib/metadata/raid_manip.c @@ -6126,6 +6126,9 @@ static int _set_convenient_raid145610_segtype_to(const struct lv_segment *seg_fr if (seg_from->area_count == 1) seg_flag = SEG_RAID1; + else if (seg_is_any_raid0(seg_from) && segtype_is_striped(*segtype)) + ; + /* If this is any raid5 conversion request -> enforce raid5_n, because we convert from striped */ else if (((segtype_is_striped(*segtype) && !segtype_is_any_raid0(*segtype)) || segtype_is_any_raid5(*segtype)) && !segtype_is_raid5_n(*segtype)) diff --git a/test/shell/lvconvert-raid0-striped.sh b/test/shell/lvconvert-raid0-striped.sh new file mode 100644 index 0000000..4521b34 --- /dev/null +++ b/test/shell/lvconvert-raid0-striped.sh @@ -0,0 +1,25 @@ +#!/usr/bin/env bash + +# Copyright (C) 2018 Red Hat, Inc. All rights reserved. +# +# This copyrighted material is made available to anyone wishing to use, +# modify, copy, or redistribute it subject to the terms and conditions +# of the GNU General Public License v.2. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software Foundation, +# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + + +SKIP_WITH_LVMPOLLD=1 + +. lib/inittest + +aux have_raid 1 7 0 || skip + +aux prepare_vg 3 16 + +lvcreate -aey --type raid0 -i 3 -l3 -n $lv $vg +lvconvert -y --type striped $vg/$lv +check lv_field $vg/$lv segtype "striped" +vgremove -ff $vg

1 0

master - radix-tree: Fix bug in remove_prefix()
by Joe Thornber 20 Aug '18

20 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=8b05f1f230517aa42878a… Commit: 8b05f1f230517aa42878aa160d94383ed0534c64 Parent: 54668feaabead997cdf099c970999af667bcf274 Author: Joe Thornber <ejt(a)redhat.com> AuthorDate: Mon Aug 20 15:23:40 2018 +0100 Committer: Joe Thornber <ejt(a)redhat.com> CommitterDate: Mon Aug 20 15:23:40 2018 +0100 radix-tree: Fix bug in remove_prefix() Accidental decrement of the nr entries when a n256 didn't have the entry in the first place. --- base/data-struct/radix-tree.c | 3 + test/unit/radix_tree_t.c | 116 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 119 insertions(+), 0 deletions(-) diff --git a/base/data-struct/radix-tree.c b/base/data-struct/radix-tree.c index 1d24dad..1eef1f8 100644 --- a/base/data-struct/radix-tree.c +++ b/base/data-struct/radix-tree.c @@ -907,6 +907,9 @@ static bool _remove_subtree(struct radix_tree *rt, struct value *root, uint8_t * case NODE256: n256 = root->value.ptr; + if (n256->values[*kb].type == UNSET) + return true; // No entries + r = _remove_subtree(rt, n256->values + (*kb), kb + 1, ke, count); if (r && n256->values[*kb].type == UNSET) { n256->nr_entries--; diff --git a/test/unit/radix_tree_t.c b/test/unit/radix_tree_t.c index e5d3e98..0dde6b7 100644 --- a/test/unit/radix_tree_t.c +++ b/test/unit/radix_tree_t.c @@ -635,6 +635,121 @@ static void test_bcache_scenario(void *fixture) //---------------------------------------------------------------- +static void _bcs2_step1(struct radix_tree *rt) +{ + unsigned i; + uint8_t k[12]; + union radix_value v; + + memset(k, 0, sizeof(k)); + for (i = 0x6; i < 0x69; i++) { + k[0] = i; + v.n = i; + T_ASSERT(radix_tree_insert(rt, k, k + sizeof(k), v)); + } + T_ASSERT(radix_tree_is_well_formed(rt)); +} + +static void _bcs2_step2(struct radix_tree *rt) +{ + unsigned i; + uint8_t k[12]; + + memset(k, 0, sizeof(k)); + for (i = 0x6; i < 0x69; i++) { + k[0] = i; + radix_tree_remove_prefix(rt, k, k + 4); + } + T_ASSERT(radix_tree_is_well_formed(rt)); +} + +static void test_bcache_scenario2(void *fixture) +{ + unsigned i; + struct radix_tree *rt = fixture; + uint8_t k[12]; + union radix_value v; + + _bcs2_step1(rt); + _bcs2_step2(rt); + + memset(k, 0, sizeof(k)); + for (i = 0; i < 50; i++) { + k[0] = 0x6; + v.n = 0x6; + T_ASSERT(radix_tree_insert(rt, k, k + sizeof(k), v)); + radix_tree_remove_prefix(rt, k, k + 4); + } + T_ASSERT(radix_tree_is_well_formed(rt)); + + _bcs2_step1(rt); + _bcs2_step2(rt); + _bcs2_step1(rt); + _bcs2_step2(rt); + + memset(k, 0, sizeof(k)); + for(i = 0x6; i < 0x37; i++) { + k[0] = i; + k[4] = 0xf; + k[5] = 0x1; + T_ASSERT(radix_tree_insert(rt, k, k + sizeof(k), v)); + k[4] = 0; + k[5] = 0; + T_ASSERT(radix_tree_insert(rt, k, k + sizeof(k), v)); + } + T_ASSERT(radix_tree_is_well_formed(rt)); + + memset(k, 0, sizeof(k)); + for (i = 0x38; i < 0x69; i++) { + k[0] = i - 0x32; + k[4] = 0xf; + k[5] = 1; + T_ASSERT(radix_tree_remove(rt, k, k + sizeof(k))); + + k[0] = i; + T_ASSERT(radix_tree_insert(rt, k, k + sizeof(k), v)); + + k[0] = i - 0x32; + k[4] = 0; + k[5] = 0; + T_ASSERT(radix_tree_remove(rt, k, k + sizeof(k))); + + k[0] = i; + T_ASSERT(radix_tree_insert(rt, k, k + sizeof(k), v)); + } + T_ASSERT(radix_tree_is_well_formed(rt)); + + memset(k, 0, sizeof(k)); + k[0] = 0x6; + radix_tree_remove_prefix(rt, k, k + 4); + T_ASSERT(radix_tree_is_well_formed(rt)); + + k[0] = 0x38; + k[4] = 0xf; + k[5] = 0x1; + T_ASSERT(radix_tree_remove(rt, k, k + sizeof(k))); + T_ASSERT(radix_tree_is_well_formed(rt)); + + memset(k, 0, sizeof(k)); + k[0] = 0x6; + T_ASSERT(radix_tree_insert(rt, k, k + sizeof(k), v)); + T_ASSERT(radix_tree_is_well_formed(rt)); + + k[0] = 0x7; + radix_tree_remove_prefix(rt, k, k + 4); + T_ASSERT(radix_tree_is_well_formed(rt)); + + k[0] = 0x38; + T_ASSERT(radix_tree_remove(rt, k, k + sizeof(k))); + T_ASSERT(radix_tree_is_well_formed(rt)); + + k[0] = 7; + T_ASSERT(radix_tree_insert(rt, k, k + sizeof(k), v)); + T_ASSERT(radix_tree_is_well_formed(rt)); +} + +//---------------------------------------------------------------- + #define T(path, desc, fn) register_test(ts, "/base/data-struct/radix-tree/" path, desc, fn) void radix_tree_tests(struct dm_list *all_tests) @@ -668,6 +783,7 @@ void radix_tree_tests(struct dm_list *all_tests) T("remove-calls-dtr", "remove should call the dtr for the value", test_remove_calls_dtr); T("destroy-calls-dtr", "destroy should call the dtr for all values", test_destroy_calls_dtr); T("bcache-scenario", "A specific series of keys from a bcache scenario", test_bcache_scenario); + T("bcache-scenario-2", "A second series of keys from a bcache scenario", test_bcache_scenario2); dm_list_add(all_tests, &ts->list); }

1 0

master - tests: check policy mq can be used with format2
by Zdenek Kabelac 07 Aug '18

07 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=54668feaabead997cdf09… Commit: 54668feaabead997cdf099c970999af667bcf274 Parent: d1310242550e28dfe7c386a78435235955963c95 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Tue Aug 7 15:20:31 2018 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Tue Aug 7 17:59:50 2018 +0200 tests: check policy mq can be used with format2 --- test/shell/cache-metadata2.sh | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/test/shell/cache-metadata2.sh b/test/shell/cache-metadata2.sh index 57c6e23..0270f5d 100644 --- a/test/shell/cache-metadata2.sh +++ b/test/shell/cache-metadata2.sh @@ -88,6 +88,12 @@ lvcreate -H -L10 -n $lv1 --cachepool $vg/cpool check lv_field $vg/$lv1 cachemetadataformat "2" lvremove -f $vg +lvcreate --type cache-pool --cachepolicy mq --cachemetadataformat 1 -L1 $vg/cpool +check lv_field $vg/cpool cachemetadataformat "1" +lvcreate -H -L10 -n $lv1 --cachemetadataformat 2 --cachepool $vg/cpool +check lv_field $vg/$lv1 cachemetadataformat "2" +lvremove -f $vg + fi #lvs -a -o name,cachemetadataformat,kernelmetadataformat,chunksize,cachepolicy,cachemode $vg

1 0

master - cache: drop metadata_format validation
by Zdenek Kabelac 07 Aug '18

07 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=c34291e3bf61cc2644389… Commit: c34291e3bf61cc2644389cbce77e9953f67a843a Parent: 9adae653e98256901897e65aa349bb83a9f9ad5c Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Tue Aug 7 10:33:19 2018 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Tue Aug 7 17:57:00 2018 +0200 cache: drop metadata_format validation Allow to use any combination of cache metadata format for policy. --- WHATS_NEW | 1 + lib/metadata/cache_manip.c | 5 ----- 2 files changed, 1 insertions(+), 5 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 2c5b5d3..2cf7969 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 3.0.0 ============= + Do not pair cache policy and cache metadata format. lvconvert: reject conversions on raid1 LVs with split tracked SubLVs lvconvert: reject conversions on raid1 split tracked SubLVs Add basic creation support for VDO target. diff --git a/lib/metadata/cache_manip.c b/lib/metadata/cache_manip.c index 4132e2f..5ba353c 100644 --- a/lib/metadata/cache_manip.c +++ b/lib/metadata/cache_manip.c @@ -842,15 +842,10 @@ int cache_set_metadata_format(struct lv_segment *seg, cache_metadata_format_t fo /* * If policy is unselected, but format 2 is selected, policy smq is enforced. - * ATM no other then smq & cleaner policy is allowed to select format 2. */ if (!seg->policy_name) { if (format == CACHE_METADATA_FORMAT_2) seg->policy_name = "smq"; - } else if (strcmp(seg->policy_name, "smq") && - strcmp(seg->policy_name, "cleaner")) { - seg->cache_metadata_format = CACHE_METADATA_FORMAT_1; - return 1; } /* Check if we need to search for configured cache metadata format */

1 0

master - mirror: fix splitmirrors for mirror type
by Zdenek Kabelac 07 Aug '18

07 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=acab59137869e2f8119d8… Commit: acab59137869e2f8119d8faa09fdab5074b8c4b2 Parent: c34291e3bf61cc2644389cbce77e9953f67a843a Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Tue Aug 7 10:34:17 2018 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Tue Aug 7 17:58:30 2018 +0200 mirror: fix splitmirrors for mirror type With improved mirror activation code --splitmirror issue poppedup since there was missing proper preload code and deactivation for splitted mirror leg. --- WHATS_NEW | 1 + lib/activate/activate.c | 5 +++++ lib/metadata/mirror.c | 2 +- 3 files changed, 7 insertions(+), 1 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 2cf7969..0a0b6e9 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 3.0.0 ============= + Fix lvconvert --splitmirror for mirror type (2.02.178). Do not pair cache policy and cache metadata format. lvconvert: reject conversions on raid1 LVs with split tracked SubLVs lvconvert: reject conversions on raid1 split tracked SubLVs diff --git a/lib/activate/activate.c b/lib/activate/activate.c index d4a20c9..ead3b8d 100644 --- a/lib/activate/activate.c +++ b/lib/activate/activate.c @@ -2001,6 +2001,11 @@ static int _preload_detached_lv(struct logical_volume *lv, void *data) !lv_is_raid_metadata(lv_pre) && lv_is_active(lv) && !_lv_preload(lv_pre, detached->laopts, detached->flush_required)) return_0; + } else if (lv_is_mirror_image(lv)) { + if ((lv_pre = find_lv_in_vg_by_lvid(detached->lv_pre->vg, &lv->lvid)) && + !lv_is_mirror_image(lv_pre) && lv_is_active(lv) && + !_lv_preload(lv_pre, detached->laopts, detached->flush_required)) + return_0; } if (!lv_is_visible(lv) && (lv_pre = find_lv(detached->lv_pre->vg, lv->name)) && diff --git a/lib/metadata/mirror.c b/lib/metadata/mirror.c index 58615d8..c86ff90 100644 --- a/lib/metadata/mirror.c +++ b/lib/metadata/mirror.c @@ -774,7 +774,7 @@ static int _split_mirror_images(struct logical_volume *lv, act = lv_is_active(lv_lock_holder(lv)); - if (act && !_activate_lv_like_model(lv, new_lv)) { + if (act && (!deactivate_lv(cmd, new_lv) || !_activate_lv_like_model(lv, new_lv))) { log_error("Failed to rename newly split LV in the kernel"); return 0; }

1 0

master - tests: splitmirror for mirror type
by Zdenek Kabelac 07 Aug '18

07 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=d1310242550e28dfe7c38… Commit: d1310242550e28dfe7c386a78435235955963c95 Parent: acab59137869e2f8119d8faa09fdab5074b8c4b2 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Tue Aug 7 10:34:59 2018 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Tue Aug 7 17:59:50 2018 +0200 tests: splitmirror for mirror type --- test/shell/lvconvert-mirror-split.sh | 32 ++++++++++++++++++++++++++++++++ 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/test/shell/lvconvert-mirror-split.sh b/test/shell/lvconvert-mirror-split.sh new file mode 100644 index 0000000..40720a4 --- /dev/null +++ b/test/shell/lvconvert-mirror-split.sh @@ -0,0 +1,32 @@ +#!/usr/bin/env bash + +# Copyright (C) 2018 Red Hat, Inc. All rights reserved. +# +# This copyrighted material is made available to anyone wishing to use, +# modify, copy, or redistribute it subject to the terms and conditions +# of the GNU General Public License v.2. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software Foundation, +# Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + +# Check --splitmirrors for mirror segtype + +. lib/inittest + +aux prepare_vg 3 + +########################################### +# Mirror split tests +########################################### +# 3-way to 2-way/linear +lvcreate --type mirror -m 2 -l 2 -n $lv1 $vg +aux wait_for_sync $vg $lv1 +lvconvert --splitmirrors 1 -n $lv2 -vvvv $vg/$lv1 + +check lv_exists $vg $lv1 +check linear $vg $lv2 +check active $vg $lv2 +# FIXME: ensure no residual devices + +vgremove -ff $vg

1 0

master - mirrors: fix read_only_volume_list
by David Teigland 02 Aug '18

02 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=9adae653e98256901897e… Commit: 9adae653e98256901897e65aa349bb83a9f9ad5c Parent: 763219611c30d6870013b7cb84d66ec67a5dd7ec Author: David Teigland <teigland(a)redhat.com> AuthorDate: Thu Aug 2 11:26:59 2018 -0500 Committer: David Teigland <teigland(a)redhat.com> CommitterDate: Thu Aug 2 11:42:33 2018 -0500 mirrors: fix read_only_volume_list If a mirror LV is listed in read_only_volume_list, it would still be activated rw. The activation would initially be readonly, but the monitoring function would immediately change it to rw. This was a regression from commit fade45b1d14c mirror: improve table update The monitoring function needs to copy the read_only setting into the new set of mirror activation options it uses. --- lib/activate/activate.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/activate/activate.c b/lib/activate/activate.c index 28d67b4..d4a20c9 100644 --- a/lib/activate/activate.c +++ b/lib/activate/activate.c @@ -1740,6 +1740,8 @@ int monitor_dev_for_events(struct cmd_context *cmd, const struct logical_volume if (!laopts) laopts = &zlaopts; + else + mirr_laopts.read_only = laopts->read_only; /* skip dmeventd code altogether */ if (dmeventd_monitor_mode() == DMEVENTD_MONITOR_IGNORE)

1 0

master - vgcreate: close exclusive fd after pvcreate
by David Teigland 01 Aug '18

01 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=763219611c30d6870013b… Commit: 763219611c30d6870013b7cb84d66ec67a5dd7ec Parent: aa464aa2f6b438092a50ca20f149557550c7147b Author: David Teigland <teigland(a)redhat.com> AuthorDate: Wed Aug 1 10:26:28 2018 -0500 Committer: David Teigland <teigland(a)redhat.com> CommitterDate: Wed Aug 1 11:22:23 2018 -0500 vgcreate: close exclusive fd after pvcreate When vgcreate does an automatic pvcreate, it opens the dev with O_EXCL to ensure no other subsystem is using the device. This exclusive fd remained in bcache and prevented activation parts of lvm from using the dev. This appeared with vgcreate of a sanlock VG because of the unique combination where the dev is not yet a PV, so pvcreate is needed, and the vgcreate also creates and activates an internal LV for sanlock. Fix this by closing the exclusive fd after it's used by pvcreate so that it won't interfere with other bits of lvm that may try to use the device. --- lib/label/label.c | 6 +++--- tools/toollib.c | 7 +++++++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/lib/label/label.c b/lib/label/label.c index d2c8685..9fe11f6 100644 --- a/lib/label/label.c +++ b/lib/label/label.c @@ -1185,7 +1185,7 @@ bool dev_write_bytes(struct device *dev, uint64_t start, size_t len, void *data) return false; } - if (!(dev->flags & DEV_BCACHE_WRITE)) { + if (_in_bcache(dev) && !(dev->flags & DEV_BCACHE_WRITE)) { /* FIXME: avoid tossing out bcache blocks just to replace fd. */ log_debug("Close and reopen to write %s", dev_name(dev)); bcache_invalidate_fd(scan_bcache, dev->bcache_fd); @@ -1231,7 +1231,7 @@ bool dev_write_zeros(struct device *dev, uint64_t start, size_t len) return false; } - if (!(dev->flags & DEV_BCACHE_WRITE)) { + if (_in_bcache(dev) && !(dev->flags & DEV_BCACHE_WRITE)) { /* FIXME: avoid tossing out bcache blocks just to replace fd. */ log_debug("Close and reopen to write %s", dev_name(dev)); bcache_invalidate_fd(scan_bcache, dev->bcache_fd); @@ -1277,7 +1277,7 @@ bool dev_set_bytes(struct device *dev, uint64_t start, size_t len, uint8_t val) return false; } - if (!(dev->flags & DEV_BCACHE_WRITE)) { + if (_in_bcache(dev) && !(dev->flags & DEV_BCACHE_WRITE)) { /* FIXME: avoid tossing out bcache blocks just to replace fd. */ log_debug("Close and reopen to write %s", dev_name(dev)); bcache_invalidate_fd(scan_bcache, dev->bcache_fd); diff --git a/tools/toollib.c b/tools/toollib.c index 36ae125..85d44b3 100644 --- a/tools/toollib.c +++ b/tools/toollib.c @@ -5782,6 +5782,13 @@ do_command: pd->name); } + /* + * Don't keep devs open excl in bcache because the excl will prevent + * using that dev elsewhere. + */ + dm_list_iterate_items(devl, &rescan_devs) + label_scan_invalidate(devl->dev); + dm_list_iterate_items(pd, &pp->arg_fail) log_debug("%s: command failed for %s.", cmd->command->name, pd->name);

1 0

v2_02_181 annotated tag has been created
by Marian Csontos 01 Aug '18

01 Aug '18

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=560872f013c65f8c1ff46… Commit: 560872f013c65f8c1ff463be59fde9382a1b0185 Parent: 0000000000000000000000000000000000000000 Author: Marian Csontos <mcsontos(a)redhat.com> AuthorDate: 2018-08-01 14:57 +0000 Committer: Marian Csontos <mcsontos(a)redhat.com> CommitterDate: 2018-08-01 14:57 +0000 annotated tag: v2_02_181 has been created at 560872f013c65f8c1ff463be59fde9382a1b0185 (tag) tagging a3353e766e6989147afb44b94767b54bc7827967 (commit) replaces v2_02_180 iRelease 2.02.181 Bugfix release fixing mostly lvconvert command. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAABAgAGBQJbYcp8AAoJELkRJDHlCQOfp/0P/1CvDalDgTkmZlVIElU5lSq8 PVhfc6JK+yHjFz7b8uQ42Q+YGXLov5DFf7bwagsAeWOguGsRbO9hDleJwZ1iJFv1 GBezEl73W49ug0ODnCus3nYFkTiuDk6v5LrnBPeNfjDi7c2lB76Ekzdl1rle7lCc szUk3T33AXqh6UdTiuhi94FrZEB9Oo5FWaFIapEXr0ce8GX8+DVJN6ubN92hIWxT zu5IM25w+rc57lSeLvVb372ZOkJ7Z8TJ7VcF+FUAiXsFTTmDgP+euqjdP8i7NFD7 2p6EbJrp04ncK7k7DUPwMPkNQ78o3n/vdYjuxLGlWM28+c3SucfSboYUgI2ZUpCb IO9Y2p5UBy8gbG35rAr3bM4NNL5+8ecmrxpab/kLh0/q8LYSd5gu9bDfBXrwPYR0 It59T4DPlP4kcwTddi1IKrerdpH7KFNLepNHKo5vp0/8uFcvtEo5wCEoHEKNFETn wtVzx3ySZlsZz31LP0S5/aaWTmul00rG/1uE24ZOmdCTEWiza84ZwWMydiV4r/gb WxFioJ4b/AHidDy/48Kv8rgYFnf0vPB2Qc/FQigLAY6lSjmw3Vd6g/EFvNSnEANU jVaOp0nCOD4GpxgU0W/WUiSsDKAflg4vWdgrYAXxhyOc2BiScqpTkmkOrSvc2F9k k1f+hAx0EL4J0fFdxecy =Un40 -----END PGP SIGNATURE----- Bryn M. Reeves (1): dmsetup: fix error propagation in _display_info_cols() David Teigland (2): lvconvert: restrict command matching for no option variant lvconvert: improve text about splitmirrors Heinz Mauelshagen (3): lvconvert: reject conversions of LVs under snapshot lvconvert: reject conversions on raid1 split trackchanges SubLVs lvconvert: reject conversions on raid1 split trackchanges LVs Marian Csontos (6): post-release test: Check flavour is used and exists Add BSD 2-Clause License WHATS_NEW build: make generate pre-release Zdenek Kabelac (2): dmeventd: base vdo plugin dmeventd: rebase to stable branch

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

lvm2-commits August 2018