lvm2-commits August 2020

lvm2-commits@lists.fedorahosted.org

4 participants
30 discussions

master - WHATS_NEW
by Marian Csontos 09 Aug '20

09 Aug '20

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=c1d136fea3d127d8ecd5c… Commit: c1d136fea3d127d8ecd5c30208c919490a58ff59 Parent: 9f8c331760c08d4da0bb03c4fce4946b0236c0ac Author: Marian Csontos <mcsontos(a)redhat.com> AuthorDate: Sun Aug 9 16:15:13 2020 +0200 Committer: Marian Csontos <mcsontos(a)redhat.com> CommitterDate: Sun Aug 9 16:17:15 2020 +0200 WHATS_NEW --- WHATS_NEW | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 87779c3e7..ac99e970d 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,6 +1,9 @@ Version 2.03.10 - -================================= - Add writecache support to lvmdbusd. +================================== + Add writecache and integrity support to lvmdbusd. + Generate unique cachevol name when default required from lvcreate. + Converting RAID1 volume to one with same number of legs now succeeds with a + warning. Fix conversion to raid from striped lagging type. Fix conversion to 'mirrored' mirror log with larger regionsize. Zero pool metadata on allocation (disable with allocation/zero_metadata=0).

1 0

master - build: make generate
by Marian Csontos 09 Aug '20

09 Aug '20

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=9f8c331760c08d4da0bb0… Commit: 9f8c331760c08d4da0bb03c4fce4946b0236c0ac Parent: 4f44841045ec9420a4bb9a141fab55cb95260b45 Author: Marian Csontos <mcsontos(a)redhat.com> AuthorDate: Sun Aug 9 15:20:22 2020 +0200 Committer: Marian Csontos <mcsontos(a)redhat.com> CommitterDate: Sun Aug 9 15:20:22 2020 +0200 build: make generate --- include/configure.h.in | 6 +++--- man/lvconvert.8_pregen | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/configure.h.in b/include/configure.h.in index 57736cc3b..540cee7cf 100644 --- a/include/configure.h.in +++ b/include/configure.h.in @@ -531,6 +531,9 @@ /* Define to 1 if the system has the `__builtin_clzll' built-in function */ #undef HAVE___BUILTIN_CLZLL +/* Define to 1 to include built-in support for integrity. */ +#undef INTEGRITY_INTERNAL + /* Internalization package */ #undef INTL_PACKAGE @@ -678,9 +681,6 @@ /* Define to 1 to include built-in support for writecache. */ #undef WRITECACHE_INTERNAL -/* Define to 1 to include built-in support for integrity. */ -#undef INTEGRITY_INTERNAL - /* Define to get access to GNU/Linux extension */ #undef _GNU_SOURCE diff --git a/man/lvconvert.8_pregen b/man/lvconvert.8_pregen index 37b0a47d2..b3902a51c 100644 --- a/man/lvconvert.8_pregen +++ b/man/lvconvert.8_pregen @@ -749,7 +749,7 @@ Attach a cache to an LV, converts the LV to type cache. Add a writecache to an LV, using a specified cache device. .br .P -\fBlvconvert\fP \fB--type\fP \fBwritecache\fP \fB--cachedevice\fP \fIPV\fP \fILV\fP +\fBlvconvert\fP \fB--type\fP \fBwritecache\fP \fB--cachedevice\fP \fIPV\fP \fILV\fP\fI_linear_striped_raid\fP .br .RS 4 .ad l @@ -768,7 +768,7 @@ Add a writecache to an LV, using a specified cache device. Add a cache to an LV, using a specified cache device. .br .P -\fBlvconvert\fP \fB--type\fP \fBcache\fP \fB--cachedevice\fP \fIPV\fP \fILV\fP +\fBlvconvert\fP \fB--type\fP \fBcache\fP \fB--cachedevice\fP \fIPV\fP \fILV\fP\fI_linear_striped_thinpool_raid\fP .br .RS 4 .ad l

1 0

master - WHATS_NEW: Add writecache lvmdbusd
by Tony Asleson 06 Aug '20

06 Aug '20

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=4f44841045ec9420a4bb9… Commit: 4f44841045ec9420a4bb9a141fab55cb95260b45 Parent: d4d060acd5e35ca052dd4ba0743732ed4fb46f86 Author: Tony Asleson <tasleson(a)redhat.com> AuthorDate: Thu Aug 6 15:42:49 2020 -0500 Committer: Tony Asleson <tasleson(a)redhat.com> CommitterDate: Thu Aug 6 15:42:49 2020 -0500 WHATS_NEW: Add writecache lvmdbusd --- WHATS_NEW | 1 + 1 file changed, 1 insertion(+) diff --git a/WHATS_NEW b/WHATS_NEW index 562b1765b..87779c3e7 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.03.10 - ================================= + Add writecache support to lvmdbusd. Fix conversion to raid from striped lagging type. Fix conversion to 'mirrored' mirror log with larger regionsize. Zero pool metadata on allocation (disable with allocation/zero_metadata=0).

1 0

master - lvmdbusd: Bump LVM DBus API version
by Tony Asleson 06 Aug '20

06 Aug '20

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=d4d060acd5e35ca052dd4… Commit: d4d060acd5e35ca052dd4ba0743732ed4fb46f86 Parent: 8f1068c02d06e9104c47db0131617c8f98d31718 Author: Vojtech Trefny <vtrefny(a)redhat.com> AuthorDate: Wed Jul 1 13:27:47 2020 +0200 Committer: Tony Asleson <tasleson(a)redhat.com> CommitterDate: Thu Aug 6 13:54:45 2020 -0500 lvmdbusd: Bump LVM DBus API version So users can check for writecache support. --- daemons/lvmdbusd/manager.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemons/lvmdbusd/manager.py b/daemons/lvmdbusd/manager.py index 2857e9a10..573a3966f 100644 --- a/daemons/lvmdbusd/manager.py +++ b/daemons/lvmdbusd/manager.py @@ -27,7 +27,7 @@ class Manager(AutomatedProperties): @property def Version(self): - return dbus.String('1.0.0') + return dbus.String('1.1.0') @staticmethod def handle_execute(rc, out, err):

1 0

master - lvmdbusd: Add support for LVM writecache
by Tony Asleson 06 Aug '20

06 Aug '20

Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=8f1068c02d06e9104c47d… Commit: 8f1068c02d06e9104c47db0131617c8f98d31718 Parent: e12bdd591a1e60f055baee6cf5e9a144ea245a33 Author: Vojtech Trefny <vtrefny(a)redhat.com> AuthorDate: Wed Jul 1 13:27:46 2020 +0200 Committer: Tony Asleson <tasleson(a)redhat.com> CommitterDate: Thu Aug 6 13:54:34 2020 -0500 lvmdbusd: Add support for LVM writecache --- daemons/lvmdbusd/cmdhandler.py | 9 +++++++++ daemons/lvmdbusd/lv.py | 43 ++++++++++++++++++++++++++++++++++++++++++ test/dbus/lvmdbustest.py | 30 +++++++++++++++++++++++++++++ 3 files changed, 82 insertions(+) diff --git a/daemons/lvmdbusd/cmdhandler.py b/daemons/lvmdbusd/cmdhandler.py index 7d2f4c4ba..1c15b7888 100644 --- a/daemons/lvmdbusd/cmdhandler.py +++ b/daemons/lvmdbusd/cmdhandler.py @@ -453,6 +453,15 @@ def lv_cache_lv(cache_pool_full_name, lv_full_name, cache_options): return call(cmd) +def lv_writecache_lv(cache_lv_full_name, lv_full_name, cache_options): + # lvconvert --type writecache --cachevol VG/CacheLV VG/OriginLV + cmd = ['lvconvert'] + cmd.extend(options_to_cli_args(cache_options)) + cmd.extend(['-y', '--type', 'writecache', '--cachevol', + cache_lv_full_name, lv_full_name]) + return call(cmd) + + def lv_detach_cache(lv_full_name, detach_options, destroy_cache): cmd = ['lvconvert'] if destroy_cache: diff --git a/daemons/lvmdbusd/lv.py b/daemons/lvmdbusd/lv.py index 5c4728073..edfdd0d30 100644 --- a/daemons/lvmdbusd/lv.py +++ b/daemons/lvmdbusd/lv.py @@ -743,6 +743,49 @@ class Lv(LvCommon): cb, cbe, return_tuple=False) cfg.worker_q.put(r) + @staticmethod + def _writecache_lv(lv_uuid, lv_name, lv_object_path, cache_options): + # Make sure we have a dbus object representing it + dbo = LvCommon.validate_dbus_object(lv_uuid, lv_name) + + # Make sure we have dbus object representing lv to cache + lv_to_cache = cfg.om.get_object_by_path(lv_object_path) + + if lv_to_cache: + fcn = lv_to_cache.lv_full_name() + rc, out, err = cmdhandler.lv_writecache_lv( + dbo.lv_full_name(), fcn, cache_options) + if rc == 0: + # When we cache an LV, the cache pool and the lv that is getting + # cached need to be removed from the object manager and + # re-created as their interfaces have changed! + mt_remove_dbus_objects((dbo, lv_to_cache)) + cfg.load() + + lv_converted = cfg.om.get_object_path_by_lvm_id(fcn) + else: + raise dbus.exceptions.DBusException( + LV_INTERFACE, + 'Exit code %s, stderr = %s' % (str(rc), err)) + else: + raise dbus.exceptions.DBusException( + LV_INTERFACE, 'LV to cache with object path %s not present!' % + lv_object_path) + return lv_converted + + @dbus.service.method( + dbus_interface=LV_INTERFACE, + in_signature='oia{sv}', + out_signature='(oo)', + async_callbacks=('cb', 'cbe')) + def WriteCacheLv(self, lv_object, tmo, cache_options, cb, cbe): + r = RequestEntry( + tmo, Lv._writecache_lv, + (self.Uuid, self.lvm_id, lv_object, + cache_options), cb, cbe) + cfg.worker_q.put(r) + + # noinspection PyPep8Naming @utils.dbus_property(VDO_POOL_INTERFACE, 'OperatingMode', 's') @utils.dbus_property(VDO_POOL_INTERFACE, 'CompressionState', 's') diff --git a/test/dbus/lvmdbustest.py b/test/dbus/lvmdbustest.py index 8753e65d0..efa1afb26 100755 --- a/test/dbus/lvmdbustest.py +++ b/test/dbus/lvmdbustest.py @@ -1558,6 +1558,36 @@ class TestDbusService(unittest.TestCase): cached_lv.Lv.Rename(dbus.String(new_name), dbus.Int32(g_tmo), EOD)) verify_cache_lv_count() + def test_writecache_lv(self): + vg = self._vg_create().Vg + data_lv = self._create_lv(size=mib(16), vg=vg) + cache_lv = self._create_lv(size=mib(16), vg=vg) + + # both LVs need to be inactive + self.handle_return(data_lv.Lv.Deactivate( + dbus.UInt64(0), dbus.Int32(g_tmo), EOD)) + data_lv.update() + self.handle_return(cache_lv.Lv.Deactivate( + dbus.UInt64(0), dbus.Int32(g_tmo), EOD)) + cache_lv.update() + + cached_lv_path = self.handle_return( + cache_lv.Lv.WriteCacheLv( + dbus.ObjectPath(data_lv.object_path), + dbus.Int32(g_tmo), + EOD)) + + intf = (LV_COMMON_INT, LV_INT, CACHE_LV_INT) + cached_lv = ClientProxy(self.bus, cached_lv_path, interfaces=intf) + self.assertEqual(cached_lv.LvCommon.SegType, ["writecache"]) + + uncached_lv_path = self.handle_return( + cached_lv.CachedLv.DetachCachePool( + dbus.Boolean(True), + dbus.Int32(g_tmo), + EOD)) + self.assertTrue('/com/redhat/lvmdbus1/Lv' in uncached_lv_path) + def test_vg_change(self): vg_proxy = self._vg_create()

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

lvm2-commits August 2020