main - makefiles: sanitize environment
by Zdenek Kabelac
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=52b56204764e421b693...
Commit: 52b56204764e421b693d94fa38834d71e29deced
Parent: 1ae157a0f67e984ef3037d19d62b84a3b0201c84
Author: Zdenek Kabelac <zkabelac(a)redhat.com>
AuthorDate: Fri Sep 3 19:31:44 2021 +0200
Committer: Zdenek Kabelac <zkabelac(a)redhat.com>
CommitterDate: Mon Sep 6 14:00:20 2021 +0200
makefiles: sanitize environment
Compilation needs to generate 'C' locale sorted command file
definitions. To always enforce 'C' sorting rules user LC_ALL
instead of LANG, as LANG settings can be overuled by
other LC settings like LC_COLLATE and may result into miscompiled
lvm2 binary if locales ordering differs from 'C'.
Reported-by: jmp-lvm2(a)ookaze.fr
---
tools/Makefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/Makefile.in b/tools/Makefile.in
index ec546ca63..e0e180474 100644
--- a/tools/Makefile.in
+++ b/tools/Makefile.in
@@ -181,7 +181,7 @@ cmds.h: $(srcdir)/command-lines.in Makefile
( cat $(srcdir)/license.inc && \
echo "/* Do not edit. This file is generated by the Makefile. */" && \
echo "cmd(CMD_NONE, none)" && \
- $(GREP) '^ID:' $(srcdir)/command-lines.in | LANG=C $(SORT) -u | $(AWK) '{print "cmd(" $$2 "_CMD, " $$2 ")"}' && \
+ $(GREP) '^ID:' $(srcdir)/command-lines.in | LC_ALL=C $(SORT) -u | $(AWK) '{print "cmd(" $$2 "_CMD, " $$2 ")"}' && \
echo "cmd(CMD_COUNT, count)" \
) > $@
2 years, 7 months
- 1
- 0