main - lvmdbusd: Correct seg. fault on s390x ELN
by Tony Asleson
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=300c8209a810f287992...
Commit: 300c8209a810f287992376e8a0561fdf878d1520
Parent: f7ca470abe995210e8008084c0b4436292b2816b
Author: Tony Asleson <tasleson(a)redhat.com>
AuthorDate: Thu Mar 30 10:10:23 2023 -0500
Committer: Tony Asleson <tasleson(a)redhat.com>
CommitterDate: Thu Mar 30 11:04:49 2023 -0500
lvmdbusd: Correct seg. fault on s390x ELN
syscall 186 is specific to x86 64bit. As this is different from arch
to arch and between same arch different arch size we will only grab
thread ID using built-in python support if it is supported.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2166931
---
daemons/lvmdbusd/utils.py | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/daemons/lvmdbusd/utils.py b/daemons/lvmdbusd/utils.py
index fdd7578c1..27b869c13 100644
--- a/daemons/lvmdbusd/utils.py
+++ b/daemons/lvmdbusd/utils.py
@@ -11,7 +11,6 @@ import xml.etree.ElementTree as Et
import sys
import inspect
import collections
-import ctypes
import errno
import fcntl
import os
@@ -305,8 +304,16 @@ class DebugMessages(object):
self.queue.clear()
+def _get_tid():
+ try:
+ # Only 3.8 and later have this
+ return threading.get_native_id()
+ except:
+ return -1
+
+
def _format_log_entry(msg):
- tid = ctypes.CDLL('libc.so.6').syscall(186)
+ tid = _get_tid()
if not cfg.systemd and STDOUT_TTY:
msg = "%s: %d:%d - %s" % \
2 months, 1 week
main - lvmdbusd: Correct locking for _common_log
by Tony Asleson
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=f7ca470abe995210e80...
Commit: f7ca470abe995210e8008084c0b4436292b2816b
Parent: d6f8f59239c65a7f1f9be1d24bf9ba02cfee5b0e
Author: Tony Asleson <tasleson(a)redhat.com>
AuthorDate: Thu Mar 30 10:07:13 2023 -0500
Committer: Tony Asleson <tasleson(a)redhat.com>
CommitterDate: Thu Mar 30 11:04:42 2023 -0500
lvmdbusd: Correct locking for _common_log
Reduce the lock time and include the flush in the lock.
Reported by: Zbigniew J��drzejewski-Szmek <zbyszek(a)in.waw.pl>
---
daemons/lvmdbusd/utils.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/daemons/lvmdbusd/utils.py b/daemons/lvmdbusd/utils.py
index 6013b656f..fdd7578c1 100644
--- a/daemons/lvmdbusd/utils.py
+++ b/daemons/lvmdbusd/utils.py
@@ -323,16 +323,17 @@ def _format_log_entry(msg):
def _common_log(msg, *attributes):
- cfg.stdout_lock.acquire()
msg = _format_log_entry(msg)
+ cfg.stdout_lock.acquire()
+
if STDOUT_TTY and attributes:
print(color(msg, *attributes))
else:
print(msg)
- cfg.stdout_lock.release()
sys.stdout.flush()
+ cfg.stdout_lock.release()
# Serializes access to stdout to prevent interleaved output
2 months, 1 week
main - Fix import of utils from lvmdbusd.cfg
by Tony Asleson
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=d6f8f59239c65a7f1f9...
Commit: d6f8f59239c65a7f1f9be1d24bf9ba02cfee5b0e
Parent: 238e3777777e1e75b388d8e05f9c1212aa4d1eed
Author: Adam Williamson <awilliam(a)redhat.com>
AuthorDate: Tue Mar 21 11:46:54 2023 -0700
Committer: Tony Asleson <tasleson(a)redhat.com>
CommitterDate: Tue Mar 21 22:42:25 2023 -0500
Fix import of utils from lvmdbusd.cfg
Signed-off-by: Adam Williamson <awilliam(a)redhat.com>
---
daemons/lvmdbusd/cfg.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/daemons/lvmdbusd/cfg.py b/daemons/lvmdbusd/cfg.py
index 9da4b1267..9f4360100 100644
--- a/daemons/lvmdbusd/cfg.py
+++ b/daemons/lvmdbusd/cfg.py
@@ -11,7 +11,7 @@ import os
import multiprocessing
import queue
import itertools
-from utils import LvmDebugData
+from lvmdbusd.utils import LvmDebugData
from lvmdbusd import path
2 months, 2 weeks
main - post-release
by Tony Asleson
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=238e3777777e1e75b38...
Commit: 238e3777777e1e75b388d8e05f9c1212aa4d1eed
Parent: 3e0ee8dbad69b01c63b13f41ba449cba48756968
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: Tue Mar 21 13:36:36 2023 +0100
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: Tue Mar 21 13:36:36 2023 +0100
post-release
---
VERSION | 2 +-
VERSION_DM | 2 +-
WHATS_NEW | 3 +++
WHATS_NEW_DM | 3 +++
4 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/VERSION b/VERSION
index 8f75291df..60c7a1dd4 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.03.20(2) (2023-03-21)
+2.03.21(2)-git (2023-03-21)
diff --git a/VERSION_DM b/VERSION_DM
index a1f7b8fce..68bf19e27 100644
--- a/VERSION_DM
+++ b/VERSION_DM
@@ -1 +1 @@
-1.02.193 (2023-03-21)
+1.02.195-git (2023-03-21)
diff --git a/WHATS_NEW b/WHATS_NEW
index 8328a668a..6f801828f 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,3 +1,6 @@
+version 2.03.21 -
+=================================
+
version 2.03.20 - 21st March 2023
=================================
Fix segfault if using -S|--select with log/report_command_log=1 setting.
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 2227b10d9..88298caad 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,3 +1,6 @@
+Version 1.02.195 -
+==================================
+
Version 1.02.193 - 21st March 2023
==================================
2 months, 2 weeks
main - pre-release
by Tony Asleson
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=3e0ee8dbad69b01c63b...
Commit: 3e0ee8dbad69b01c63b13f41ba449cba48756968
Parent: 6204fda003804e2bad022347baab510cb845f315
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: Tue Mar 21 13:35:48 2023 +0100
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: Tue Mar 21 13:35:48 2023 +0100
pre-release
---
VERSION | 2 +-
VERSION_DM | 2 +-
WHATS_NEW | 4 ++--
WHATS_NEW_DM | 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/VERSION b/VERSION
index 2a5ec2776..8f75291df 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.03.20(2)-git (2023-02-21)
+2.03.20(2) (2023-03-21)
diff --git a/VERSION_DM b/VERSION_DM
index 20aaeb0b7..a1f7b8fce 100644
--- a/VERSION_DM
+++ b/VERSION_DM
@@ -1 +1 @@
-1.02.193-git (2023-02-21)
+1.02.193 (2023-03-21)
diff --git a/WHATS_NEW b/WHATS_NEW
index 7c979d69c..8328a668a 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,5 @@
-version 2.03.20 -
-====================================
+version 2.03.20 - 21st March 2023
+=================================
Fix segfault if using -S|--select with log/report_command_log=1 setting.
Configure now fails when requested lvmlockd dependencies are missing.
Add some configure Gentoo enhancements for static builds.
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index c2eefc8db..2227b10d9 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,5 +1,5 @@
-Version 1.02.193 -
-=====================================
+Version 1.02.193 - 21st March 2023
+==================================
Version 1.02.191 - 21st February 2023
=====================================
2 months, 2 weeks
main - make: generate
by Tony Asleson
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=6204fda003804e2bad0...
Commit: 6204fda003804e2bad022347baab510cb845f315
Parent: 49dbeb9b4566df684164f40ca6ebdab3d6696836
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: Tue Mar 21 13:33:14 2023 +0100
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: Tue Mar 21 13:33:14 2023 +0100
make: generate
---
man/vgchange.8_pregen | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/man/vgchange.8_pregen b/man/vgchange.8_pregen
index 5ab59204d..4665e98c8 100644
--- a/man/vgchange.8_pregen
+++ b/man/vgchange.8_pregen
@@ -68,6 +68,8 @@ vgchange \(em Change volume group attributes
\fB-l\fP|\fB--logicalvolume\fP \fINumber\fP
.br
\fB--longhelp\fP
+.br
+ \fB--majoritypvs\fP
.br
\fB-p\fP|\fB--maxphysicalvolumes\fP \fINumber\fP
.br
@@ -348,6 +350,8 @@ Change the system ID of a VG.
.ad l
[ \fB-S\fP|\fB--select\fP \fIString\fP ]
.br
+[ \fB--majoritypvs\fP ]
+.br
[ COMMON_OPTIONS ]
.ad b
.RE
@@ -666,6 +670,12 @@ Sets the maximum number of LVs allowed in a VG.
Display long help text.
.
.HP
+\fB--majoritypvs\fP
+.br
+Change the VG system ID if the majority of PVs in the VG
+are present (one more than half).
+.
+.HP
\fB-p\fP|\fB--maxphysicalvolumes\fP \fINumber\fP
.br
Sets the maximum number of PVs that can belong to the VG.
2 months, 2 weeks
main - tests: nomda-restoremissing
by Tony Asleson
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=49dbeb9b4566df68416...
Commit: 49dbeb9b4566df684164f40ca6ebdab3d6696836
Parent: ddfe839dd1aa42e3d2a15a19eaf86c4b6fc65d19
Author: David Teigland <teigland(a)redhat.com>
AuthorDate: Mon Mar 20 12:42:50 2023 -0500
Committer: David Teigland <teigland(a)redhat.com>
CommitterDate: Mon Mar 20 12:42:50 2023 -0500
tests: nomda-restoremissing
This test was broken by commit 69ea2e3f9
"vg_read: keep MISSING_PV when device with no mda reappears"
Change the test to match the new behavior.
---
test/shell/nomda-restoremissing.sh | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/test/shell/nomda-restoremissing.sh b/test/shell/nomda-restoremissing.sh
index fb3f93053..d9c544bc4 100644
--- a/test/shell/nomda-restoremissing.sh
+++ b/test/shell/nomda-restoremissing.sh
@@ -31,7 +31,18 @@ not vgck $vg 2>&1 | tee log
grep "missing 1 physical volume" log
not lvcreate -aey --type mirror -m 1 -l 1 -n mirror $vg # write operations fail
aux enable_dev "$dev1"
-lvcreate -aey --type mirror -m 1 -l 1 -n mirror $vg # no MDA => automatically restored
+# Old versions would automatically clear MISSING_PV on a PV that had no mda,
+# but this made no sense; the existence of an mda means nothing for the
+# validity of the data on the device. I suspect that at some point in the
+# past, the MISSING_PV flag was used to decide if metadata could be used
+# from the device, so the flag could be cleared on a PV with no mda.
+# These days lvm knows when to ignore outdated metadata.
+# MISSING_PV probably has little to no value for determining valid data either,
+# so it's likely that we'll begin to automatically clear MISSING_PV in the
+# future (but it will have nothing to do with having mdas.)
+not lvcreate -aey --type mirror -m 1 -l 1 -n mirror $vg
+vgextend --restoremissing $vg "$dev1"
+lvcreate -aey --type mirror -m 1 -l 1 -n mirror $vg
vgck $vg
vgremove -ff $vg
2 months, 2 weeks
main - Fix import of utils from lvmdbusd.cfg
by Tony Asleson
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=d6f8f59239c65a7f1f9...
Commit: d6f8f59239c65a7f1f9be1d24bf9ba02cfee5b0e
Parent: 238e3777777e1e75b388d8e05f9c1212aa4d1eed
Author: Adam Williamson <awilliam(a)redhat.com>
AuthorDate: Tue Mar 21 11:46:54 2023 -0700
Committer: Tony Asleson <tasleson(a)redhat.com>
CommitterDate: Tue Mar 21 22:42:25 2023 -0500
Fix import of utils from lvmdbusd.cfg
Signed-off-by: Adam Williamson <awilliam(a)redhat.com>
---
daemons/lvmdbusd/cfg.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/daemons/lvmdbusd/cfg.py b/daemons/lvmdbusd/cfg.py
index 9da4b1267..9f4360100 100644
--- a/daemons/lvmdbusd/cfg.py
+++ b/daemons/lvmdbusd/cfg.py
@@ -11,7 +11,7 @@ import os
import multiprocessing
import queue
import itertools
-from utils import LvmDebugData
+from lvmdbusd.utils import LvmDebugData
from lvmdbusd import path
2 months, 2 weeks
main - post-release
by Marian Csontos
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=238e3777777e1e75b38...
Commit: 238e3777777e1e75b388d8e05f9c1212aa4d1eed
Parent: 3e0ee8dbad69b01c63b13f41ba449cba48756968
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: Tue Mar 21 13:36:36 2023 +0100
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: Tue Mar 21 13:36:36 2023 +0100
post-release
---
VERSION | 2 +-
VERSION_DM | 2 +-
WHATS_NEW | 3 +++
WHATS_NEW_DM | 3 +++
4 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/VERSION b/VERSION
index 8f75291df..60c7a1dd4 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.03.20(2) (2023-03-21)
+2.03.21(2)-git (2023-03-21)
diff --git a/VERSION_DM b/VERSION_DM
index a1f7b8fce..68bf19e27 100644
--- a/VERSION_DM
+++ b/VERSION_DM
@@ -1 +1 @@
-1.02.193 (2023-03-21)
+1.02.195-git (2023-03-21)
diff --git a/WHATS_NEW b/WHATS_NEW
index 8328a668a..6f801828f 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,3 +1,6 @@
+version 2.03.21 -
+=================================
+
version 2.03.20 - 21st March 2023
=================================
Fix segfault if using -S|--select with log/report_command_log=1 setting.
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index 2227b10d9..88298caad 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,3 +1,6 @@
+Version 1.02.195 -
+==================================
+
Version 1.02.193 - 21st March 2023
==================================
2 months, 2 weeks
main - pre-release
by Marian Csontos
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=3e0ee8dbad69b01c63b...
Commit: 3e0ee8dbad69b01c63b13f41ba449cba48756968
Parent: 6204fda003804e2bad022347baab510cb845f315
Author: Marian Csontos <mcsontos(a)redhat.com>
AuthorDate: Tue Mar 21 13:35:48 2023 +0100
Committer: Marian Csontos <mcsontos(a)redhat.com>
CommitterDate: Tue Mar 21 13:35:48 2023 +0100
pre-release
---
VERSION | 2 +-
VERSION_DM | 2 +-
WHATS_NEW | 4 ++--
WHATS_NEW_DM | 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/VERSION b/VERSION
index 2a5ec2776..8f75291df 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-2.03.20(2)-git (2023-02-21)
+2.03.20(2) (2023-03-21)
diff --git a/VERSION_DM b/VERSION_DM
index 20aaeb0b7..a1f7b8fce 100644
--- a/VERSION_DM
+++ b/VERSION_DM
@@ -1 +1 @@
-1.02.193-git (2023-02-21)
+1.02.193 (2023-03-21)
diff --git a/WHATS_NEW b/WHATS_NEW
index 7c979d69c..8328a668a 100644
--- a/WHATS_NEW
+++ b/WHATS_NEW
@@ -1,5 +1,5 @@
-version 2.03.20 -
-====================================
+version 2.03.20 - 21st March 2023
+=================================
Fix segfault if using -S|--select with log/report_command_log=1 setting.
Configure now fails when requested lvmlockd dependencies are missing.
Add some configure Gentoo enhancements for static builds.
diff --git a/WHATS_NEW_DM b/WHATS_NEW_DM
index c2eefc8db..2227b10d9 100644
--- a/WHATS_NEW_DM
+++ b/WHATS_NEW_DM
@@ -1,5 +1,5 @@
-Version 1.02.193 -
-=====================================
+Version 1.02.193 - 21st March 2023
+==================================
Version 1.02.191 - 21st February 2023
=====================================
2 months, 2 weeks