[PATCH] Fix $PROCESS in init script after name change.

I haven't tested this script fully yet.  I've been running things manually
and now I'm trying to build RPMs and start everything as services but
I'm having some problems.  I noticed this while debugging it.

I still need to figure out why /var/lib/matahari and /var/run/matahari
don't seem to be created properly when installing the RPMs though.
I'm using Fedora 15.

-----

matahari-serviced is now matahari-qmf-serviced, so tweak the init script
to match that naming scheme.

Signed-off-by: Russell Bryant <russell(a)russellbryant.net&gt;
---
 matahari.init.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/matahari.init.in b/matahari.init.in
index c967b8d..ed34c4b 100644
--- a/matahari.init.in
+++ b/matahari.init.in
@@ -23,7 +23,7 @@
 
 SERVICE=`readlink -f "$0"`
 SERVICE=`basename "$SERVICE"`
-PROCESS=`echo "$SERVICE"d`
+PROCESS=`echo "$SERVICE" | cut -f1 -d'-'`-qmf-`echo
"$SERVICE" | cut -f2 -d'-'`d
 
 RETVAL=0
 
-- 
1.7.4.4

[Andrew Beekhof]

On Fri, Apr 29, 2011 at 5:54 PM, Russell Bryant
<russell(a)russellbryant.net&gt; wrote:
>  I haven't tested this script fully yet.  I've been running
> things manually
>  and now I'm trying to build RPMs and start everything as services but
>  I'm having some problems.  I noticed this while debugging it. 
no idea how it works, but it certainly seems to :-)
ack

>  I still need to figure out why /var/lib/matahari and /var/run/matahari
>  don't seem to be created properly when installing the RPMs though.
>  I'm using Fedora 15. 
Probably because of the (newly introduced) %ghost directive.
This only affects the broker though right?  Probably need to have the
init script create them :-(

>  -----
>
>  matahari-serviced is now matahari-qmf-serviced, so tweak the init script
>  to match that naming scheme.
>
>  Signed-off-by: Russell Bryant <russell(a)russellbryant.net&gt;
>  ---
>   matahari.init.in |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
>  diff --git a/matahari.init.in b/matahari.init.in
>  index c967b8d..ed34c4b 100644
>  --- a/matahari.init.in
>  +++ b/matahari.init.in
>  @@ -23,7 +23,7 @@
>
>   SERVICE=`readlink -f "$0"`
>   SERVICE=`basename "$SERVICE"`
>  -PROCESS=`echo "$SERVICE"d`
>  +PROCESS=`echo "$SERVICE" | cut -f1 -d'-'`-qmf-`echo
> "$SERVICE" | cut -f2 -d'-'`d
>
>   RETVAL=0
>
>  --
>  1.7.4.4
>
>  _______________________________________________
>  Matahari mailing list
>  Matahari(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/matahari
>

[Roman Rakus]

I have few comments. Inline in patch.
On 05/02/2011 09:29 AM, Andrew Beekhof wrote:
>  On Fri, Apr 29, 2011 at 5:54 PM, Russell Bryant
>  <russell(a)russellbryant.net&gt;  wrote:
> > I haven't tested this script fully yet.  I've been running things manually
> > and now I'm trying to build RPMs and start everything as services but
> > I'm having some problems.  I noticed this while debugging it.
>  no idea how it works, but it certainly seems to :-)
>  ack
>
> > I still need to figure out why /var/lib/matahari and /var/run/matahari
> > don't seem to be created properly when installing the RPMs though.
> > I'm using Fedora 15.
>  Probably because of the (newly introduced) %ghost directive.
>  This only affects the broker though right?  Probably need to have the
>  init script create them :-(
>
> > -----
> >
> > matahari-serviced is now matahari-qmf-serviced, so tweak the init script
> > to match that naming scheme.
> >
> > Signed-off-by: Russell Bryant&lt;russell(a)russellbryant.net&gt;
> > ---
> >   matahari.init.in |    2 +-
> >   1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/matahari.init.in b/matahari.init.in
> > index c967b8d..ed34c4b 100644
> > --- a/matahari.init.in
> > +++ b/matahari.init.in
> > @@ -23,7 +23,7 @@
> >
> >   SERVICE=`readlink -f "$0"`
> >   SERVICE=`basename "$SERVICE"` 
This can be connected together. No
need to do twice SERVICE=
> > -PROCESS=`echo "$SERVICE"d`
> > +PROCESS=`echo "$SERVICE" | cut -f1 -d'-'`-qmf-`echo
> "$SERVICE" | cut -f2 -d'-'`d 
This is not good. Not necessary to
call echo. Anyway, this can be done 
by shell's pattern substitution. Or rename matahari-service to 
matahari-qmf-service?

RR
> >   RETVAL=0
> >
> > --
> > 1.7.4.4
> >
> > _______________________________________________
> > Matahari mailing list
> > Matahari(a)lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/matahari
> >
>  _______________________________________________
>  Matahari mailing list
>  Matahari(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/matahari

[Andrew Beekhof]

On Tue, May 3, 2011 at 3:04 PM, Roman Rakus <rrakus(a)redhat.com&gt; wrote:
>  I have few comments. Inline in patch.
>  On 05/02/2011 09:29 AM, Andrew Beekhof wrote:
> > On Fri, Apr 29, 2011 at 5:54 PM, Russell Bryant
> > <russell(a)russellbryant.net&gt;  wrote:
> >> I haven't tested this script fully yet.  I've been running things
> manually
> >> and now I'm trying to build RPMs and start everything as services but
> >> I'm having some problems.  I noticed this while debugging it.
> > no idea how it works, but it certainly seems to :-)
> > ack
> >
> >> I still need to figure out why /var/lib/matahari and /var/run/matahari
> >> don't seem to be created properly when installing the RPMs though.
> >> I'm using Fedora 15.
> > Probably because of the (newly introduced) %ghost directive.
> > This only affects the broker though right?  Probably need to have the
> > init script create them :-(
> >
> >> -----
> >>
> >> matahari-serviced is now matahari-qmf-serviced, so tweak the init script
> >> to match that naming scheme.
> >>
> >> Signed-off-by: Russell Bryant&lt;russell(a)russellbryant.net&gt;
> >> ---
> >>   matahari.init.in |    2 +-
> >>   1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/matahari.init.in b/matahari.init.in
> >> index c967b8d..ed34c4b 100644
> >> --- a/matahari.init.in
> >> +++ b/matahari.init.in
> >> @@ -23,7 +23,7 @@
> >>
> >>   SERVICE=`readlink -f "$0"`
> >>   SERVICE=`basename "$SERVICE"`
>  This can be connected together. No need to do twice SERVICE=
> >> -PROCESS=`echo "$SERVICE"d`
> >> +PROCESS=`echo "$SERVICE" | cut -f1 -d'-'`-qmf-`echo
> "$SERVICE" | cut -f2 -d'-'`d
>  This is not good. Not necessary to call echo. Anyway, this can be done
>  by shell's pattern substitution. Or rename matahari-service to
>  matahari-qmf-service? 
would there ever be a matahari-dbus-service?

>  RR
> >>   RETVAL=0
> >>
> >> --
> >> 1.7.4.4
> >>
> >> _______________________________________________
> >> Matahari mailing list
> >> Matahari(a)lists.fedorahosted.org
> >> https://fedorahosted.org/mailman/listinfo/matahari
> >>
> > _______________________________________________
> > Matahari mailing list
> > Matahari(a)lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/matahari
>
>  _______________________________________________
>  Matahari mailing list
>  Matahari(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/matahari
>