Gnumed server is now in Fedora.

[susmit shannigrahi]

Hi,

Gnumed server is now in Fedora.
On the way to get gnumed-client in.

https://bugzilla.redhat.com/show_bug.cgi?id=669146

Thanks.

[Sebastian Hilbert]

Am Donnerstag, 2. Juni 2011, 22:57:29 schrieb susmit shannigrahi:
> Hi,
>
> Gnumed server is now in Fedora.
> On the way to get gnumed-client in.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=669146
>
> Thanks.

Good stuff.

Sebastian

[Sebastian Hilbert]

Am Donnerstag, 2. Juni 2011, 22:57:29 schrieb susmit shannigrahi:

Hi,
> Gnumed server is now in Fedora.
> On the way to get gnumed-client in.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=669146

Looks like the package is for GNUmed 14.8.

If you have time please consider updating this to gnumed-server 15.5

I am looking at your spec file but usually it does not involve heavy changes 
when adapting it to a new major version.

Regards,
Sebastian

[susmit shannigrahi]

On Thu, Jun 2, 2011 at 11:25 PM, Sebastian Hilbert
 wrote:
> Am Donnerstag, 2. Juni 2011, 22:57:29 schrieb susmit shannigrahi:
>
> Hi,
> > Gnumed server is now in Fedora.
> > On the way to get gnumed-client in.
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=669146
>
> Looks like the package is for GNUmed 14.8.

Sure. I shall push an update as soon as it is in the repo.
> If you have time please consider updating this to gnumed-server 15.5
>
> I am looking at your spec file but usually it does not involve heavy changes
> when adapting it to a new major version.
>
> Regards,
> Sebastian
> _______________________________________________
> Medical-sig mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/medical-sig

[Sebastian Hilbert]

Am Freitag, 3. Juni 2011, 07:26:43 schrieb susmit shannigrahi:
> On Thu, Jun 2, 2011 at 11:25 PM, Sebastian Hilbert
>
>  wrote:
> > Am Donnerstag, 2. Juni 2011, 22:57:29 schrieb susmit shannigrahi:
> >
> > Hi,
> > > Gnumed server is now in Fedora.
> > > On the way to get gnumed-client in.
> > >
> > > https://bugzilla.redhat.com/show_bug.cgi?id=669146
> >
> > Looks like the package is for GNUmed 14.8.
>
> Sure. I shall push an update as soon as it is in the repo.

Thanks for that.

I have looked at your spec and have used it in the OpenBuildService to build 
rpms for oepnSUSE,Mandriva. Fedora, RHEL and a few more.

Fedora 14 works fine.

CentOS, openSUSE 11.4 and RHEL5 bail out

CentOS, Redhat EL 5  bail out with

usr/src/redhat/BUILD/gnumed-server.14.8
+ /usr/lib/rpm/brp-compress
+ /usr/lib/rpm/brp-strip
+ /usr/lib/rpm/brp-strip-static-archive
+ /usr/lib/rpm/brp-strip-comment-note
Processing files: gnumed-server-14.8-12.1
error: File not found: /usr/share/doc/gnumed-server
error: File not found: /usr/com/gnumed-server
error: File not found by glob: /usr/bin/gm-*
error: File not found by glob: /usr/share/man/man8/gm-*
error: File not found by glob: /usr/share/man/man1/gm-*
error: File not found: /etc/gnumed-server
Checking for unpackaged file(s): /usr/lib/rpm/check-files %{buildroot}

RPM build errors:
    File not found: /usr/share/doc/gnumed-server
    File not found: /usr/com/gnumed-server
    File not found by glob: /usr/bin/gm-*
    File not found by glob: /usr/share/man/man8/gm-*
    File not found by glob: /usr/share/man/man1/gm-*
    File not found: /etc/gnumed-server

Anything that can be done about it ?

openSUSE 11.3 and Factory work fine but openSUSE 11.4 bails out with

Wrote: /usr/src/packages/SRPMS/gnumed-server-14.8-12.1.src.rpm
Wrote: /usr/src/packages/RPMS/noarch/gnumed-server-14.8-12.1.noarch.rpm
Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.WK9rSz
+ umask 022
+ cd /usr/src/packages/BUILD
+ cd gnumed-server.14.8
+ /bin/rm -rf /usr/src/packages/BUILDROOT/gnumed-server-14.8-12.1.i386
+ exit 0
... checking for files with abuild user/group
... running 00-check-install-rpms
... installing all built rpms
Preparing packages for installation...
gnumed-server-14.8-12.1
... running 01-check-debuginfo
... testing for empty debuginfo packages
grep: //usr/src/packages/SOURCES/gnumed-server.spec: No such file or directory
... running 02-check-gcc-output
... testing for serious compiler warnings
    (using /usr/lib/build/checks-data/check_gcc_output)
    (using //.build.log)
... running 03-check-binary-kernel-log
... running 04-check-filelist
... checking filelist
gnumed-server-14.8-12.1.noarch.rpm: directories not owned by a package:
 - /usr/com
[  165.406618] SysRq : Power Off
[  167.113596] Power down.

Any help is appreciated.

Regards,
Sebastian Hilbert

[susmit shannigrahi]

Hi,
> > > > https://bugzilla.redhat.com/show_bug.cgi?id=669146

Updated to 15.5.
> I have looked at your spec and have used it in the OpenBuildService to build
> rpms for oepnSUSE,Mandriva. Fedora, RHEL and a few more.

Specfiles for Fedora packaging, without any modification, may not be
suitable for RPM generation on other platforms. It will require some
minor modifications. That is to be expected.

Thanks.

[Ankur Sinha]

On Tue, 2011-06-07 at 00:53 -0600, susmit shannigrahi wrote:
> Specfiles for Fedora packaging, without any modification, may not be
> suitable for RPM generation on other platforms. It will require some
> minor modifications. That is to be expected.

Hi!

I don't know a lot about the packaging guidelines at OpenSUSE, but in
order to get the fedora spec to work there are quite a few things you
need to take care of:

1. make necessary changes to the macros
2. make necessary changes to build requires
3. make necessary changes to scriptlets
4. package necessary build requires!

These are what I can think off the top of my head. Like Christoph
pointed out, fedora and opensuse specs can be referred, but not used
blindly. :)

Thanks!
Ankur

[susmit shannigrahi]

Hi Sebastian,

There were a few minor issues regrading this package. The package is
already submitted for inclusion and these issues does not affect that.
But it would be nice if they can be fixed.

[makerpm@susmit SOURCES]$ rpmlint
../RPMS/noarch/gnumed-server-15.5-2.fc14.noarch.rpm
gnumed-server.noarch: E: incorrect-fsf-address
/usr/share/doc/gnumed-server/GnuPublicLicense.txt

Some file in the package is licenced under GPL (not GPLv2). Ankur, do
you remember which ones?

gnumed-server.noarch: W: no-manual-page-for-binary gm-fingerprint_db.py
gnumed-server.noarch: W: no-manual-page-for-binary gm-bootstrap_server.orig
gnumed-server.noarch: W: no-manual-page-for-binary gm-zip+sign_backups
gnumed-server.noarch: W: no-manual-page-for-binary gm-move_backups_offsite
gnumed-server.noarch: W: no-manual-page-for-binary gm-restore_data
gnumed-server.noarch: W: no-manual-page-for-binary gm-restore_database

These executables does not have any doc.

Thanks.

[Sebastian Hilbert]

Am Dienstag, 7. Juni 2011, 08:53:00 schrieb susmit shannigrahi:
> Hi,
> > > > > https://bugzilla.redhat.com/show_bug.cgi?id=669146
>
> Updated to 15.5.
> > I have looked at your spec and have used it in the OpenBuildService to
> > build rpms for oepnSUSE,Mandriva. Fedora, RHEL and a few more.
>
> Specfiles for Fedora packaging, without any modification, may not be
> suitable for RPM generation on other platforms. It will require some
> minor modifications. That is to be expected.

I am aware that this was expected. I thought anyone can explain the error 
messages. Forget about openSUSE for the moment but fixing this for RHEL and 
CentOS might be a good step forward as these should be close to Fedora (?).

Best regards,
Sebastian

[susmit shannigrahi]

> I am aware that this was expected. I thought anyone can explain the error
> messages. Forget about openSUSE for the moment but fixing this for RHEL and
> CentOS might be a good step forward as these should be close to Fedora (?).

Oh, ok, I misunderstood. Sorry about that.

For RHEL/CentOS,

we need a  BuildRoot tag

%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

and an install section.

%install
rm -rf %{buildroot}

There are a few more minor modifications that might be needed
depending on what type of files are in there.

http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_specif...

Thanks.

[Sebastian Hilbert]

Am Dienstag, 7. Juni 2011, 21:11:46 schrieb susmit shannigrahi:
> > I am aware that this was expected. I thought anyone can explain the error
> > messages. Forget about openSUSE for the moment but fixing this for RHEL
> > and CentOS might be a good step forward as these should be close to
> > Fedora (?).
>
> Oh, ok, I misunderstood. Sorry about that.
>
> For RHEL/CentOS,
>
> we need a  BuildRoot tag
>
> %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
>
> and an install section.
>
> %install
> rm -rf %{buildroot}
>
> There are a few more minor modifications that might be needed
> depending on what type of files are in there.
>
> http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_speci
> fic_guidelines

Worked. Thanks.

Sebastian

[Sebastian Hilbert]

Am Dienstag, 7. Juni 2011, 22:43:16 schrieb Sebastian Hilbert:
> Am Dienstag, 7. Juni 2011, 21:11:46 schrieb susmit shannigrahi:
> > > I am aware that this was expected. I thought anyone can explain the
> > > error messages. Forget about openSUSE for the moment but fixing this
> > > for RHEL and CentOS might be a good step forward as these should be
> > > close to Fedora (?).
> >
> > Oh, ok, I misunderstood. Sorry about that.
> >
> > For RHEL/CentOS,
> >
> > we need a  BuildRoot tag
> >
> > %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
> >
> > and an install section.
> >
> > %install
> > rm -rf %{buildroot}
> >
> > There are a few more minor modifications that might be needed
> > depending on what type of files are in there.
> >
> > http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_spe
> > ci fic_guidelines
>
> Worked. Thanks.

on some openSUSE systemsI get

gnumed-server: "/usr/com/gnumed-server/sql/v9-v10/static/v10-gm-access_log-
static.sql" is not allowed anymore in FHS 2.2.
gnumed-server: "/usr/com/gnumed-server/sql/v9-v10/static/v10-i18n-curr_lang-
static.sql" is not allowed anymore in FHS 2.2.
gnumed-server: "/usr/com/gnumed-server/sql/v9-v10/superuser" is not allowed 
anymore in FHS 2.2.
gnumed-server: "/usr/com/gnumed-server/sql/v9-v10/superuser/v10-adjust-
gm_dbo.sql" is not allowed anymore in FHS 2.2.
gnumed-server: "/usr/com/gnumed-server/version.txt" is not allowed anymore in 
FHS 2.2.
gnumed-server-14.8-15.1.noarch.rpm: directories not owned by a package:

That makes me wonder what gets put in /usr/com

I have never heared of that directory before. But this seems to fail only on 
older SLEnterprise.

Sebastian
> Sebastian
> _______________________________________________
> Medical-sig mailing list
> [e-mail]
> https://fedorahosted.org/mailman/listinfo/medical-sig

[susmit shannigrahi]

> That makes me wonder what gets put in /usr/com

There is no /usr/com.
We used macros for putting those files in place, and the build system
is expanding that macros wrongly.

[Sebastian Hilbert]

Am Dienstag, 7. Juni 2011, 23:09:58 schrieb susmit shannigrahi:
> > That makes me wonder what gets put in /usr/com
>
> There is no /usr/com.
> We used macros for putting those files in place, and the build system
> is expanding that macros wrongly.

Ah, thanks. That is what I thought.

Hmm, strange openSUSE 11.3 has no problem and openSUSE factory neither. Only 
openSUSE 11.4 screws things up.

Will have to investigate

Sebastian

[Sebastian Hilbert]

Am Dienstag, 7. Juni 2011, 22:55:14 schrieb Sebastian Hilbert:
> gnumed-server-14.8-15.1.noarch.rpm: directories not owned by a package:

Reply to self.

putting /usr/com in the files section make it work for openSUSE 11.4

This means that your spec file works for mandriva, fedora,centos, RHEL, 
openSUSE 11.3, 11.4 with minor modifications.

Sebastian

[Sebastian Hilbert]

Am Donnerstag, 2. Juni 2011, 22:57:29 schrieb susmit shannigrahi:

Hi all,
> Hi,
>
> Gnumed server is now in Fedora.
> On the way to get gnumed-client in.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=669146
>
> Thanks.

I do not have a Fedora test system but I am pretty sure there is an error in 
the patch file.

this is the original patch

--- GNUmed-v10.rc4/server/gm-bootstrap_server   2009-02-05 14:05:19.000000000 
+0100
+++ GNUmed-v10.rc4/server/gm-bootstrap_server   2009-02-17 20:57:54.000000000 
+0100
@@ -17,7 +17,7 @@
 # those probably need some adjustment from package maintainers:

GM_LOG_BASE="/var/log/gnumed/server"
-GM_SERVER_DIR="/var/lib/gnumed/server/bootstrap"
+GM_SERVER_DIR="/usr/lib/gnumed-server/server/bootstrap"

the patched lines need to be corrected from 17 to 14

second there is a surplus directory 'server'

instead of +GM_SERVER_DIR="/usr/lib/gnumed-server/server/bootstrap"

it needs to be

+GM_SERVER_DIR="/usr/lib/gnumed-server/bootstrap"

without the extra 'server'

furthermore the file gm-upgrade_server

needs to be patched in the same way.

Thanks,

Sebastian