mingw February 2011

mingw@lists.fedoraproject.org

7 participants
69 discussions

[Bug 673784] Rename Request: mingw32-filesystem -> cross-filesystem - Cross compiler base filesystem and environment
by Red Hat Bugzilla 21 Feb '11

21 Feb '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 --- Comment #16 from amorilia(a)users.sourceforge.net 2011-02-21 15:51:33 EST --- Ok. Informal review follows. + OK ! Needs to be looked into / Not applicable * Overridden by MinGW guidelines ? Unsure ======= Rpmlint ======= $ rpmlint cross-filesystem.spec cross-filesystem.spec:75: W: unversioned-explicit-provides mingw32(kernel32.dll) cross-filesystem.spec:76: W: unversioned-explicit-provides mingw32(msvcrt.dll) cross-filesystem.spec:77: W: unversioned-explicit-provides mingw32(advapi32.dll) cross-filesystem.spec:78: W: unversioned-explicit-provides mingw32(user32.dll) cross-filesystem.spec:79: W: unversioned-explicit-provides mingw32(dnsapi.dll) cross-filesystem.spec:80: W: unversioned-explicit-provides mingw32(ole32.dll) cross-filesystem.spec:81: W: unversioned-explicit-provides mingw32(shell32.dll) cross-filesystem.spec:82: W: unversioned-explicit-provides mingw32(shlwapi.dll) cross-filesystem.spec:83: W: unversioned-explicit-provides mingw32(ws2_32.dll) cross-filesystem.spec:84: W: unversioned-explicit-provides mingw32(gdi32.dll) cross-filesystem.spec:85: W: unversioned-explicit-provides mingw32(msimg32.dll) cross-filesystem.spec:86: W: unversioned-explicit-provides mingw32(comctl32.dll) cross-filesystem.spec:87: W: unversioned-explicit-provides mingw32(comdlg32.dll) cross-filesystem.spec:88: W: unversioned-explicit-provides mingw32(imm32.dll) cross-filesystem.spec:89: W: unversioned-explicit-provides mingw32(crypt32.dll) cross-filesystem.spec:90: W: unversioned-explicit-provides mingw32(oleaut32.dll) cross-filesystem.spec:91: W: unversioned-explicit-provides mingw32(opengl32.dll) cross-filesystem.spec:92: W: unversioned-explicit-provides mingw32(version.dll) cross-filesystem.spec:93: W: unversioned-explicit-provides mingw32(winmm.dll) cross-filesystem.spec:94: W: unversioned-explicit-provides mingw32(rpcrt4.dll) cross-filesystem.spec:95: W: unversioned-explicit-provides mingw32(gdiplus.dll) cross-filesystem.spec:96: W: unversioned-explicit-provides mingw32(usp10.dll) cross-filesystem.spec:97: W: unversioned-explicit-provides mingw32(msdmo.dll) cross-filesystem.spec:98: W: unversioned-explicit-provides mingw32(odbc32.dll) cross-filesystem.spec:108: W: unversioned-explicit-provides mingw64(kernel32.dll) cross-filesystem.spec:109: W: unversioned-explicit-provides mingw64(msvcrt.dll) cross-filesystem.spec:110: W: unversioned-explicit-provides mingw64(advapi32.dll) cross-filesystem.spec:111: W: unversioned-explicit-provides mingw64(user32.dll) cross-filesystem.spec:112: W: unversioned-explicit-provides mingw64(dnsapi.dll) cross-filesystem.spec:113: W: unversioned-explicit-provides mingw64(ole32.dll) cross-filesystem.spec:114: W: unversioned-explicit-provides mingw64(shell32.dll) cross-filesystem.spec:115: W: unversioned-explicit-provides mingw64(shlwapi.dll) cross-filesystem.spec:116: W: unversioned-explicit-provides mingw64(ws2_32.dll) cross-filesystem.spec:117: W: unversioned-explicit-provides mingw64(gdi32.dll) cross-filesystem.spec:118: W: unversioned-explicit-provides mingw64(msimg32.dll) cross-filesystem.spec:119: W: unversioned-explicit-provides mingw64(comctl32.dll) cross-filesystem.spec:120: W: unversioned-explicit-provides mingw64(comdlg32.dll) cross-filesystem.spec:121: W: unversioned-explicit-provides mingw64(imm32.dll) cross-filesystem.spec:122: W: unversioned-explicit-provides mingw64(crypt32.dll) cross-filesystem.spec:123: W: unversioned-explicit-provides mingw64(oleaut32.dll) cross-filesystem.spec:124: W: unversioned-explicit-provides mingw64(opengl32.dll) cross-filesystem.spec:125: W: unversioned-explicit-provides mingw64(version.dll) cross-filesystem.spec:126: W: unversioned-explicit-provides mingw64(winmm.dll) cross-filesystem.spec:127: W: unversioned-explicit-provides mingw64(rpcrt4.dll) cross-filesystem.spec:128: W: unversioned-explicit-provides mingw64(gdiplus.dll) cross-filesystem.spec:129: W: unversioned-explicit-provides mingw64(usp10.dll) cross-filesystem.spec:130: W: unversioned-explicit-provides mingw64(msdmo.dll) cross-filesystem.spec:131: W: unversioned-explicit-provides mingw64(odbc32.dll) cross-filesystem.spec:174: W: macro-in-comment %{_prefix} 0 packages and 1 specfiles checked; 0 errors, 49 warnings. [!] Remove lines 173-174 to get rid of the macro-in-comment warning. Other warnings are obviously false positives (per comments in spec file). $ rpmlint cross-filesystem-65-1.fc15_cross.src.rpm cross-filesystem.src: W: strange-permission cross-find-provides.sh 0775L cross-filesystem.src: W: strange-permission cross-find-debuginfo.sh 0775L cross-filesystem.src: W: strange-permission cross-find-requires.sh 0775L cross-filesystem.src: W: strange-permission cross-scripts.sh 0775L cross-filesystem.src: W: strange-permission cross-find-lang.sh 0775L cross-filesystem.src:75: W: unversioned-explicit-provides mingw32(kernel32.dll) cross-filesystem.src:76: W: unversioned-explicit-provides mingw32(msvcrt.dll) cross-filesystem.src:77: W: unversioned-explicit-provides mingw32(advapi32.dll) cross-filesystem.src:78: W: unversioned-explicit-provides mingw32(user32.dll) cross-filesystem.src:79: W: unversioned-explicit-provides mingw32(dnsapi.dll) cross-filesystem.src:80: W: unversioned-explicit-provides mingw32(ole32.dll) cross-filesystem.src:81: W: unversioned-explicit-provides mingw32(shell32.dll) cross-filesystem.src:82: W: unversioned-explicit-provides mingw32(shlwapi.dll) cross-filesystem.src:83: W: unversioned-explicit-provides mingw32(ws2_32.dll) cross-filesystem.src:84: W: unversioned-explicit-provides mingw32(gdi32.dll) cross-filesystem.src:85: W: unversioned-explicit-provides mingw32(msimg32.dll) cross-filesystem.src:86: W: unversioned-explicit-provides mingw32(comctl32.dll) cross-filesystem.src:87: W: unversioned-explicit-provides mingw32(comdlg32.dll) cross-filesystem.src:88: W: unversioned-explicit-provides mingw32(imm32.dll) cross-filesystem.src:89: W: unversioned-explicit-provides mingw32(crypt32.dll) cross-filesystem.src:90: W: unversioned-explicit-provides mingw32(oleaut32.dll) cross-filesystem.src:91: W: unversioned-explicit-provides mingw32(opengl32.dll) cross-filesystem.src:92: W: unversioned-explicit-provides mingw32(version.dll) cross-filesystem.src:93: W: unversioned-explicit-provides mingw32(winmm.dll) cross-filesystem.src:94: W: unversioned-explicit-provides mingw32(rpcrt4.dll) cross-filesystem.src:95: W: unversioned-explicit-provides mingw32(gdiplus.dll) cross-filesystem.src:96: W: unversioned-explicit-provides mingw32(usp10.dll) cross-filesystem.src:97: W: unversioned-explicit-provides mingw32(msdmo.dll) cross-filesystem.src:98: W: unversioned-explicit-provides mingw32(odbc32.dll) cross-filesystem.src:108: W: unversioned-explicit-provides mingw64(kernel32.dll) cross-filesystem.src:109: W: unversioned-explicit-provides mingw64(msvcrt.dll) cross-filesystem.src:110: W: unversioned-explicit-provides mingw64(advapi32.dll) cross-filesystem.src:111: W: unversioned-explicit-provides mingw64(user32.dll) cross-filesystem.src:112: W: unversioned-explicit-provides mingw64(dnsapi.dll) cross-filesystem.src:113: W: unversioned-explicit-provides mingw64(ole32.dll) cross-filesystem.src:114: W: unversioned-explicit-provides mingw64(shell32.dll) cross-filesystem.src:115: W: unversioned-explicit-provides mingw64(shlwapi.dll) cross-filesystem.src:116: W: unversioned-explicit-provides mingw64(ws2_32.dll) cross-filesystem.src:117: W: unversioned-explicit-provides mingw64(gdi32.dll) cross-filesystem.src:118: W: unversioned-explicit-provides mingw64(msimg32.dll) cross-filesystem.src:119: W: unversioned-explicit-provides mingw64(comctl32.dll) cross-filesystem.src:120: W: unversioned-explicit-provides mingw64(comdlg32.dll) cross-filesystem.src:121: W: unversioned-explicit-provides mingw64(imm32.dll) cross-filesystem.src:122: W: unversioned-explicit-provides mingw64(crypt32.dll) cross-filesystem.src:123: W: unversioned-explicit-provides mingw64(oleaut32.dll) cross-filesystem.src:124: W: unversioned-explicit-provides mingw64(opengl32.dll) cross-filesystem.src:125: W: unversioned-explicit-provides mingw64(version.dll) cross-filesystem.src:126: W: unversioned-explicit-provides mingw64(winmm.dll) cross-filesystem.src:127: W: unversioned-explicit-provides mingw64(rpcrt4.dll) cross-filesystem.src:128: W: unversioned-explicit-provides mingw64(gdiplus.dll) cross-filesystem.src:129: W: unversioned-explicit-provides mingw64(usp10.dll) cross-filesystem.src:130: W: unversioned-explicit-provides mingw64(msdmo.dll) cross-filesystem.src:131: W: unversioned-explicit-provides mingw64(odbc32.dll) cross-filesystem.src:174: W: macro-in-comment %{_prefix} 1 packages and 0 specfiles checked; 0 errors, 54 warnings. [!] "chmod 755" all scripts. $ rpm -i cross-filesystem-65-1.fc15_cross.src.rpm Install works. $ svn co http://svn.openftd.org/svn/fedora_cross/cross-filesystem/ $ diff cross-filesystem ~/rpmbuild/SOURCES/ Only in cross-filesystem: cross-filesystem.spec Only in cross-filesystem: Makefile Only in cross-filesystem: .svn Looks fine. $ rpmbuild -ba cross-filesystem.spec ... Build succeeds. $ rpmlint ~/rpmbuild/RPMS/noarch/cross-filesystem-65-1.fc14.noarch.rpm cross-filesystem.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/cross-filesystem-scripts-65-1.fc14.noarch.rpm cross-filesystem-scripts.noarch: W: unexpanded-macro %description -l C %{description} cross-filesystem-scripts.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [!] unexpanded-macro: The cross-filesystem-scripts-description needs fixing (the packaging guidelines suggest either to avoid macros in the description, or to define the macro explicitly in the spec file). [?] only-non-binary-in-usr-lib: This seems to suggest that everything should go into %{_datadir} instead (i.e. /usr/share/). Since these all concern rpm scripts, am I right that an exception applies (because rpm generally installs its scripts in /usr/lib/rpm and nowhere else)? $ rpmlint ~/rpmbuild/RPMS/noarch/mingw32-filesystem-65-1.fc14.noarch.rpm mingw32-filesystem.noarch: W: unexpanded-macro %description -l C %{description} mingw32-filesystem.noarch: W: obsolete-not-provided mingw32-dlfcn mingw32-filesystem.noarch: W: no-documentation mingw32-filesystem.noarch: W: dangling-symlink /usr/bin/mingw32-configure /usr/libexec/cross-scripts mingw32-filesystem.noarch: W: no-manual-page-for-binary mingw32-configure mingw32-filesystem.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 1 packages and 0 specfiles checked; 0 errors, 6 warnings. [!] unexpanded-macro: Fix description. [!] obsolete-not-provided: Add "Provides: mingw32-dlfcn = 0-0.8.r11%{?dist}". no-documentation: Bogus warning. dangling-symlink: Bogus warning (link provided by required subpackage). no-manual-page-for-binary: Bogus. non-standard-dir-in-usr: Approved by Fedora MinGW guidelines. $ rpmlint ~/rpmbuild/RPMS/noarch/mingw64-filesystem-65-1.fc14.noarch.rpm mingw64-filesystem.noarch: W: unexpanded-macro %description -l C %{description} mingw64-filesystem.noarch: W: no-documentation mingw64-filesystem.noarch: W: dangling-symlink /usr/bin/mingw64-configure /usr/libexec/cross-scripts mingw64-filesystem.noarch: W: no-manual-page-for-binary mingw64-configure 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Dito. ============ Dependencies ============ $ su -c 'yum erase mingw*' # make sure everything is clean $ su -c 'yum install mingw32-filesystem' $ rpm -qa | grep mingw mingw32-filesystem-63-1.fc14.noarch $ su -c 'rpm -Uv /home/amorilia/rpmbuild/RPMS/noarch/cross-filesystem*.rpm /home/amorilia/rpmbuild/RPMS/noarch/mingw??-filesystem*.rpm' Preparing packages for installation... cross-filesystem-scripts-65-1.fc14 mingw32-filesystem-65-1.fc14 mingw64-filesystem-65-1.fc14 cross-filesystem-65-1.fc14 $ rpmquery --requires cross-filesystem setup rpm rpmlint >= 0.85-2 mingw32-filesystem = 65-1.fc14 mingw64-filesystem = 65-1.fc14 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpmquery --requires cross-filesystem-scripts /bin/bash /bin/sh config(cross-filesystem-scripts) = 65-1.fc14 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpmquery --requires mingw32-filesystem config(mingw32-filesystem) = 65-1.fc14 cross-filesystem-scripts = 65-1.fc14 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpmquery --requires mingw64-filesystem config(mingw64-filesystem) = 65-1.fc14 cross-filesystem-scripts = 65-1.fc14 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpmquery --provides cross-filesystem cross-filesystem = 65-1.fc14 $ rpmquery --provides cross-filesystem-scripts config(cross-filesystem-scripts) = 65-1.fc14 cross-filesystem-scripts = 65-1.fc14 $ rpmquery --provides mingw32-filesystem config(mingw32-filesystem) = 65-1.fc14 mingw32(advapi32.dll) mingw32(comctl32.dll) mingw32(comdlg32.dll) mingw32(crypt32.dll) mingw32(dnsapi.dll) mingw32(gdi32.dll) mingw32(gdiplus.dll) mingw32(imm32.dll) mingw32(kernel32.dll) mingw32(msdmo.dll) mingw32(msimg32.dll) mingw32(msvcrt.dll) mingw32(odbc32.dll) mingw32(ole32.dll) mingw32(oleaut32.dll) mingw32(opengl32.dll) mingw32(rpcrt4.dll) mingw32(shell32.dll) mingw32(shlwapi.dll) mingw32(user32.dll) mingw32(usp10.dll) mingw32(version.dll) mingw32(winmm.dll) mingw32(ws2_32.dll) mingw32-filesystem = 65-1.fc14 $ rpmquery --provides mingw64-filesystem config(mingw64-filesystem) = 65-1.fc14 mingw64(advapi32.dll) mingw64(comctl32.dll) mingw64(comdlg32.dll) mingw64(crypt32.dll) mingw64(dnsapi.dll) mingw64(gdi32.dll) mingw64(gdiplus.dll) mingw64(imm32.dll) mingw64(kernel32.dll) mingw64(msdmo.dll) mingw64(msimg32.dll) mingw64(msvcrt.dll) mingw64(odbc32.dll) mingw64(ole32.dll) mingw64(oleaut32.dll) mingw64(opengl32.dll) mingw64(rpcrt4.dll) mingw64(shell32.dll) mingw64(shlwapi.dll) mingw64(user32.dll) mingw64(usp10.dll) mingw64(version.dll) mingw64(winmm.dll) mingw64(ws2_32.dll) mingw64-filesystem = 65-1.fc14 ======= Testing ======= $ su -c 'yum install mingw32-gcc' $ mingw32-configure ... [!] Obviously breaks stuff at the moment because the scripts refer to the new mingw-w64 toolchain. But this is expected behaviour. See http://fedoraproject.org/wiki/MinGW/CrossCompilerFramework#Roadmap ================================= Fedora MinGW Packaging Guidelines ================================= [/] Track Fedora native package versions: stay at same version, include all the same patches as the native Fedora package, and be built with the same configuration options. [+] Packages named by prefixing upstream package name with mingw32- [/] Use of standard mingw RPM macros %{_mingw32_xxx} [+] Dll dependencies expressed as mingw32(*.dll) [/] Dependencies: %global _use_internal_dependency_generator 0 %global __find_requires %{_mingw32_findrequires} %global __find_provides %{_mingw32_findprovides} [/] BuildRequires: mingw32-filesystem >= xx [+] BuildArch: noarch [/] All files are installed in %{_mingw32_sysroot} [/] .dll in %{_mingw32_bindir}, .dll.a (and .la and .a where applicable) in %{_mingw32_libdir} [/] No man and info files which are already in Fedora native package [/] Static libraries in -static subpackage [/] Stripping: %global __strip %{_mingw32_strip} %global __objdump %{_mingw32_objdump} Not in guidelines, but seems to be policy: [/] Debuginfo: %define __debug_install_post %{_mingw32_debug_install_post} %{_mingw32_debug_package} [/] Package does not contain .exe files. =========================== Fedora Packaging Guidelines =========================== [+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. [+] MUST: The package must be named according to the Package Naming Guidelines . [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [2] . [+] MUST: The package must meet the Packaging Guidelines . [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [/] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [/] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [/] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [/] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [/] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [/] MUST: Header files must be in a -devel package. [/] MUST: Static libraries must be in a -static package. [/] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [/] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [+] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [/] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [+] MUST: All filenames in rpm packages must be valid UTF-8. [/] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [/] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [+] SHOULD: The reviewer should test that the package builds in mock. mock -r fedora-14-x86_64 ~/rpmbuild/SRPMS/cross-filesystem-65-1.fc14.src.rpm mock -r fedora-14-i386 ~/rpmbuild/SRPMS/cross-filesystem-65-1.fc14.src.rpm Both work. [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [/] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [?] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. We have cross-filesystem depends on mingw32/64-filesystem mingw32/64-filesystem depends on cross-filesystem-scripts This seems ok (e.g. people not wanting mingw64 do not need to install mingw64-filesystem), so I don't think this needs fixing. [/] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [/] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [/] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. ================= Summary of issues ================= 1. Remove lines 173-174 in spec to get rid of the macro-in-comment warning. 2. "chmod 755" all scripts. 3. Fix subpackage descriptions (avoid macro, or use a macro that is explicitly defined in the spec file). 4. Add "Provides: mingw32-dlfcn = 0-0.8.r11%{?dist}" to mingw32-filesystem. 5. Not an issue, but an important comment: the package breaks the current mingw32 toolchain due to the switch to mingw-w64. This is unavoidable. Strategy for getting this into rawhide sanely is described here: http://fedoraproject.org/wiki/MinGW/CrossCompilerFramework#Roadmap Unsure: 6. The only-non-binary-in-usr-lib rpmlint warning seems bogus (rpm scripts should indeed go into /usr/lib?) 7. (Too?) strictly speaking, dependencies do not follow guidelines; nevertheless it looks sane to me (see details in review above). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

[Bug 642208] Review Request: mingw32-win-iconv - iconv implementation using Win32 API
by Red Hat Bugzilla 21 Feb '11

21 Feb '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642208 --- Comment #3 from amorilia(a)users.sourceforge.net 2011-02-21 13:25:02 EST --- Thanks - I've learnt a lot! Agreed with all changes. If I had special packager powers, I would approve your package, but until that time, it will be up to a real packager. For the sake of sanity checking, rpmlint output for the update package below. Everything looks ok, as expected. Rpmlint ------- $ rpmlint mingw32-win-iconv.spec mingw32-win-iconv.spec: W: invalid-url Source0: http://win-iconv.googlecode.com/files/win-iconv-0.0.2.tar.bz2 HTTP Error 404: Not Found 0 packages and 1 specfiles checked; 0 errors, 1 warnings. As before, spurious warning. $ rpmlint mingw32-win-iconv-0.0.2-1.fc15.src.rpm mingw32-win-iconv.src: W: invalid-url Source0: http://win-iconv.googlecode.com/files/win-iconv-0.0.2.tar.bz2 HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 1 warnings. As before, spurious warning. $ rpm -i mingw32-win-iconv-0.0.2-1.fc15.src.rpm $ md5sum ~/rpmbuild/SOURCES/win-iconv-0.0.2.tar.bz2 4300d7f337a3c13ab255d4d855057c16 $ curl -s http://win-iconv.googlecode.com/files/win-iconv-0.0.2.tar.bz2 | md5sum 4300d7f337a3c13ab255d4d855057c16 $ diff mingw32-win-iconv.spec ~/rpmbuild/SPECS/mingw32-win-iconv.spec -s Files mingw32-win-iconv.spec and /home/amorilia/rpmbuild/SPECS/mingw32-win-iconv.spec are identical $ rpmbuild -ba mingw32-win-iconv.spec ... Build succeeds. $ rpmlint ~/rpmbuild/RPMS/noarch/mingw32-win-iconv-0.0.2-1.fc14.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/mingw32-win-iconv-debuginfo-0.0.2-1.fc14.noarch.rpm mingw32-win-iconv-debuginfo.noarch: E: debuginfo-without-sources 1 packages and 0 specfiles checked; 1 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/mingw32-win-iconv-static-0.0.2-1.fc14.noarch.rpm mingw32-win-iconv-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libiconv.a mingw32-win-iconv-static.noarch: W: no-documentation 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Looks fine, follows MinGW guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

[Bug 679060] Review Request: mingw32-antlr - MinGW Windows ANTLR C++ run-time library
by Red Hat Bugzilla 21 Feb '11

21 Feb '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=679060 Thomas Sailer <t.sailer(a)alumni.ethz.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora-mingw(a)lists.fedorapr | |oject.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

[Bug 642208] Review Request: mingw32-win-iconv - iconv implementation using Win32 API
by Red Hat Bugzilla 17 Feb '11

17 Feb '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642208 --- Comment #2 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> 2011-02-17 07:39:02 EST --- Thanks for the initial review. You're doing the review very well for a first-timer! Spec URL: http://ftd4linux.nl/contrib/mingw32-win-iconv.spec SRPM URL: http://ftd4linux.nl/contrib/mingw32-win-iconv-0.0.2-1.fc15.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2846284 * Thu Feb 17 2011 Erik van Pienbroek <epienbro(a)fedoraproject.org> - 0.0.2-1 - Update to version 0.0.2 - Dropped upstreamed patch - Dropped the win_iconv.exe binary - Bumped the mingw32-iconv obsoletes The debuginfo stuff is wrapped inside the %{?_mingw32_debug_package} macro. There's no way to inject custom tags in this macro, so adding an obsoletes: mingw32-iconv-debuginfo there isn't possible at the moment. AFAIK, native Fedora packages also don't have an obsoletes on old debuginfo packages when a new package is introduced which obsoletes an old package Once this package gets added to Fedora all packages which depend on libiconv have to be rebuild. I tested this in my mingw-w64 testing repository (which contains all current fedora mingw32 packages) and it causes no (compilation) breakage. I've also done a runtime test using my GTK-based project and it doesn't cause any side effects. This library is also used by the GLib/Gtk developers for their Win32/Win64 binaries of the Gtk stack: http://ftp.gnome.org/pub/gnome/binaries/win64/dependencies/ The packages which need to be rebuilt are (according to repoquery on a F15 host): mingw32-fontconfig-0:2.6.0-11.fc15.noarch mingw32-gettext-0:0.17-14.fc15.noarch mingw32-hunspell-0:1.2.12-2.fc15.noarch mingw32-libidn-0:1.14-7.fc15.noarch mingw32-libxml2-0:2.7.6-2.fc15.noarch A simple rebuild is sufficient for these packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

[Bug 673784] Rename Request: mingw32-filesystem -> cross-filesystem - Cross compiler base filesystem and environment
by Red Hat Bugzilla 15 Feb '11

15 Feb '11

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=673784 --- Comment #15 from Jason Tibbitts <tibbs(a)math.uh.edu> 2011-02-15 14:36:31 EST --- If you are not a packager, you cannot approve packages or take review tickets but of course you are welcome to make all the comments you like. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

1 0

Announcing the Cross Compiler Framework (Win32+Win64)
by Erik van Pienbroek 15 Feb '11

15 Feb '11

Hi everybody, In the last few weeks I worked on creating a method to easily build and maintain RPM packages for both Win32 as well as Win64 targets. Adding support for the Mac OS X target should also be easily possible. This has resulted in a set of RPM packages which I would like to call the Cross Compiler Framework. This set of RPM packages brings various changes to the Fedora MinGW world. The most important one is that the mingw-w64 toolchain is now used instead of the mingw.org toolchain. The reason behind this change is that the mingw-w64 toolchain provides support for both win32 and win64 targets and is more actively maintained than the mingw.org one. So what does this mean for all users and packagers of the current mingw32 packages which are already in Fedora? First of all, the name of the triplet has changed from 'i686-pc-mingw32' to 'i686-w64-mingw32'. This means that commands like for example gcc are now named 'i686-w64-mingw32-gcc'. All mingw32 files are now also saved in the folder /usr/i686-w64-mingw32 instead of /usr/i686-pc-mingw32. Helper scripts like 'mingw32-configure' also still work and refer to the new set of commands and paths. Next to this, various packages have been renamed from 'mingw32-...' to 'cross-...'. This is used to indicate that the package in question contain binaries for multiple targets. If a package has been renamed from 'mingw32-...' to 'cross-...' then the original 'mingw32-...' package will be obsoleted by the 'cross-...' one. All current mingw32 packages should build just fine against this new framework (or with minor patching) There are two repositories published at the moment containing the packages belonging to the cross compiler framework. One contains binaries for both win32 and win64 targets while the other one also contains binaries for Mac OS X. The Mac OS X pieces can't be added to Fedora at the moment because of legal issues and the fact that some binary blobs (from the Mac OS X SDK) were used. All current mingw32 packages which have been in Fedora as of December 30 2010 have been added to the testing repositories. About 32 packages have been ported entirely to the new cross compiler framework. More details about this cross compiler framework including information about the testing repositories and a porting guide can be found at http://fedoraproject.org/wiki/MinGW/CrossCompilerFramework My plan is to get all the packages belonging to the cross compiler framework in Fedora 15, rebuild all current mingw32 packages and rename/port various packages in order to have win32/win64 support. On the link mentioned above there's a plan indicating the steps required to get everything in Fedora. I'll open review requests for the 5 base packages soon and I hope that somebody can review them quickly so we can still make it in time for the Fedora 15 feature freeze (which is about 5 weeks from now). Feel free to test the testing repositories and report back any issues you might find. Other feedback about the cross compiler framework is welcome too. Help with the reviews is very much appreciated as well! Kind regards, Erik van Pienbroek

6 32

[mingw32-glib2/f15/master: 5/5] 2.27.93 was not built for f15
by sailer 13 Feb '11

13 Feb '11

commit 2f9ef83d0f7737291593f86a56710f2108c69807 Author: Thomas Sailer <t.sailer(a)alumni.ethz.ch> Date: Sun Feb 13 18:33:02 2011 +0100 2.27.93 was not built for f15 mingw32-glib2.spec | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) --- diff --git a/mingw32-glib2.spec b/mingw32-glib2.spec index ce5a332..babc936 100644 --- a/mingw32-glib2.spec +++ b/mingw32-glib2.spec @@ -229,9 +229,6 @@ rm -rf $RPM_BUILD_ROOT * Sun Feb 13 2011 Thomas Sailer <t.sailer(a)alumni.ethz.ch> - 2.28.0-1 - update to 2.28.0 -* Sun Feb 13 2011 Thomas Sailer <t.sailer(a)alumni.ethz.ch> - 2.27.93-1 -- update to 2.27.93 - * Tue Feb 08 2011 Fedora Release Engineering <rel-eng(a)lists.fedoraproject.org> - 2.27.4-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild

1 0

[mingw32-glib2/f15/master] (5 commits) ...2.27.93 was not built for f15
by sailer 13 Feb '11

13 Feb '11

Summary of changes: 3f92a4e... update to 2.27.93 (*) 9511343... hack the hack to work on 32 and 64bit builders (*) f59730e... update to 2.28.0 (*) ffde874... Merge branch 'master' of ssh://pkgs.fedoraproject.org/mingw (*) 2f9ef83... 2.27.93 was not built for f15 (*) This commit already existed in another branch; no separate mail sent

1 0

[mingw32-glib2: 2/2] Merge branch 'master' of ssh://pkgs.fedoraproject.org/mingw32-glib2
by sailer 13 Feb '11

13 Feb '11

commit ffde874229d3e036f6d359c169a652768b4c1d31 Merge: f59730e 9511343 Author: Thomas Sailer <t.sailer(a)alumni.ethz.ch> Date: Sun Feb 13 18:14:55 2011 +0100 Merge branch 'master' of ssh://pkgs.fedoraproject.org/mingw32-glib2 mingw32-glib2.spec | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) ---

1 0

[mingw32-glib2: 1/2] update to 2.28.0
by sailer 13 Feb '11

13 Feb '11

commit f59730eadd03dbf6530612e46a7fc7952836f662 Author: Thomas Sailer <t.sailer(a)alumni.ethz.ch> Date: Sun Feb 13 18:14:31 2011 +0100 update to 2.28.0 .gitignore | 3 ++- mingw32-glib2.spec | 5 ++++- sources | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) --- diff --git a/.gitignore b/.gitignore index ffeadbf..633acfa 100644 --- a/.gitignore +++ b/.gitignore @@ -4,4 +4,5 @@ glib-2.27.4.tar.bz2 glib-2.25.15.tar.bz2 glib-2.25.17.tar.bz2 glib-2.26.0.tar.bz2 -/glib-2.28.0.tar.bz2 +glib-2.28.0.tar.bz2 +glib-2.27.93.tar.bz2 diff --git a/mingw32-glib2.spec b/mingw32-glib2.spec index 1c83fe2..e2357f3 100644 --- a/mingw32-glib2.spec +++ b/mingw32-glib2.spec @@ -6,7 +6,7 @@ %define __debug_install_post %{_mingw32_debug_install_post} Name: mingw32-glib2 -Version: 2.27.93 +Version: 2.28.0 Release: 1%{?dist} Summary: MinGW Windows GLib2 library @@ -218,6 +218,9 @@ rm -rf $RPM_BUILD_ROOT %changelog +* Sun Feb 13 2011 Thomas Sailer <t.sailer(a)alumni.ethz.ch> - 2.28.0-1 +- update to 2.28.0 + * Sun Feb 13 2011 Thomas Sailer <t.sailer(a)alumni.ethz.ch> - 2.27.93-1 - update to 2.27.93 diff --git a/sources b/sources index 24db0ea..dde5d67 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -73954628c437408c189d62670a7032f7 glib-2.27.93.tar.bz2 +51dbe36bc03a29a1f9bf6b74fb4a6926 glib-2.28.0.tar.bz2

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

mingw February 2011